Date:   Sat, 18 Mar 2023 16:30:33 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Patrik =?UTF-8?B?RGFobHN0csO2bQ==?= <risca@dalakolonin.se>
Cc:     lars@metafoo.de, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, hns@goldelico.com
Subject: Re: [PATCH] iio: adc: palmas_gpadc: fix NULL dereference on rmmod
Message-ID: <20230318163033.161d6fd5@jic23-huawei>
In-Reply-To: <20230313205029.1881745-1-risca@dalakolonin.se>
References: <20230313205029.1881745-1-risca@dalakolonin.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 13 Mar 2023 21:50:29 +0100
Patrik Dahlstr=C3=B6m <risca@dalakolonin.se> wrote:

> Calling dev_to_iio_dev() on a platform device pointer is undefined and
> will make adc NULL.
>=20
> Signed-off-by: Patrik Dahlstr=C3=B6m <risca@dalakolonin.se>

Hi Patrik,

Looks good so applied to the fixes-togreg branch of iio.git.

Whilst we are here, this would be a trivial driver to take fully device
managed.  The only slightly messy bit is that it would need
a devm_add_action_or_reset() + custom callback to handle the
device_wakeup_enable().

On the off chance you can test it I'll send a patch in a few mins.
Note that will depend on this one going up stream first and that
I haven't done more than build test it.

Thanks,

Jonathan


> ---
>  drivers/iio/adc/palmas_gpadc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/iio/adc/palmas_gpadc.c b/drivers/iio/adc/palmas_gpad=
c.c
> index 61e80bf3d05e..6db6f3bc768a 100644
> --- a/drivers/iio/adc/palmas_gpadc.c
> +++ b/drivers/iio/adc/palmas_gpadc.c
> @@ -638,7 +638,7 @@ static int palmas_gpadc_probe(struct platform_device =
*pdev)
> =20
>  static int palmas_gpadc_remove(struct platform_device *pdev)
>  {
> -	struct iio_dev *indio_dev =3D dev_to_iio_dev(&pdev->dev);
> +	struct iio_dev *indio_dev =3D dev_get_drvdata(&pdev->dev);
>  	struct palmas_gpadc *adc =3D iio_priv(indio_dev);
> =20
>  	if (adc->wakeup1_enable || adc->wakeup2_enable)