Date:   Sat, 18 Mar 2023 16:43:47 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     William Breathitt Gray <william.gray@linaro.org>
Cc:     lars@metafoo.de, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v2] iio: dac: cio-dac: Migrate to the regmap API
Message-ID: <20230318164347.1e96325c@jic23-huawei>
In-Reply-To: <ZAzQ6LyfllSjN16j@fedora>
References: <20230311140218.74920-1-william.gray@linaro.org>
        <20230311185719.7af38a8a@jic23-huawei>
        <ZAzQ6LyfllSjN16j@fedora>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat, 11 Mar 2023 14:05:12 -0500
William Breathitt Gray <william.gray@linaro.org> wrote:

> On Sat, Mar 11, 2023 at 06:57:19PM +0000, Jonathan Cameron wrote:
> > On Sat, 11 Mar 2023 09:02:18 -0500
> > William Breathitt Gray <william.gray@linaro.org> wrote:  
> > > diff --git a/drivers/iio/dac/cio-dac.c b/drivers/iio/dac/cio-dac.c
> > > index 791dd999cf29..759833a6bd29 100644
> > > --- a/drivers/iio/dac/cio-dac.c
> > > +++ b/drivers/iio/dac/cio-dac.c
> > > @@ -6,16 +6,15 @@
> > >   * This driver supports the following Measurement Computing devices: CIO-DAC16,
> > >   * CIO-DAC06, and PC104-DAC06.
> > >   */
> > > -#include <linux/bitops.h>
> > > +#include <linux/bits.h>  
> > 
> > I'm not immediately spotting why this change is part of the regmap
> > conversion.
> > 
> > It may well make sense, but if unrelated, should probably be in a different patch.  
> 
> No you're right, this is an unrelated cleanup that I should probably
> have pulled out to its own dedicated patch. If there is a need for a v3,
> I'll split this off and submit it separately.
> 
Not other comments, so meh. I've had my moan :)

Applied to the togreg branch of iio.git and pushed out as testing for 0-day
to see if it can find anything we missed.

Thanks,

Jonathan

> William Breathitt Gray