From:   Ryan Chen <ryan_chen@aspeedtech.com>
To:     Andi Shyti <andi.shyti@kernel.org>
CC:     Andrew Jeffery <andrew@aj.id.au>,
        Brendan Higgins <brendan.higgins@linux.dev>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Joel Stanley <joel@jms.id.au>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v6 1/2] dt-bindings: i2c: aspeed: support for
 AST2600-i2cv2
Thread-Topic: [PATCH v6 1/2] dt-bindings: i2c: aspeed: support for
 AST2600-i2cv2
Thread-Index: AQHZSZBNCqcj9BIMLU6U/5WV2MINja8AX5gAgAEbpFA=
Date:   Sun, 19 Mar 2023 02:05:46 +0000
Message-ID: <SEZPR06MB5269DB6BE01C48BBFA17876DF2839@SEZPR06MB5269.apcprd06.prod.outlook.com>
References: <20230226031321.3126756-1-ryan_chen@aspeedtech.com>
 <20230226031321.3126756-2-ryan_chen@aspeedtech.com>
 <20230318090936.qvqozqfskpe5lja7@intel.intel>
In-Reply-To: <20230318090936.qvqozqfskpe5lja7@intel.intel>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pPZqomkhpgB9brMyNS4TkOp/R+Z0SQTPVrUlnHXIFvXvxzj3zuRV2Q7URwwT?=
 =?us-ascii?Q?pAj5JqlQfIBkUZrZx+kPylWGFT0mgWp3FzWgP1/Wtf5VCxwBlxlznBEuV+tW?=
 =?us-ascii?Q?yQBFK+fYFkWd8fnLEmxgV4AZw+cX94Sgw8i0uZ3WHAAm0s1QfWdJMc9RwR67?=
 =?us-ascii?Q?lLD/xAt9xrrfRD9usN4zWcC6ECEkKaMQah/wQDlHInBjxU3ZEMbTSFo3Bwq9?=
 =?us-ascii?Q?ezmDldmlqVcodQVXq8nr37wFfOR2a8vtCcviyqu09aiesgaE36nnes2dut7p?=
 =?us-ascii?Q?QkaJoqFA/pZN0o9Rr5DJz47PMY++T2IJP45BfPmUe+SGYxAYWdH5UIN5GrcJ?=
 =?us-ascii?Q?7QNH7pJ7vbqjldLzuhOA+2G2gELO6RVZ1bQaNPQe4whfTcmTq0tgks6ZYVps?=
 =?us-ascii?Q?oRu3/fvFMIQggy3YkOMOoDbp2g9bBKmN7NH8HpxXUNL3oQ+Ub9JcokhSyGcW?=
 =?us-ascii?Q?xicI8kYoCw64SfLXZZKdDDO9TkvIZhXDmC0VFypJfwNElt534NE9iUwvfZot?=
 =?us-ascii?Q?DepVE5LdL0MCnaSoFw/H8ZdMwQZ95Y57mYBXzB8E/CjW34WFt+QKQZqyvCW9?=
 =?us-ascii?Q?AwZ8cZX3MI8QlpDsebqqUZ30hMNRoHz0RVXo1ZhtpIVv2nqAPxxGKByNQKVx?=
 =?us-ascii?Q?Zjs9U3yr21qCgYXe4N1Pu5OA8zXAATruTt/NV5mLDho6SgA3AfAK67YEmxQi?=
 =?us-ascii?Q?ejum5l7/e3uIngEL6h4aA6SqVzcjU4EUNaaznDlxZXOCNP9ttCuKKJBElIsL?=
 =?us-ascii?Q?H/xV50Zmd8vTt/6cJuuMNAaucXZnH5uMp69s46S1/3+s+B8Ezgtme7bOrOCB?=
 =?us-ascii?Q?PoZ2zmgXKo6NGTwhGEDH1c6mm9b8p7McIS/shRmw/ySn1sFcCKLK1BJq158Y?=
 =?us-ascii?Q?sRv0UOZmA5dYuly2rFoI8WncioBUZwfmMK0XuNh1fnBDalSJXkdIDDMHyj7J?=
 =?us-ascii?Q?Kmq5X0/VqpK8wrK/SsRtVpNfM7BhU7FxbqJbFidiMh67ByhXHH2diC1kw5gx?=
 =?us-ascii?Q?U1h1YOMlHXgrT3Dd/aoDVg5vNwp4av94XKA1w9FdoPmW6/IL+4XSxlkEKhaS?=
 =?us-ascii?Q?5f+UJhrfR+yUQG247+fFqiRWc8WCYxiSwbHCn9nomkGW0cL1iTRUryRZ1Sib?=
 =?us-ascii?Q?Q7KPw/iuwph0yTdBcK45hi263VBDRXBzKq/WMCPt6sTIjbIOYBSepddJtVfG?=
 =?us-ascii?Q?DU0/EULdiA8Ri9J4bTs5fkWN2+0eFDo8i2PSSt5xFaIEQDzCP7GOG71Z0HZL?=
 =?us-ascii?Q?x7VPAibyvYn3XEhdTxdXy0+zanmuNG5zahlpzUDBv/bT5FWBxcnOapmfeQdX?=
 =?us-ascii?Q?fxskDDpbD9m1hDgTx0rQWwaKouG/0jPKMm90dgWDeflJ6hWG980c7rGtmrJc?=
 =?us-ascii?Q?LcfclJSAoWdNzKx8zjMXPF6Csywi281o+wVn43Fdz4pOcCqYE6+4p+72MONv?=
 =?us-ascii?Q?J/dg269XLxX+70+lJF0AU8Zat77fcRNdpEv70ypNYYie/13No13go9UoXDxl?=
 =?us-ascii?Q?/LgM7YnBolrPb7k8ZnTO8wQSk8u4K+yXHinRUntySH8aC0A6UVS/4XPnDCd8?=
 =?us-ascii?Q?gb1UHMlUTc4mAxHen9XEjfBptIxuxz7E7L8MMXy8?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b0fc9060-6cf0-4710-bf4e-08db281e745c
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2023 02:05:46.9266
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VAqrP2bi1f0b8sAYEJ2btSjFjPCRHISkWcaFXbRlIisfSW18jdEYbNcnT7fxiXvzL37r32drISBZnD5ryjNxJrOZ5SZLtq+YX+LGpzoKqys=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR06MB3880
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello,

> -----Original Message-----
> From: Andi Shyti <andi.shyti@kernel.org>
> Sent: Saturday, March 18, 2023 5:10 PM
> To: Ryan Chen <ryan_chen@aspeedtech.com>
> Cc: Andrew Jeffery <andrew@aj.id.au>; Brendan Higgins
> <brendan.higgins@linux.dev>; Benjamin Herrenschmidt
> <benh@kernel.crashing.org>; Joel Stanley <joel@jms.id.au>; Rob Herring
> <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Philipp Zabel
> <p.zabel@pengutronix.de>; linux-i2c@vger.kernel.org;
> openbmc@lists.ozlabs.org; devicetree@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v6 1/2] dt-bindings: i2c: aspeed: support for
> AST2600-i2cv2
>=20
> Hi Ryan,
>=20
> On Sun, Feb 26, 2023 at 11:13:20AM +0800, Ryan Chen wrote:
> > Add ast2600-i2cv2 compatible and aspeed,global-regs, aspeed,timeout
> > aspeed,xfer-mode description for ast2600-i2cv2.
> >
> > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
> > ---
> >  .../devicetree/bindings/i2c/aspeed,i2c.yaml   | 44
> +++++++++++++++++++
> >  1 file changed, 44 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> > b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> > index f597f73ccd87..75de3ce41cf5 100644
> > --- a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> > @@ -49,6 +49,25 @@ properties:
> >      description:
> >        states that there is another master active on this bus
> >
> > +  aspeed,timeout:
> > +    type: boolean
> > +    description: I2C bus timeout enable for master/slave mode
>=20
> Finally you can proceed with this. Please remove "aspeed,timeout"
> and use "i2c-scl-has-clk-low-timeout" instead.

Thanks a lot, I will start progress this.=20

Best Regards
Ryan