MIME-Version: 1.0
References: <20221217084155.663235-1-mgorny@gentoo.org> <CAK7LNAQ8=YbOVvugBUQBo8eXRMH+YA49aS-1C=2hCGq0xoW7XA@mail.gmail.com>
 <628c5e32a437ad198866b03f2d6ff8a9c65754df.camel@gentoo.org>
 <897BDBF1-6C6E-4C69-8BA7-FEEFEB8ADC11@gentoo.org> <1416803D-E4E9-426B-8419-60251B8245B7@gentoo.org>
 <87wn3g2qfk.fsf@gentoo.org>
In-Reply-To: <87wn3g2qfk.fsf@gentoo.org>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Sun, 19 Mar 2023 16:43:47 +0900
Message-ID: <CAK7LNATfrxu7BK0ZRq+qSjObiz6GpS3U5L=12vDys5_yy=Mdow@mail.gmail.com>
Subject: Re: [PATCH] kheaders: prefer gtar over tar for better compatibility
To:     Sam James <sam@gentoo.org>
Cc:     =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= <mgorny@gentoo.org>,
        Dmitry Goldin <dgoldin+lkml@protonmail.ch>,
        linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        dist-kernel@gentoo.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

I thought I had relied this before, but
something awkward was happening because
the original email was addressed to
yamada.masahiro@socionext.com, which is
no longer valid.

Resending from masahiroy@kernel.org...


In the top Makefile, please add

TAR  =3D tar

and export TAR.


In kernel/gen_kheaders.sh,
please replace 'tar' with ${TAR:-tar}


On Gentoo systems, you can do

 $ make TAR=3Dgtar


or if you need to run gen_kheaders.sh directly

 $ TAR=3Dgtar scripts/gen_kheaders.sh


Thanks.


On Fri, Mar 17, 2023 at 9:05=E2=80=AFAM Sam James <sam@gentoo.org> wrote:
>
>
> Sam James <sam@gentoo.org> writes:
>
> > [[PGP Signed Part:Undecided]]
> >
> >
> >> On 17 Jan 2023, at 19:01, Sam James <sam@gentoo.org> wrote:
> >>
> >>
> >>
> >>> On 25 Dec 2022, at 16:33, Micha=C5=82 G=C3=B3rny <mgorny@gentoo.org> =
wrote:
> >>>
> >>> On Sun, 2022-12-25 at 01:45 +0900, Masahiro Yamada wrote:
> >>>> Instead of inserting a workaround like this,
> >>>> another way is to allow users to override a variable
> >>>> from the command line.
> >>>>
> >>>>
> >>>> See the top Makefile, for example,
> >>>>
> >>>>
> >>>> AWK             =3D awk
> >>>>
> >>>>
> >>>> Then, users can do "make AWK=3Dgawk"
> >>>
> >>> I'm sorry but are you requesting that I remove the check and use $TAR
> >>> instead, or allow overriding with TAR, and fall back to gtar or tar
> >>> respectively?  If the former, should the script unconditionally assum=
e
> >>> that TAR will be always set in the environment, or include fallback t=
o
> >>> tar for when the script is run directly?
> >>
> >>
> >> Masahiro, what do you reckon? Thanks.
> >>
> >
> > Ping.
>
> ping^2. We'd really love to get this in to fix a bug for our users in
> Gentoo.
>
> >
> >> Best,
> >> sam
> >
> >
> > [[End of PGP Signed Part]]
>

--
Best Regards
Masahiro Yamada