From:   Uladzislau Rezki <urezki@gmail.com>
Date:   Sun, 19 Mar 2023 11:53:40 +0100
To:     "Paul E. McKenney" <paulmck@kernel.org>,
        Theodore Ts'o <tytso@mit.edu>
Cc:     "Uladzislau Rezki (Sony)" <urezki@gmail.com>,
        Theodore Ts'o <tytso@mit.edu>,
        Joel Fernandes <joel@joelfernandes.org>,
        RCU <rcu@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Oleksiy Avramchenko <oleksiy.avramchenko@sony.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Frederic Weisbecker <frederic@kernel.org>,
        linux-ext4@vger.kernel.org, Lukas Czerner <lczerner@redhat.com>,
        Andreas Dilger <adilger.kernel@dilger.ca>
Subject: Re: [PATCH 1/1] ext4: Replace ext4_kvfree_array_rcu() by
 kvfree_rcu_mightsleep()
Message-ID: <ZBbptCj8j3gWVesY@pc636>
References: <20230317071558.335645-1-urezki@gmail.com>
 <28e1585c-7062-49c2-b08e-a5d33ca06577@paulmck-laptop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <28e1585c-7062-49c2-b08e-a5d33ca06577@paulmck-laptop>
Precedence: bulk

On Fri, Mar 17, 2023 at 05:31:04PM -0700, Paul E. McKenney wrote:
> On Fri, Mar 17, 2023 at 08:15:58AM +0100, Uladzislau Rezki (Sony) wrote:
> > The ext4_kvfree_array_rcu() function was introduced in order to
> > release some memory after a grace period during resizing of a
> > partition. An object that is freed does not contain any rcu_head
> > filed.
> > 
> > To do so, it requires to allocate some extra memory for a special
> > structure that has an rcu_head filed and pointer one where a freed
> > memory is attached. Finally call_rcu() API is invoked.
> > 
> > Since we have a single argument of kvfree_rcu() API, we can easily
> > replace all that tricky code by one single call that does the same
> > but in more efficient way.
> > 
> > Cc: linux-ext4@vger.kernel.org
> > Cc: Lukas Czerner <lczerner@redhat.com>
> > Cc: Andreas Dilger <adilger.kernel@dilger.ca>
> > Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
> 
> From an RCU perspective:
> 
> Reviewed-by: Paul E. McKenney <paulmck@kernel.org>
> 
Thank you!

--
Uladzislau Rezki