Date:   Sun, 19 Mar 2023 15:34:07 +0200
From:   Vladimir Oltean <olteanv@gmail.com>
To:     Marek =?utf-8?B?QmVow7pu?= <marek.behun@nic.cz>
Cc:     Klaus Kudielka <klaus.kudielka@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Richard Cochran <richardcochran@gmail.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4 4/4] net: dsa: mv88e6xxx: mask apparently
 non-existing phys during probing
Message-ID: <20230319133407.xb6k2uxcy52a5pzl@skbuf>
References: <20230315163846.3114-1-klaus.kudielka@gmail.com>
 <20230315163846.3114-5-klaus.kudielka@gmail.com>
 <20230319110606.23e30050@thinkpad>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230319110606.23e30050@thinkpad>
Precedence: bulk

On Sun, Mar 19, 2023 at 11:06:06AM +0100, Marek Beh?n wrote:
> > +	bus->phy_mask = GENMASK(31, mv88e6xxx_num_ports(chip));
> 
> shouldnt this be
>   GENMASK(31, mv88e6xxx_num_ports(chip) + chip->info->phy_base_addr) |
>   GENMASK(chip->info->phy_base_addr, 0)
> ?
> Or alternatively
>   ~GENMASK(chip->info->phy_base_addr + mv88e6xxx_num_ports(chip),
>            chip->info->phy_base_addr)

Good point. Would you mind sending a patch? I prefer the second variant BTW.