Date:   Sun, 19 Mar 2023 15:45:33 +0200
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Yu Zhe <yuzhe@nfschina.com>
Cc:     peterhuewe@gmx.de, jgg@ziepe.ca, linux-integrity@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        liqiong@nfschina.com
Subject: Re: [PATCH] tpm: remove unnecessary (void*) conversions
Message-ID: <20230319134533.f63ajqelx6eeadnh@kernel.org>
References: <20230316085037.21255-1-yuzhe@nfschina.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230316085037.21255-1-yuzhe@nfschina.com>
Precedence: bulk

On Thu, Mar 16, 2023 at 04:50:37PM +0800, Yu Zhe wrote:
> Pointer variables of void * type do not require type cast.
> 
> Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
> ---
>  drivers/char/tpm/eventlog/common.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/char/tpm/eventlog/common.c b/drivers/char/tpm/eventlog/common.c
> index 8512ec76d526..639c3f395a5a 100644
> --- a/drivers/char/tpm/eventlog/common.c
> +++ b/drivers/char/tpm/eventlog/common.c
> @@ -36,7 +36,7 @@ static int tpm_bios_measurements_open(struct inode *inode,
>  		inode_unlock(inode);
>  		return -ENODEV;
>  	}
> -	chip_seqops = (struct tpm_chip_seqops *)inode->i_private;
> +	chip_seqops = inode->i_private;
>  	seqops = chip_seqops->seqops;
>  	chip = chip_seqops->chip;
>  	get_device(&chip->dev);
> @@ -55,8 +55,8 @@ static int tpm_bios_measurements_open(struct inode *inode,
>  static int tpm_bios_measurements_release(struct inode *inode,
>  					 struct file *file)
>  {
> -	struct seq_file *seq = (struct seq_file *)file->private_data;
> -	struct tpm_chip *chip = (struct tpm_chip *)seq->private;
> +	struct seq_file *seq = file->private_data;
> +	struct tpm_chip *chip = seq->private;
>  
>  	put_device(&chip->dev);
>  
> -- 
> 2.11.0
> 

Acked-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko