From:   Arthur Simchaev <Arthur.Simchaev@wdc.com>
To:     Arthur Simchaev <Arthur.Simchaev@wdc.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>
CC:     "beanhuo@micron.com" <beanhuo@micron.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1] ufs: core: Add support for qTimestamp attribute
Thread-Topic: [PATCH v1] ufs: core: Add support for qTimestamp attribute
Thread-Index: AQHZUQ7JPGFIrKgc20Sqn2czlPTLfK8CUOKg
Date:   Sun, 19 Mar 2023 15:43:23 +0000
Message-ID: <BY5PR04MB6327B93C10FD442903BD3343ED839@BY5PR04MB6327.namprd04.prod.outlook.com>
References: <1678205182-13943-1-git-send-email-Arthur.Simchaev@wdc.com>
In-Reply-To: <1678205182-13943-1-git-send-email-Arthur.Simchaev@wdc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qh+18m3inA5av5f9YuylFF7dXtM35pE+9siSQS7x5LC9BDOLDK5A9CQAxBWP?=
 =?us-ascii?Q?LUMajROROckEWmWPcB3nCmsA0ab3tdf2Z0uQHSP9egqVieEj+A7jbaE/t2MV?=
 =?us-ascii?Q?o/vK7RtFoX0X5RzyAq/lmJQvp94WCVUjcrY6xsSi6aVxtY9yucAHbst5SDYX?=
 =?us-ascii?Q?OIBGhcnps8CM7Z4RQcrymjXAy+mTMRFiT6+40NHwpB9e4A9GRGUD8KC9xteZ?=
 =?us-ascii?Q?2I8dKYbHht549PyA0nNHNMmd4+R0sEWOX5T5hAWIuMt3p5OhTcLailK1RKT6?=
 =?us-ascii?Q?HL8dcLXMaVP1+rldTr3uIN6IYyESA+XiOfvoJB1XtC7s4H3hy5mkOp1S2GrL?=
 =?us-ascii?Q?Hk8gnrzJSm+7dRnk3bL0qHHzIM2PmrwppzqIDMU0HAJgWiyrYcTRsks0KA/o?=
 =?us-ascii?Q?0YHmaWUMdTwogP1ANSRAFvjBOQoHEpnMqlDKaSY5lPpilvybS4L2XWch4OD4?=
 =?us-ascii?Q?sxPF/AeduzjFs/c471GIn5kykzlerkpztbPES/u6ZSOFh/4WPzv2YyW4hZs/?=
 =?us-ascii?Q?Ph/UM1UC0h8J9VIKd+c+AuCymz41E5be0f7gDccEXYIFACRxL5zz9exZnm9E?=
 =?us-ascii?Q?+jIeshUJwz8a3e7sqSVp7NeiJrheuppB+oiePNE3+JDNI2brRFiY30+bhgbt?=
 =?us-ascii?Q?XL0MOm9pYdUlpUonvPR9JTmcPy7aXIU1l88NqJ909cIAhoYFtlwmSOpiDjXT?=
 =?us-ascii?Q?dE2LtUhkAz5RayoRlfp9CdEA0IWHDHA2P1rb2Iyg3hazC6X2f2wl3vIPfkz6?=
 =?us-ascii?Q?Z/qXox+YJa3uKL6OevXn/gkvQ76J2YegifCs96nF8CYBwjFWHu88Nw04pabx?=
 =?us-ascii?Q?JzOwFj+nuitIp05gZ+DK5i7LXkr8n4Eoza9vmNS1aQ0rh4aW/0pVsnAT/bqC?=
 =?us-ascii?Q?cDUpV41rC2ZE6MkI6XSy3kSc58ntpM5urcrwGBSoxsu1ko+p2gtPRawuxIgG?=
 =?us-ascii?Q?ha+AHN7GSrlUo5/58X+l6FYxqvQaP8D76W85Ypym3qo2ksSqFBZkMXZhxG6/?=
 =?us-ascii?Q?+YZRsVHoVhFKCxzao5JJhUY5a0sD4A6NOFtlQUVDa/jjh2CEyuAYC3EldX/Z?=
 =?us-ascii?Q?9F0D2V8m3tVlQz9n9COMW8BD5ExfUJ5PU+4Ebw9+96CVuBizmu/R7k2oTjiD?=
 =?us-ascii?Q?DhferAytrkK/NGoEDTpO74I9vJqNejZovSB3+hRsqfnYY4hk6oXBTDxzvnsY?=
 =?us-ascii?Q?8hfVNHC2+AaBLEt/DRfrrdDSnJ0nPDVmFdOcXfm/ZJ5JdH7OrJ+otFbqE8KF?=
 =?us-ascii?Q?k85sL3wgNXpJgT5kFSpaHGW9Pk5w7JlbZY4Fst0SdiWj5YoOgEwdFnxn5OJZ?=
 =?us-ascii?Q?cDrrL64LDiSyapHfUkb/DMfeFnBpgOrtE528sjNnNZ02hzkNf3liRfVu+HYp?=
 =?us-ascii?Q?fASQR2XsIEW4qdTbeagi+rDh4+ujTJOmvugtsyAFZCuKUt18ErSwIEgpHueF?=
 =?us-ascii?Q?lrAQdh9HiZjj+X66dhZSN1OroVga5EckRuWqgstLxx375p6gd7i5mRBBVZIf?=
 =?us-ascii?Q?H3ihYIIG1xYhrgH4TWm1cq48+wPEOuf4gkdHAh+Sn/60zcVsCBTkYiFgWOUJ?=
 =?us-ascii?Q?qEul4aezYgJUm0kul4fDQssqIBVfOj/ibyRLKupF?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: HeqSijiZcS006H8DjU20l2Zg2IVe2XRhxWuZXnp7+0T1+67gGd3jhvVjGJXiZ/rwypThnXBc87Mw3/5RJjAjoJd7wCBA4P0TFMvgU3SzBw5a/+9hfQG3hMTxeyYd4OCG783OQOkWFSi1DSA/GK7fQITcNV3xtzGbljpPYYohAcKiwCcJ0luBvel09/zDez+vCa3xve5aMUQSuPEOKDZXW3aZiHce64x7rkdd9g8eDJEimsCsnnUP4E6Fr21vg4PVZ+X2haUcAkpD6oLTxd8mSH4lax9ZlhlXRr5Hc+lNxViF9E2Q9Z/iWkwBz6byrK2kF89WK3jnFx7YC9wMqDXomkqLg8ImeH8x9/yrE6UC8RzMI5lcRU4jOP44mLdJAUOeZ3ozG5t0dfTIJycvYoHrv7UhR+AYvEk4S7jx1+qxnAG/Yw0VEgQhsQrQSjyBQbIRqdhcyw+JxjtX2Jzp1RFhE1hCpKyVyirQFjPpLr4MGY6ra9p4bu36Yhsp4JthaLS/oJRJqhrC2Sj9+caeIDvd/blg7fGdWZvq7fO8GoaUQC1A+bAIGV2lZ8q/xKp5yyw7slIYx8obneUa7DgQPmhbw4sgtu9D/dQBYl6PFTtS5lEByLMT/hVKDVz1A5SUSk5Pta45oqjLwZQxl/ScE/OLrsJIvzst/g1/YNCAY/VETyocftXJiufQSRUrXuacSeUkOjAw6KzufM5nBplPtmBguefMqbIj+fg8kqwI4A2pgvAvLqkeJ7vfR14U4YIqRby53G0eo3KCBjIZXCsfzUTFYd6GiAbMMVIor7ztxROoQUsoeMdtMobZPLNnzLvzcxcO0JxltzBwEbwGEP1+726Fdy6A5gMXJmC8wc2Xc50p3Ts=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6327.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b96274f-865b-4080-52fb-08db2890acb8
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2023 15:43:24.0594
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1hiyQ8YFHwF6Ml745NolDkiaX5mtpDRtWcLHbwfeElgkQMykaFEwxRafFH8Z+1zC5ByqY9xzYlonb9o+sArKtA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR04MB7181
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Gentle reminder

Regards
Arthur

> -----Original Message-----
> From: Arthur Simchaev <Arthur.Simchaev@wdc.com>
> Sent: Tuesday, March 7, 2023 6:06 PM
> To: martin.petersen@oracle.com; bvanassche@acm.org
> Cc: beanhuo@micron.com; linux-scsi@vger.kernel.org; linux-
> kernel@vger.kernel.org; Arthur Simchaev <Arthur.Simchaev@wdc.com>
> Subject: [PATCH v1] ufs: core: Add support for qTimestamp attribute
>=20
> The new qTimestamp attribute was added to UFS 4.0 spec, in order to
> synchronize timestamp between device logs and the host.The spec
> recommend
> to send this attribute upon device power-on Reset/HW reset or when
> switching to Active state (using SSU command). Due to this attribute,
> the attribute's max value was extended to 8 bytes. As a result,
> the new definition of struct utp_upiu_query_v4_0 was added.
>=20
> Signed-off-by: Arthur Simchaev <Arthur.Simchaev@wdc.com>
>=20
> --
> Changes to v1:
> - Add missed response variable to ufshcd_set_timestamp_attr
> ---
>  drivers/ufs/core/ufshcd.c        | 38
> ++++++++++++++++++++++++++++++++++++++
>  include/uapi/scsi/scsi_bsg_ufs.h | 25 +++++++++++++++++++++++++
>  include/ufs/ufs.h                |  1 +
>  3 files changed, 64 insertions(+)
>=20
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 172d25f..cba9ef1 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -8386,6 +8386,41 @@ static int ufshcd_device_params_init(struct
> ufs_hba *hba)
>  	return ret;
>  }
>=20
> +static void ufshcd_set_timestamp_attr(struct ufs_hba *hba)
> +{
> +	int err;
> +	struct ufs_query_req *request =3D NULL;
> +	struct ufs_query_res *response =3D NULL;
> +	struct ufs_dev_info *dev_info =3D &hba->dev_info;
> +	struct utp_upiu_query_v4_0 *upiu_data;
> +
> +	if (dev_info->wspecversion < 0x400)
> +		return;
> +
> +	ufshcd_hold(hba, false);
> +
> +	mutex_lock(&hba->dev_cmd.lock);
> +
> +	ufshcd_init_query(hba, &request, &response,
> +			  UPIU_QUERY_OPCODE_WRITE_ATTR,
> +			  QUERY_ATTR_IDN_TIMESTAMP, 0, 0);
> +
> +	request->query_func =3D
> UPIU_QUERY_FUNC_STANDARD_WRITE_REQUEST;
> +
> +	upiu_data =3D (struct utp_upiu_query_v4_0 *)&request->upiu_req;
> +
> +	put_unaligned_be64(ktime_get_real_ns(), &upiu_data->osf3);
> +
> +	err =3D ufshcd_exec_dev_cmd(hba, DEV_CMD_TYPE_QUERY,
> QUERY_REQ_TIMEOUT);
> +
> +	if (err)
> +		dev_err(hba->dev, "%s: failed to set timestamp %d\n",
> +			__func__, err);
> +
> +	mutex_unlock(&hba->dev_cmd.lock);
> +	ufshcd_release(hba);
> +}
> +
>  /**
>   * ufshcd_add_lus - probe and add UFS logical units
>   * @hba: per-adapter instance
> @@ -8555,6 +8590,8 @@ static int ufshcd_device_init(struct ufs_hba *hba,
> bool init_dev_params)
>  	ufshcd_set_ufs_dev_active(hba);
>  	ufshcd_force_reset_auto_bkops(hba);
>=20
> +	ufshcd_set_timestamp_attr(hba);
> +
>  	/* Gear up to HS gear if supported */
>  	if (hba->max_pwr_info.is_valid) {
>  		/*
> @@ -9592,6 +9629,7 @@ static int __ufshcd_wl_resume(struct ufs_hba
> *hba, enum ufs_pm_op pm_op)
>  		ret =3D ufshcd_set_dev_pwr_mode(hba,
> UFS_ACTIVE_PWR_MODE);
>  		if (ret)
>  			goto set_old_link_state;
> +		ufshcd_set_timestamp_attr(hba);
>  	}
>=20
>  	if (ufshcd_keep_autobkops_enabled_except_suspend(hba))
> diff --git a/include/uapi/scsi/scsi_bsg_ufs.h
> b/include/uapi/scsi/scsi_bsg_ufs.h
> index 2801b65..fd3f9e5e 100644
> --- a/include/uapi/scsi/scsi_bsg_ufs.h
> +++ b/include/uapi/scsi/scsi_bsg_ufs.h
> @@ -71,6 +71,31 @@ struct utp_upiu_query {
>  };
>=20
>  /**
> + * struct utp_upiu_query_v4_0 - upiu request buffer structure for
> + * query request >=3D UFS 4.0 spec.
> + * @opcode: command to perform B-0
> + * @idn: a value that indicates the particular type of data B-1
> + * @index: Index to further identify data B-2
> + * @selector: Index to further identify data B-3
> + * @osf4: spec field B-5
> + * @osf5: spec field B 6,7
> + * @osf6: spec field DW 8,9
> + * @osf7: spec field DW 10,11
> + */
> +struct utp_upiu_query_v4_0 {
> +	__u8 opcode;
> +	__u8 idn;
> +	__u8 index;
> +	__u8 selector;
> +	__u8 osf3;
> +	__u8 osf4;
> +	__be16 osf5;
> +	__be32 osf6;
> +	__be32 osf7;
> +	__be32 reserved;
> +};
> +
> +/**
>   * struct utp_upiu_cmd - Command UPIU structure
>   * @data_transfer_len: Data Transfer Length DW-3
>   * @cdb: Command Descriptor Block CDB DW-4 to DW-7
> diff --git a/include/ufs/ufs.h b/include/ufs/ufs.h
> index 4e8d624..198cb39 100644
> --- a/include/ufs/ufs.h
> +++ b/include/ufs/ufs.h
> @@ -170,6 +170,7 @@ enum attr_idn {
>  	QUERY_ATTR_IDN_WB_BUFF_LIFE_TIME_EST    =3D 0x1E,
>  	QUERY_ATTR_IDN_CURR_WB_BUFF_SIZE        =3D 0x1F,
>  	QUERY_ATTR_IDN_EXT_IID_EN		=3D 0x2A,
> +	QUERY_ATTR_IDN_TIMESTAMP		=3D 0x30
>  };
>=20
>  /* Descriptor idn for Query requests */
> --
> 2.7.4