Date:   Sun, 19 Mar 2023 18:45:25 +0100
From:   Horatiu Vultur <horatiu.vultur@microchip.com>
To:     Tom Rix <trix@redhat.com>
CC:     <rajur@chelsio.com>, <davem@davemloft.net>, <edumazet@google.com>,
        <kuba@kernel.org>, <pabeni@redhat.com>, <nathan@kernel.org>,
        <ndesaulniers@google.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <llvm@lists.linux.dev>
Subject: Re: [PATCH] net: cxgb3: remove unused fl_to_qset function
Message-ID: <20230319174525.kwhlxme7gh45b3un@soft-dev3-1>
References: <20230319172433.1708161-1-trix@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <20230319172433.1708161-1-trix@redhat.com>
Precedence: bulk

The 03/19/2023 13:24, Tom Rix wrote:

Hi Tom,

> 
> clang with W=1 reports
> drivers/net/ethernet/chelsio/cxgb3/sge.c:169:32: error: unused function
>   'fl_to_qset' [-Werror,-Wunused-function]
> static inline struct sge_qset *fl_to_qset(const struct sge_fl *q, int qidx)
>                                ^
> This function is not used, so remove it.

Don't forget to mention in the subject which tree is targeting this
patch.
Other than that looks OK.

Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>

> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/net/ethernet/chelsio/cxgb3/sge.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/chelsio/cxgb3/sge.c b/drivers/net/ethernet/chelsio/cxgb3/sge.c
> index 62dfbdd33365..efa7f401529e 100644
> --- a/drivers/net/ethernet/chelsio/cxgb3/sge.c
> +++ b/drivers/net/ethernet/chelsio/cxgb3/sge.c
> @@ -166,11 +166,6 @@ static u8 flit_desc_map[] = {
>  #endif
>  };
> 
> -static inline struct sge_qset *fl_to_qset(const struct sge_fl *q, int qidx)
> -{
> -       return container_of(q, struct sge_qset, fl[qidx]);
> -}
> -
>  static inline struct sge_qset *rspq_to_qset(const struct sge_rspq *q)
>  {
>         return container_of(q, struct sge_qset, rspq);
> --
> 2.27.0
> 

-- 
/Horatiu