Date:   Sun, 19 Mar 2023 13:55:50 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Jiri Olsa <olsajiri@gmail.com>
Cc:     Florent Revest <revest@chromium.org>, linux-kernel@vger.kernel.org,
        linux-trace-kernel@vger.kernel.org, mhiramat@kernel.org,
        mark.rutland@arm.com, ast@kernel.org, daniel@iogearbox.net,
        kpsingh@kernel.org
Subject: Re: [PATCH 4/7] ftrace: Rename _ftrace_direct_multi APIs to
 _ftrace_direct APIs
Message-ID: <20230319135550.22aaa04b@rorschach.local.home>
In-Reply-To: <ZBcqWqWyq0uW/wj7@krava>
References: <20230316173811.1223508-1-revest@chromium.org>
        <20230316173811.1223508-5-revest@chromium.org>
        <ZBcqWqWyq0uW/wj7@krava>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sun, 19 Mar 2023 16:29:30 +0100
Jiri Olsa <olsajiri@gmail.com> wrote:

> On Thu, Mar 16, 2023 at 06:38:08PM +0100, Florent Revest wrote:
> 
> SNIP
> 
> > diff --git a/samples/Kconfig b/samples/Kconfig
> > index 30ef8bd48ba3..fd24daa99f34 100644
> > --- a/samples/Kconfig
> > +++ b/samples/Kconfig
> > @@ -38,7 +38,7 @@ config SAMPLE_FTRACE_DIRECT
> >  	  that hooks to wake_up_process and prints the parameters.
> >  
> >  config SAMPLE_FTRACE_DIRECT_MULTI  
> 
> nit, we could perhaps remove this config option as well
> and use SAMPLE_FTRACE_DIRECT_MULTI

Remove SAMPLE_FTRACE_DIRECT_MULTI for SAMPLE_FTRACE_DIRECT_MULTI?

-- Steve

> 
> jirka
> 
> > -	tristate "Build register_ftrace_direct_multi() example"
> > +	tristate "Build register_ftrace_direct() on multiple ips example"
> >  	depends on DYNAMIC_FTRACE_WITH_DIRECT_CALLS && m
> >  	depends on HAVE_SAMPLE_FTRACE_DIRECT_MULTI
> >  	help