From:   Jiri Olsa <olsajiri@gmail.com>
Date:   Sun, 19 Mar 2023 19:22:59 +0100
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Jiri Olsa <olsajiri@gmail.com>,
        Florent Revest <revest@chromium.org>,
        linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
        mhiramat@kernel.org, mark.rutland@arm.com, ast@kernel.org,
        daniel@iogearbox.net, kpsingh@kernel.org
Subject: Re: [PATCH 4/7] ftrace: Rename _ftrace_direct_multi APIs to
 _ftrace_direct APIs
Message-ID: <ZBdTA0gKh2xAk5Ay@krava>
References: <20230316173811.1223508-1-revest@chromium.org>
 <20230316173811.1223508-5-revest@chromium.org>
 <ZBcqWqWyq0uW/wj7@krava>
 <20230319135550.22aaa04b@rorschach.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230319135550.22aaa04b@rorschach.local.home>
Precedence: bulk

On Sun, Mar 19, 2023 at 01:55:50PM -0400, Steven Rostedt wrote:
> On Sun, 19 Mar 2023 16:29:30 +0100
> Jiri Olsa <olsajiri@gmail.com> wrote:
> 
> > On Thu, Mar 16, 2023 at 06:38:08PM +0100, Florent Revest wrote:
> > 
> > SNIP
> > 
> > > diff --git a/samples/Kconfig b/samples/Kconfig
> > > index 30ef8bd48ba3..fd24daa99f34 100644
> > > --- a/samples/Kconfig
> > > +++ b/samples/Kconfig
> > > @@ -38,7 +38,7 @@ config SAMPLE_FTRACE_DIRECT
> > >  	  that hooks to wake_up_process and prints the parameters.
> > >  
> > >  config SAMPLE_FTRACE_DIRECT_MULTI  
> > 
> > nit, we could perhaps remove this config option as well
> > and use SAMPLE_FTRACE_DIRECT_MULTI
> 
> Remove SAMPLE_FTRACE_DIRECT_MULTI for SAMPLE_FTRACE_DIRECT_MULTI?
> 

sorry typo, I meant SAMPLE_FTRACE_DIRECT

jirka

> -- Steve
> 
> > 
> > jirka
> > 
> > > -	tristate "Build register_ftrace_direct_multi() example"
> > > +	tristate "Build register_ftrace_direct() on multiple ips example"
> > >  	depends on DYNAMIC_FTRACE_WITH_DIRECT_CALLS && m
> > >  	depends on HAVE_SAMPLE_FTRACE_DIRECT_MULTI
> > >  	help  
>