Date:   Sun, 19 Mar 2023 19:24:05 +0100
From:   Herve Codina <herve.codina@bootlin.com>
To:     Tom Rix <trix@redhat.com>
Cc:     gregkh@linuxfoundation.org, nathan@kernel.org,
        ndesaulniers@google.com, linux-renesas-soc@vger.kernel.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev
Subject: Re: [PATCH] usb: gadget: udc: remove unused usbf_ep_dma_reg_clrset
 function
Message-ID: <20230319192405.6202ea2b@bootlin.com>
In-Reply-To: <20230319155910.1706294-1-trix@redhat.com>
References: <20230319155910.1706294-1-trix@redhat.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Tom,

On Sun, 19 Mar 2023 11:59:10 -0400
Tom Rix <trix@redhat.com> wrote:

> clang with W=3D1 reports
> drivers/usb/gadget/udc/renesas_usbf.c:548:20: error: unused function
>   'usbf_ep_dma_reg_clrset' [-Werror,-Wunused-function]
> static inline void usbf_ep_dma_reg_clrset(struct usbf_ep *ep, uint offset,
>                    ^
> This function is not used, so remove it.
>=20
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/usb/gadget/udc/renesas_usbf.c | 11 -----------
>  1 file changed, 11 deletions(-)
>=20
> diff --git a/drivers/usb/gadget/udc/renesas_usbf.c b/drivers/usb/gadget/u=
dc/renesas_usbf.c
> index cb23e62e8a87..84ac9fe4ce7f 100644
> --- a/drivers/usb/gadget/udc/renesas_usbf.c
> +++ b/drivers/usb/gadget/udc/renesas_usbf.c
> @@ -545,17 +545,6 @@ static inline void usbf_ep_dma_reg_bitclr(struct usb=
f_ep *ep, uint offset,
>  	usbf_ep_dma_reg_writel(ep, offset, tmp);
>  }
> =20
> -static inline void usbf_ep_dma_reg_clrset(struct usbf_ep *ep, uint offse=
t,
> -					  u32 clr, u32 set)
> -{
> -	u32 tmp;
> -
> -	tmp =3D usbf_ep_dma_reg_readl(ep, offset);
> -	tmp &=3D ~clr;
> -	tmp |=3D set;
> -	usbf_ep_dma_reg_writel(ep, offset, tmp);
> -}
> -
>  static void usbf_ep0_send_null(struct usbf_ep *ep0, bool is_data1)
>  {
>  	u32 set;

Yes, indeed.

Acked-by: Herve Codina <herve.codina@bootlin.com>

Thanks for the patch.
Regards,
Herv=C3=A9

--=20
Herv=C3=A9 Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com