Date:   Sun, 19 Mar 2023 19:42:16 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     Tom Rix <trix@redhat.com>
Cc:     Liam.Howlett@oracle.com, nathan@kernel.org,
        ndesaulniers@google.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] maple_tree: remove unused maple_tree functions
Message-ID: <ZBdlmDVKdrtM4BXb@casper.infradead.org>
References: <20230319132903.1702426-1-trix@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230319132903.1702426-1-trix@redhat.com>
Precedence: bulk

On Sun, Mar 19, 2023 at 09:29:03AM -0400, Tom Rix wrote:
> clang with W=1 reports
> lib/maple_tree.c:331:21: error: unused function
>   'mte_set_full' [-Werror,-Wunused-function]
> static inline void *mte_set_full(const struct maple_enode *node)
>                     ^
> lib/maple_tree.c:336:21: error: unused function
>   'mte_clear_full' [-Werror,-Wunused-function]
> static inline void *mte_clear_full(const struct maple_enode *node)
>                     ^
> lib/maple_tree.c:341:20: error: unused function
>   'mte_has_null' [-Werror,-Wunused-function]
> static inline bool mte_has_null(const struct maple_enode *node)
>                    ^
> These static functions are not used, so remove them.

No.  They're just not used yet.  NACK.