Date:   Sun, 19 Mar 2023 21:13:07 +0100
From:   Henrik Grimler <henrik@grimler.se>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        alim.akhtar@samsung.com, m.szyprowski@samsung.com,
        jenneron@protonmail.com, markuss.broks@gmail.com,
        martin.juecker@gmail.com, virag.david003@gmail.com,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v5 1/2] ARM: dts: exynos: replace mshc0 alias with
 mmc-ddr-1_8v property
Message-ID: <ZBds0zxxRYHEJKP+@L14.lan>
References: <20230316211558.8526-1-henrik@grimler.se>
 <20230316211558.8526-2-henrik@grimler.se>
 <20db729f-e8fb-3d16-54a2-b9a54b9a1b55@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20db729f-e8fb-3d16-54a2-b9a54b9a1b55@linaro.org>
Precedence: bulk

Hi Krzysztof,

On Fri, Mar 17, 2023 at 12:55:40PM +0100, Krzysztof Kozlowski wrote:
> On 16/03/2023 22:15, Henrik Grimler wrote:
> > Previously, the mshc0 alias has been necessary so that
> > MMC_CAP_1_8V_DDR | MMC_CAP_8_BIT_DATA are set for mshc_0/mmc_0.
> > However, these capabilities should be described in the device tree so
> > that we do not have to rely on the alias.
> > 
> > The property mmc-ddr-1_8v replaces MMC_CAP_1_8V_DDR, while bus_width =
> > <8>, which is already set for all the mshc0/mmc0 nodes, replaces
> > MMC_CAP_8_BIT_DATA.
> > 
> > Also drop other mshc aliases as they are not needed.
> > 
> > Signed-off-by: Henrik Grimler <henrik@grimler.se>
> > Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > 
> > ---
> > 
> > Changes since v4:
> > * Do not set mmc-ddr-1_8v for sdhci_0 on Exynos 4210,
> >   following Marek's tests
> > 
> > Changes since v3:
> > * Drop attempt at node sorting/cleaning
> > * Move two mmc alias additions to the other patch
> > * Update commit message
> > 
> > Changes since v2:
> > * Set mmc-ddr-1_8v in device trees for mshc_0/mmc_0
> > 
> > 
> >  arch/arm/boot/dts/exynos3250-artik5.dtsi            | 1 +
> >  arch/arm/boot/dts/exynos3250-monk.dts               | 1 +
> >  arch/arm/boot/dts/exynos3250-rinato.dts             | 1 +
> 
> Why you do not remove Exynos3250 aliases?

Thanks for spotting that, seems I accidentally dropped removal when
going from v3 to v4.  Will remove them again in next version, and drop
Marek's test tag since rinato is one of the devices he tests (or used
to test).

> Best regards,
> Krzysztof

Best regards,
Henrik Grimler