Message-ID: <402ffcbe-bb29-7035-68f4-2741532a6d67@gmail.com>
Date:   Sun, 19 Mar 2023 23:07:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] staging: greybus: use inline function for macros
Content-Language: en-US
To:     Julia Lawall <julia.lawall@inria.fr>
Cc:     gregkh@linuxfoundation.org, outreachy@lists.linux.dev,
        johan@kernel.org, elder@kernel.org, linux-kernel@vger.kernel.org,
        linux-staging@lists.linux.dev
References: <20230319201324.253874-1-eng.mennamahmoud.mm@gmail.com>
 <alpine.DEB.2.22.394.2303192121170.2867@hadrien>
 <0f02a3ff-801b-1e1f-5c03-009a05708709@gmail.com>
 <alpine.DEB.2.22.394.2303192151330.2867@hadrien>
From:   Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
In-Reply-To: <alpine.DEB.2.22.394.2303192151330.2867@hadrien>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On ١٩‏/٣‏/٢٠٢٣ ٢٢:٥٥, Julia Lawall wrote:
>
> On Sun, 19 Mar 2023, Menna Mahmoud wrote:
>
>> On ١٩/٣/٢٠٢٣ ٢٢:٢١, Julia Lawall wrote:
>>> On Sun, 19 Mar 2023, Menna Mahmoud wrote:
>>>
>>>> Convert `to_gbphy_dev` and `to_gbphy_driver` macros into a
>>>> static inline functions.
>>>>
>>>> it is not great to have macro that use `container_of` macro,
>>>> because from looking at the definition one cannot tell what type
>>>> it applies to.
>>>>
>>>> One can get the same benefit from an efficiency point of view
>>>> by making an inline function.
>>>>
>>>> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
>>>> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
>>>> ---
>>>>    drivers/staging/greybus/gbphy.h | 10 ++++++++--
>>>>    1 file changed, 8 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/staging/greybus/gbphy.h
>>>> b/drivers/staging/greybus/gbphy.h
>>>> index 1de510499480..42c4e3fe307c 100644
>>>> --- a/drivers/staging/greybus/gbphy.h
>>>> +++ b/drivers/staging/greybus/gbphy.h
>>>> @@ -16,7 +16,10 @@ struct gbphy_device {
>>>>    	struct device dev;
>>>>    };
>>>>
>>> You have made the patch against your previous patch that added a newline
>>> here.  It should be against Greg's tree.
>>>
>>> julia
>> you mean I should remove this newline, right?
> You should apply your change to the state of Greg's tree, not the state
> after your patch.
>
> Assuming that you have committed both the patch adding the new line and
> the patch changing the macro to a function, and have made no other
> changes, you can do git rebase -i HEAD~2 and the put a d at the beginning
> of the line related to the patch adding the newline.


you mean drop this patch "staging: greybus: remove unnecessary blank line"?

Menna


> If you have made
> more changes, you can adapt the HEAD~ part accordingly.
>
> julia
>
>
>>
>> Menna
>>
>>>> -#define to_gbphy_dev(d) container_of(d, struct gbphy_device, dev)
>>>> +static inline struct gbphy_device *to_gbphy_dev(const struct device *d)
>>>> +{
>>>> +	return container_of(d, struct gbphy_device, dev);
>>>> +}
>>>>
>>>>    static inline void *gb_gbphy_get_data(struct gbphy_device *gdev)
>>>>    {
>>>> @@ -45,7 +48,10 @@ struct gbphy_driver {
>>>>    	struct device_driver driver;
>>>>    };
>>>>
>>>> -#define to_gbphy_driver(d) container_of(d, struct gbphy_driver, driver)
>>>> +static inline struct gbphy_driver *to_gbphy_driver(struct device_driver
>>>> *d)
>>>> +{
>>>> +	return container_of(d, struct gbphy_driver, driver);
>>>> +}
>>>>
>>>>    int gb_gbphy_register_driver(struct gbphy_driver *driver,
>>>>    			     struct module *owner, const char *mod_name);
>>>> --
>>>> 2.34.1
>>>>
>>>>
> >