IronPort-SDR: Q3iJF1edugJvYKh66IwJI9tdq73lubjv99XiGhtSHLG/7Auw7ujq/7H7YGV3hqjAI7sKKV1biu
 x1DB4ZU22WBGcrMByU3b1bsbZwzA18MfzyTD95Ro8SCcdM+N9jqS95yqH8Pdgn/n6xqfcv8Gh0
 llAKPvtc5cBkvGCx7UuhVKMfD1QYiZai9lKnd1oLnUpud7yd0F2Jh0rhQtnDSgyYQ0UJv5lfn5
 wmoLKtGx2ZTtJw/2z9Lz+pMi/8qX9p55W+xe5JJfBOmJ/i4nxkjHc20oPR+Lyh2nuQ4V9zN6cs
 OrM=
IronPort-SDR: xG06wtZR+Gr26GiHE+Tgw6InokIL1Z8XQwtGSnEadAnYt8zHnknWx9ofKtHtK9Jj2baA8FHjYW
 YTxywvOY5HlXuf50mgHz6vikLp/iWml3TO+3iTkKFviA40F+FCoRegISxLXBZVjCVVoCVzn3j4
 fNfnln7kVBj8/1PWCglC07Z3vr34w4qfM62yRq71/oLXKVbdJ44rblDTf5BFxEWiCwGiZD8OtX
 h6wUl+lCQ+l4/AqlsuuiyT2nuPJUtc0JzxOqcp/n2L5KONhGObkssOvZRa6Ak6HHLT69x6Ri3M
 3RA=
WDCIronportException: Internal
Message-ID: <e98525c5-9420-63f8-a1f3-009601d02f2c@opensource.wdc.com>
Date:   Mon, 20 Mar 2023 06:42:36 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v2, RESEND 04/10] zonefs: convert to kobject_del_and_put()
Content-Language: en-US
To:     Yangtao Li <frank.li@vivo.com>,
        Naohiro Aota <naohiro.aota@wdc.com>,
        Johannes Thumshirn <jth@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230319092641.41917-1-frank.li@vivo.com>
 <20230319092641.41917-4-frank.li@vivo.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20230319092641.41917-4-frank.li@vivo.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/19/23 18:26, Yangtao Li wrote:
> Use kobject_del_and_put() to simplify code.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
>  fs/zonefs/sysfs.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/zonefs/sysfs.c b/fs/zonefs/sysfs.c
> index 8ccb65c2b419..5e117188fbb5 100644
> --- a/fs/zonefs/sysfs.c
> +++ b/fs/zonefs/sysfs.c
> @@ -113,8 +113,7 @@ void zonefs_sysfs_unregister(struct super_block *sb)
>  	if (!sbi || !sbi->s_sysfs_registered)
>  		return;
>  
> -	kobject_del(&sbi->s_kobj);
> -	kobject_put(&sbi->s_kobj);
> +	kobject_del_and_put(&sbi->s_kobj);
>  	wait_for_completion(&sbi->s_kobj_unregister);

There is no function kobject_del_and_put() in rc3. I guess it is introduced by
this series but since you did not send everything, it is impossible to review.
Please always send the full patch series so that reviewers have all the context
that is needed to review/ack.

>  }
>  

-- 
Damien Le Moal
Western Digital Research