Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753978AbXIRVFf (ORCPT ); Tue, 18 Sep 2007 17:05:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751418AbXIRVF2 (ORCPT ); Tue, 18 Sep 2007 17:05:28 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:42285 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751399AbXIRVF0 (ORCPT ); Tue, 18 Sep 2007 17:05:26 -0400 Date: Tue, 18 Sep 2007 14:05:08 -0700 From: Andrew Morton To: Mathieu Desnoyers Cc: linux-kernel@vger.kernel.org, wli@holomorphy.com, sparclinux@vger.kernel.org, Guennadi Liakhovetski , Dmitry Torokhov Subject: Re: 2.6.23-rc6-mm1 sparc build error Message-Id: <20070918140508.e2c56212.akpm@linux-foundation.org> In-Reply-To: <20070918205403.GA13650@Krystal> References: <20070918011841.2381bd93.akpm@linux-foundation.org> <20070918205403.GA13650@Krystal> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.6; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2132 Lines: 27 On Tue, 18 Sep 2007 16:54:03 -0400 Mathieu Desnoyers wrote: > I got the following error when building 2.6.23-rc6-mm1 on sparc: > > > /opt/crosstool/gcc-4.1.1-glibc-2.3.6/sparc-unknown-linux-gnu/bin/sparc-unknown-linux-gnu-gcc -Wp,-MD,drivers/serial/.serial_core.o.d -nostdinc -isystem /opt/crosstool/gcc-4.1.1-glibc-2.3.6/sparc-unknown-linux-gnu/lib/gcc/sparc-unknown-linux-gnu/4.1.1/include -D__KERNEL__ -Iinclude -Iinclude2 -I/home/compudj/git/linux-2.6-lttng/include -include include/linux/autoconf.h -I/home/compudj/git/linux-2.6-lttng/drivers/serial -Idrivers/serial -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror-implicit-function-declaration -Os -m32 -pipe -mno-fpu -fcall-used-g5 -fcall-used-g7 -fomit-frame-pointer -fno-stack-protector -Wdeclaration-after-statement -Wno-pointer-sign -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(serial_core)" -D"KBUILD_MODNAME=KBUILD_STR(serial_core)" -c -o drivers/serial/.tmp_serial_core.o /home/compudj/git/linux-2.6-lttng/drivers/serial/serial_core.c > /home/compudj/git/linux-2.6-lttng/drivers/serial/serial_core.c: In function 'uart_suspend_port': > /home/compudj/git/linux-2.6-lttng/drivers/serial/serial_core.c:1980: error: implicit declaration of function 'enable_irq_wake' > /home/compudj/git/linux-2.6-lttng/drivers/serial/serial_core.c: In function 'uart_resume_port': > /home/compudj/git/linux-2.6-lttng/drivers/serial/serial_core.c:2035: error: implicit declaration of function 'disable_irq_wake' hm, I wonder why I didn't hit that. enable_irq_wake() was added by wake-up-from-a-serial-port.patch I note that git-input adds a call too, and might have a problem with !CONFIG_GENERIC_HARDIRQS. Not sure what the best fix is here. We could sprinkle ifdefs all over the code, or just add the suitable empty stubs for enable_irq_wake(), etc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/