Date:   Mon, 20 Mar 2023 10:36:45 +0800
From:   Cai Huoqing <cai.huoqing@linux.dev>
To:     Lars-Peter Clausen <lars@metafoo.de>
Cc:     fancer.lancer@gmail.com,
        Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
        Vinod Koul <vkoul@kernel.org>,
        Jingoo Han <jingoohan1@gmail.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
        Rob Herring <robh@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
        linux-pci@vger.kernel.org
Subject: Re: [PATCH v7 3/5] dmaengine: dw-edma: Add support for native HDMA
Message-ID: <ZBfGvRL8cHuj1tJF@chq-MS-7D45>
References: <20230315012840.6986-1-cai.huoqing@linux.dev>
 <20230315012840.6986-4-cai.huoqing@linux.dev>
 <02216197-6cbd-319d-1015-bfb4449ead85@metafoo.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <02216197-6cbd-319d-1015-bfb4449ead85@metafoo.de>
Precedence: bulk

On 18 3月 23 06:49:41, Lars-Peter Clausen wrote:
> On 3/14/23 18:28, Cai Huoqing wrote:
> > Add support for HDMA NATIVE, as long the IP design has set
> > 
> > diff --git a/drivers/dma/dw-edma/dw-hdma-v0-regs.h b/drivers/dma/dw-edma/dw-hdma-v0-regs.h
> > new file mode 100644
> > index 000000000000..0a6032aa1a33
> > --- /dev/null
> > +++ b/drivers/dma/dw-edma/dw-hdma-v0-regs.h
> > @@ -0,0 +1,130 @@
> > 
> > +struct dw_hdma_v0_ch_regs {
> > [...]
> > +	u32 msi_msgdata;			/* 0x00a8 */
> > +	u32 padding_2[21];			/* 0x00ac..0x00e8 */
> The comment here is wrong. This goes all the way to 0x00fc.

Will fix, if send next version.

Thanks,
Cai-

> > +} __packed;
> > +
>