From:   "Jungseung Lee" <js07.lee@samsung.com>
To:     "'Tejun Heo'" <tj@kernel.org>
Cc:     "'Lai Jiangshan'" <jiangshanlai@gmail.com>,
        "'Rafael J. Wysocki'" <rafael@kernel.org>,
        "'Pavel Machek'" <pavel@ucw.cz>,
        "'Len Brown'" <len.brown@intel.com>,
        <linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
        <bw365.lee@samsung.com>, <yw85.kim@samsung.com>,
        <huijin.park@samsung.com>
In-Reply-To: <ZBTmtiyHpreu2btd@slm.duckdns.org>
Subject: RE: [PATCH] workqueue: Introduce show_freeze_workqueues_busy
Date:   Mon, 20 Mar 2023 11:55:50 +0900
Message-ID: <03f001d95ad7$7a9146f0$6fb3d4d0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Thread-Index: AQHQtHBulJt7mcjMc08WTb80894JlAHeG8i/AzetQiCu65bJ8A==
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20230315130515epcas1p40823f20da586c1b5813b41e66e754309@epcas1p4.samsung.com>
        <1678884357-38253-1-git-send-email-js07.lee@samsung.com>
        <ZBTmtiyHpreu2btd@slm.duckdns.org>
Precedence: bulk

Hi, Tejun

>-----Original Message-----
>From: Tejun Heo <htejun@gmail.com> On Behalf Of Tejun Heo
>Sent: Saturday, March 18, 2023 7:16 AM
>To: Jungseung Lee <js07.lee@samsung.com>
>Cc: Lai Jiangshan <jiangshanlai@gmail.com>; Rafael J. Wysocki
><rafael@kernel.org>; Pavel Machek <pavel@ucw.cz>; Len Brown
><len.brown@intel.com>; linux-kernel@vger.kernel.org; linux-
>pm@vger.kernel.org; bw365.lee@samsung.com; yw85.kim@samsung.com;
>huijin.park@samsung.com
>Subject: Re: [PATCH] workqueue: Introduce show_freeze_workqueues_busy
>
>Hello,
>
>A few nits.
>
>On Wed, Mar 15, 2023 at 09:45:57PM +0900, Jungseung Lee wrote:
>> diff --git a/kernel/power/process.c b/kernel/power/process.c index
>> 6c1c7e5..590550f 100644
>> --- a/kernel/power/process.c
>> +++ b/kernel/power/process.c
>> @@ -93,7 +93,7 @@ static int try_to_freeze_tasks(bool user_only)
>>  		       todo - wq_busy, wq_busy);
>>
>>  		if (wq_busy)
>> -			show_all_workqueues();
>> +			show_freeze_workqueues_busy();
>
>Maybe name this show_freezable_workqueues()?
>
>> @@ -5043,7 +5043,7 @@ static void show_one_worker_pool(struct
>> worker_pool *pool)
>>  /**
>>   * show_all_workqueues - dump workqueue state
>>   *
>> - * Called from a sysrq handler or try_to_freeze_tasks() and prints
>> out
>> + * Called from a sysrq handler and prints out
>>   * all busy workqueues and pools.
>
>Can you reflow the comment to 80-col?
>
>> +/**
>> + * show_freeze_workqueues_busy - dump freezable workqueue state
>> + *
>> + * Called from try_to_freeze_tasks() and prints out
>> + * all freezable workqueues still busy.
>
>Ditto.
>

Thank you for the review and I will send a new patch including what you
mentioned soon

Thanks,

>Thanks.
>
>--
>tejun