Date:   Sun, 19 Mar 2023 21:33:45 -0700
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     Andi Shyti <andi.shyti@kernel.org>
Cc:     Matthias Benkmann <matthias.benkmann@gmail.com>,
        linux-input@vger.kernel.org, Nate Yocom <nate@yocom.org>,
        hadess@hadess.net, benjamin.tissoires@redhat.com,
        linux-kernel@vger.kernel.org, Pavel Rojtberg <rojtberg@gmail.com>
Subject: Re: [PATCH v3] Fix incorrectly applied patch for MAP_PROFILE_BUTTON
Message-ID: <ZBfiKc2IHtonxy7o@google.com>
References: <CAK4gqCCk7ipRbZ=LM8Nsj+nE2S6v6QN39ziYSr3d2NmVMHULYg@mail.gmail.com>
 <20230318162106.0aef4ba5@ninja>
 <20230318180047.3pzcep5roaon3nph@intel.intel>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230318180047.3pzcep5roaon3nph@intel.intel>
Precedence: bulk

On Sat, Mar 18, 2023 at 07:00:47PM +0100, Andi Shyti wrote:
> On Sat, Mar 18, 2023 at 04:21:06PM +0100, Matthias Benkmann wrote:
> > When the linked patch was applied,
> 
> Please refer to the patch as "commit fff1011a26d6 ("Input: xpad -
> add X-Box Adaptive Profile button")" and not as "linked patch".
> 
> > one hunk ended up in the wrong function. This patch moves it to where
> > it probably belongs.
> 
> probably? We need to be sure here :)
> 
> Besides, please, use the imperative form, not "this patch moves"
> but "move what where", please be more specific.

Reworded and applied, thank you.

-- 
Dmitry