Date:   Sun, 19 Mar 2023 21:43:12 -0700
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     msizanoen <msizanoen@qtmlabs.xyz>
Cc:     hdegoede@redhat.com, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org, pali@kernel.org,
        stable@vger.kernel.org
Subject: Re: [PATCH v2] input: alps: fix compatibility with -funsigned-char
Message-ID: <ZBfkYEe0LfITyiUh@google.com>
References: <20230318144206.14309-1-msizanoen@qtmlabs.xyz>
 <20230320001731.175969-1-msizanoen@qtmlabs.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230320001731.175969-1-msizanoen@qtmlabs.xyz>
Precedence: bulk

Hi,

On Mon, Mar 20, 2023 at 01:17:31AM +0100, msizanoen wrote:
> The AlpsPS/2 code previously relied on the assumption that `char` is a
> signed type, which was true on x86 platforms (the only place where this
> driver is used) before kernel 6.2. However, on 6.2 and later, this
> assumption is broken due to the introduction of -funsigned-char as a new
> global compiler flag.
> 
> Fix this by explicitly specifying the signedness of `char` when sign
> extending the values received from the device.
> 
> v2:
> 	Add explicit signedness to more places
> 
> Fixes: f3f33c677699 ("Input: alps - Rushmore and v7 resolution support")
> Cc: stable@vger.kernel.org
> Signed-off-by: msizanoen <msizanoen@qtmlabs.xyz>

Please use s8 instead of signed char. Also, could you please tell me if
"msizanoen" is your real name? It is required in the DCO. Apologies if
it really is.

Thanks.

-- 
Dmitry