Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB404C7618A for ; Mon, 20 Mar 2023 05:07:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229596AbjCTFHi (ORCPT ); Mon, 20 Mar 2023 01:07:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbjCTFHh (ORCPT ); Mon, 20 Mar 2023 01:07:37 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC7001E9EA for ; Sun, 19 Mar 2023 22:07:35 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id bc12so10641394plb.0 for ; Sun, 19 Mar 2023 22:07:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679288855; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=MPrWJir7lxNPo+Fx2Bwr880Bubqv8L6flAF9k6fJd4s=; b=VX+eQ7yGRVLcTA8EaiCuPDB6d0xUlH6meWFgwh+6i4u5WJzUd6iJOzfSlzyzsydBMf dYuiqg4FNvslYTT3n1bTihxrbfIiOCcTXB0RcmDcTPAYdOAlWkR1i2eTWYd9u2TJWUiE ZNZhS8k+oZ5aa+tN5ztiVklB1OBlL2UTKRDUHGLVMAiTAN4zISUTwkZb9Lg6r7HP762s oxVkW2uZD+C+BwXrqerjFj94luA9ZsccCVAWEsf+osdzAhTocxjq7AHC5KlmkSXoX3pz zMJSvCI78l16NvKu8EQev0IjfSOZ4y6/mPEY97UREOhpZa/oYgDNF04++m805Pqe3KFe iwlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679288855; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MPrWJir7lxNPo+Fx2Bwr880Bubqv8L6flAF9k6fJd4s=; b=6P6gyYkVnox1tsHgK3PcTkVVj7LPT1E/oT+Iwqa/ZJY+gUOAk3ks5UI5q5p5VonsbY XyNXsge6JWEQONWmAWtHGXZXKah1wC0ySQFMTu2cHEDKLtTu1Copk3NrmuQ77gL31ibM zf/kbdjkvw2+oFpHNQxCqljAhFV9WnybAKp/XdK2CqTmEp/e6ka+c2fOpHqxxAq6QNi/ yjIYtAA5yteKmpnxgd5rkVTcV7/ZE+/Q9nviFX8Rmi7dR6FHfPfYEZwSb0kACCpm9pXf ahPtLZAtQBBNs20s3Y9Sa3ZcQf9SYAuBN4Wt3kiHW5ksy4oMVPbh/6WMnFo+yAqsGix7 GsWg== X-Gm-Message-State: AO0yUKWPtSUqycpeX1Jaxbk/okldItZuT8BKvtvi8LYABYYPZZgXzsvE Q9pyArIAZ7BBzMCZ+fJNaCPpuN1sQ7Z7vm5C X-Google-Smtp-Source: AK7set+GGgmglo4vRa9zphM2IwxvHeCQk2EBYx+5S03fZFG7lSc2pB9X9MUkH3K9gbCVYgky1m7MaQ== X-Received: by 2002:a17:902:dcd4:b0:19c:a866:6a76 with SMTP id t20-20020a170902dcd400b0019ca8666a76mr14557422pll.42.1679288855393; Sun, 19 Mar 2023 22:07:35 -0700 (PDT) Received: from CloudiRingWorld ([125.121.39.5]) by smtp.gmail.com with ESMTPSA id b4-20020a170902a9c400b0019f3da8c2a4sm5578296plr.69.2023.03.19.22.07.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Mar 2023 22:07:35 -0700 (PDT) Date: Mon, 20 Mar 2023 13:07:31 +0800 From: Kloudifold To: outreachy@lists.linux.dev, teddy.wang@siliconmotion.com, sudipm.mukherjee@gmail.com, gregkh@linuxfoundation.org, alison.schofield@intel.com Cc: linuxstaging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4] staging: sm750: Rename sm750_hw_cursor_* functions to snake_case Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sm750 driver has sm750_hw_cursor_* functions, which are named in camelcase. Rename them to snake case to follow the function naming convention. - sm750_hw_cursor_setSize => sm750_hw_cursor_set_size - sm750_hw_cursor_setPos => sm750_hw_cursor_set_pos - sm750_hw_cursor_setColor => sm750_hw_cursor_set_color - sm750_hw_cursor_setData => sm750_hw_cursor_set_data - sm750_hw_cursor_setData2 => sm750_hw_cursor_set_data2 Reported-by: kernel test robot Link: https://lore.kernel.org/oe-kbuild-all/202303110849.X24WnHnM-lkp@intel.com/ Signed-off-by: Kloudifold --- Changes in v4: - Update the commit msg (Deepak) - Use tabs replace 8 spaces This v4 patch was prompted by 2 errors, 2 warnings and 1 checks reported by the scripts/checkpatch.pl, which detected the style problem. Changes in v3: - Add this changelog (Philipp) - Move lkp tags and link to the correct location in commit log (Alison) - Update the commit msg (Philip) - Update the commit log (Bagas, Julia) Changes in v2: - Use new function names in call sites (LKP) drivers/staging/sm750fb/sm750.c | 22 +++++++++++----------- drivers/staging/sm750fb/sm750_cursor.c | 14 +++++++------- drivers/staging/sm750fb/sm750_cursor.h | 12 ++++++------ 3 files changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index effc7fcc3..5d7249e82 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -121,14 +121,14 @@ static int lynxfb_ops_cursor(struct fb_info *info, struct fb_cursor *fbcursor) sm750_hw_cursor_disable(cursor); if (fbcursor->set & FB_CUR_SETSIZE) - sm750_hw_cursor_setSize(cursor, - fbcursor->image.width, - fbcursor->image.height); + sm750_hw_cursor_set_size(cursor, + fbcursor->image.width, + fbcursor->image.height); if (fbcursor->set & FB_CUR_SETPOS) - sm750_hw_cursor_setPos(cursor, - fbcursor->image.dx - info->var.xoffset, - fbcursor->image.dy - info->var.yoffset); + sm750_hw_cursor_set_pos(cursor, + fbcursor->image.dx - info->var.xoffset, + fbcursor->image.dy - info->var.yoffset); if (fbcursor->set & FB_CUR_SETCMAP) { /* get the 16bit color of kernel means */ @@ -142,14 +142,14 @@ static int lynxfb_ops_cursor(struct fb_info *info, struct fb_cursor *fbcursor) ((info->cmap.green[fbcursor->image.bg_color] & 0xfc00) >> 5) | ((info->cmap.blue[fbcursor->image.bg_color] & 0xf800) >> 11); - sm750_hw_cursor_setColor(cursor, fg, bg); + sm750_hw_cursor_set_color(cursor, fg, bg); } if (fbcursor->set & (FB_CUR_SETSHAPE | FB_CUR_SETIMAGE)) { - sm750_hw_cursor_setData(cursor, - fbcursor->rop, - fbcursor->image.data, - fbcursor->mask); + sm750_hw_cursor_set_data(cursor, + fbcursor->rop, + fbcursor->image.data, + fbcursor->mask); } if (fbcursor->enable) diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c index 43e6f52c2..ff643e33f 100644 --- a/drivers/staging/sm750fb/sm750_cursor.c +++ b/drivers/staging/sm750fb/sm750_cursor.c @@ -58,13 +58,13 @@ void sm750_hw_cursor_disable(struct lynx_cursor *cursor) poke32(HWC_ADDRESS, 0); } -void sm750_hw_cursor_setSize(struct lynx_cursor *cursor, int w, int h) +void sm750_hw_cursor_set_size(struct lynx_cursor *cursor, int w, int h) { cursor->w = w; cursor->h = h; } -void sm750_hw_cursor_setPos(struct lynx_cursor *cursor, int x, int y) +void sm750_hw_cursor_set_pos(struct lynx_cursor *cursor, int x, int y) { u32 reg; @@ -73,7 +73,7 @@ void sm750_hw_cursor_setPos(struct lynx_cursor *cursor, int x, int y) poke32(HWC_LOCATION, reg); } -void sm750_hw_cursor_setColor(struct lynx_cursor *cursor, u32 fg, u32 bg) +void sm750_hw_cursor_set_color(struct lynx_cursor *cursor, u32 fg, u32 bg) { u32 reg = (fg << HWC_COLOR_12_2_RGB565_SHIFT) & HWC_COLOR_12_2_RGB565_MASK; @@ -82,8 +82,8 @@ void sm750_hw_cursor_setColor(struct lynx_cursor *cursor, u32 fg, u32 bg) poke32(HWC_COLOR_3, 0xffe0); } -void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop, - const u8 *pcol, const u8 *pmsk) +void sm750_hw_cursor_set_data(struct lynx_cursor *cursor, u16 rop, + const u8 *pcol, const u8 *pmsk) { int i, j, count, pitch, offset; u8 color, mask, opr; @@ -132,8 +132,8 @@ void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop, } } -void sm750_hw_cursor_setData2(struct lynx_cursor *cursor, u16 rop, - const u8 *pcol, const u8 *pmsk) +void sm750_hw_cursor_set_data2(struct lynx_cursor *cursor, u16 rop, + const u8 *pcol, const u8 *pmsk) { int i, j, count, pitch, offset; u8 color, mask; diff --git a/drivers/staging/sm750fb/sm750_cursor.h b/drivers/staging/sm750fb/sm750_cursor.h index b59643dd6..88fa02f63 100644 --- a/drivers/staging/sm750fb/sm750_cursor.h +++ b/drivers/staging/sm750fb/sm750_cursor.h @@ -5,11 +5,11 @@ /* hw_cursor_xxx works for voyager,718 and 750 */ void sm750_hw_cursor_enable(struct lynx_cursor *cursor); void sm750_hw_cursor_disable(struct lynx_cursor *cursor); -void sm750_hw_cursor_setSize(struct lynx_cursor *cursor, int w, int h); -void sm750_hw_cursor_setPos(struct lynx_cursor *cursor, int x, int y); -void sm750_hw_cursor_setColor(struct lynx_cursor *cursor, u32 fg, u32 bg); -void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop, - const u8 *data, const u8 *mask); -void sm750_hw_cursor_setData2(struct lynx_cursor *cursor, u16 rop, +void sm750_hw_cursor_set_size(struct lynx_cursor *cursor, int w, int h); +void sm750_hw_cursor_set_pos(struct lynx_cursor *cursor, int x, int y); +void sm750_hw_cursor_set_color(struct lynx_cursor *cursor, u32 fg, u32 bg); +void sm750_hw_cursor_set_data(struct lynx_cursor *cursor, u16 rop, const u8 *data, const u8 *mask); +void sm750_hw_cursor_set_data2(struct lynx_cursor *cursor, u16 rop, + const u8 *data, const u8 *mask); #endif -- 2.40.0