Date:   Sun, 19 Mar 2023 23:03:57 -0700
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     msizanoen1 <msizanoen@qtmlabs.xyz>
Cc:     hdegoede@redhat.com, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org, pali@kernel.org,
        stable@vger.kernel.org
Subject: Re: [PATCH v3] input: alps: fix compatibility with -funsigned-char
Message-ID: <ZBf3TalDJffrxEPB@google.com>
References: <20230318144206.14309-1-msizanoen@qtmlabs.xyz>
 <20230320045228.182259-1-msizanoen@qtmlabs.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230320045228.182259-1-msizanoen@qtmlabs.xyz>
Precedence: bulk

On Mon, Mar 20, 2023 at 05:52:29AM +0100, msizanoen1 wrote:
> From: msizanoen <msizanoen@qtmlabs.xyz>
> 
> The AlpsPS/2 code previously relied on the assumption that `char` is a
> signed type, which was true on x86 platforms (the only place where this
> driver is used) before kernel 6.2. However, on 6.2 and later, this
> assumption is broken due to the introduction of -funsigned-char as a new
> global compiler flag.
> 
> Fix this by explicitly specifying the signedness of `char` when sign
> extending the values received from the device.
> 
> v2:
> 	Add explicit signedness to more places
> 
> v3:
> 	Use `s8` instead of `signed char`
> 
> Fixes: f3f33c677699 ("Input: alps - Rushmore and v7 resolution support")
> Cc: stable@vger.kernel.org
> Signed-off-by: msizanoen <msizanoen@qtmlabs.xyz>

Applied, thank you.

-- 
Dmitry