Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B11F2C7618A for ; Mon, 20 Mar 2023 06:16:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229792AbjCTGQq (ORCPT ); Mon, 20 Mar 2023 02:16:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229794AbjCTGQk (ORCPT ); Mon, 20 Mar 2023 02:16:40 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D28EA211E5 for ; Sun, 19 Mar 2023 23:16:37 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id f6-20020a17090ac28600b0023b9bf9eb63so11225800pjt.5 for ; Sun, 19 Mar 2023 23:16:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679292997; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Wh6mUjNb9FiKF7I+GjENPLAa8wG+aCWE1nTIMFKFpIE=; b=hAhUR/tLA/6zvpc+6xnsZ8t9YbT+RPN0pMkMXxLzo4+akIiv+I/w20iLX9gtrq2nro TbubBVTj0mvgxdtP9HPzwqpgFrU3AJ3xjozoPFWORo6qqokvNwv9hI6ngre+ViUkcO3t j2U4YGMwf4tAXAY/N2suBjAVYxTreCnIg4Cmp8ExXXDSvWP7fqFObFlegE8OUAL5ybVo qK32USLyjZHsWC0OY1f53+RPYDzbt/vgLb1YTuyyMuSlJE1mv/1AIHCNDjM4IqWXnAMs /BE3oJ3GpR1LB7AoWccKaTTB9W+laGQvM89IA8RRVaHqF/bNhi3gy4P8UBXlSBNKwLe4 0Zmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679292997; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Wh6mUjNb9FiKF7I+GjENPLAa8wG+aCWE1nTIMFKFpIE=; b=MC3N5s7i1valD8yICdSyw4iXCsfMuFchsoJBC6VaJl721+obctuRZKySMc2owrpVWn 30+Ty8X4QhoB7YKxoOri5PH+cfzdpr7BWSVm065+CnCPApgJsmj/Gjt6qq5dOzlJsOeL 9o27HVzY8q+d8aWjBZPsk8C43ov6duqJwrvHUTcilr+k9A9We/ZuNuadCdn12QFpdEvz sHwXWhYexUGPgLunzaK62L8YxZg4YkA4/SNEEaaYrsRsEeMH847YtsiUJIzmpqZgG3GE rGPKZ3Aft9889G09xqHv4xhoWc8qMG5bV/kfwVrzmP0gvQwMNzHHI32z1BsoosZKmplS 2AnQ== X-Gm-Message-State: AO0yUKV9dx2BjSfjT0GmBM7Yy2rB/0H9GGRFWX7rs0QViM5EGgw1q3Os PLdvlQtLloJAdZT4UQuOubtaaQ== X-Google-Smtp-Source: AK7set+k3m3yvjsif3ZiGXOP/Ma69G3WbeFfqonLN8gZaD5K/BL/zbhNeijIFAlMyvpQiUYINPFt2A== X-Received: by 2002:a17:902:e5c9:b0:1a1:cefd:aa1f with SMTP id u9-20020a170902e5c900b001a1cefdaa1fmr3421983plf.52.1679292996971; Sun, 19 Mar 2023 23:16:36 -0700 (PDT) Received: from leoy-yangtze.lan (211-75-219-203.hinet-ip.hinet.net. [211.75.219.203]) by smtp.gmail.com with ESMTPSA id d9-20020a170902854900b0019c61616f82sm5750129plo.230.2023.03.19.23.16.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Mar 2023 23:16:36 -0700 (PDT) From: Leo Yan To: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , James Clark , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Leo Yan Subject: [PATCH 2/2] perf kvm: Delete histograms entries before exiting Date: Mon, 20 Mar 2023 14:16:19 +0800 Message-Id: <20230320061619.29520-3-leo.yan@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230320061619.29520-1-leo.yan@linaro.org> References: <20230320061619.29520-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It's good not to release resources for a program when kernel cleans up memory space, this patch explicitly releases histograms entries with hists__delete_entries(). Signed-off-by: Leo Yan --- tools/perf/builtin-kvm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c index 1e1cb5a9d0a2..fb9dc0dc46f9 100644 --- a/tools/perf/builtin-kvm.c +++ b/tools/perf/builtin-kvm.c @@ -1528,6 +1528,8 @@ static int kvm_events_live_report(struct perf_kvm_stat *kvm) } out: + hists__delete_entries(&kvm_hists.hists); + if (kvm->timerfd >= 0) close(kvm->timerfd); @@ -1690,6 +1692,7 @@ static int kvm_events_report_vcpu(struct perf_kvm_stat *kvm) kvm_display(kvm); exit: + hists__delete_entries(&kvm_hists.hists); return ret; } -- 2.39.2