Message-ID: <c8eaefed-e1fd-e0c1-7e8f-561c20632646@amd.com>
Date:   Mon, 20 Mar 2023 08:40:22 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] fpga: xilinx-pr-decoupler: remove unused
 xlnx_pr_decouple_read function
Content-Language: en-US
To:     Tom Rix <trix@redhat.com>, mdf@kernel.org, hao.wu@intel.com,
        yilun.xu@intel.com, michal.simek@xilinx.com, nathan@kernel.org,
        ndesaulniers@google.com
Cc:     linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
References: <20230317230617.1673923-1-trix@redhat.com>
From:   Michal Simek <michal.simek@amd.com>
In-Reply-To: <20230317230617.1673923-1-trix@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3RhdjZKU3kvcmtXbjRiVHNkRVorZ0FTeXJsOFBGamFISG4wYVZLUDhzY2xh?=
 =?utf-8?B?RUczWU5kS0gyYU43eHkveEQrelFyODdsZ1o1ajdMaHdyRStFY3VBMnFhVUtN?=
 =?utf-8?B?bXplZ3JRSXd5eEx5d2F2M1dDWG11MWVjTzBBRDE3Y0NTWjlPWXBiYkdGWFVq?=
 =?utf-8?B?TWQ3UGI3aGZMdUpyNVFxemFCVGorTUhHQ3VXTUZxV0lhTXpyZEVDdmViU0pl?=
 =?utf-8?B?Uk1DdWw2V0xVNEpyT01MbDhxaHBmL3pDOG9sckxFcjJVNVpINlZjRC81RVFL?=
 =?utf-8?B?dW8vMkxZS3N0UHZONWFJYTRJTEhCaGlKZzZIVWVGUlYxS3BKYTlhTTJudy9Q?=
 =?utf-8?B?SkpLNWZpZURic0dUMFYyY2dVaGI3UUtiQkY1cmttRTRzSnVpMEprZEJ3Z2dI?=
 =?utf-8?B?d25xVlpaWmVPbWVTSlhkUTA4MHJxVG80TGcrbDJLbkxxd1pVc0VtZ0lOcWd4?=
 =?utf-8?B?dTh0MXdndFBHMVVrVGh1QlVDcFgvU3JNZnJBVWFSeFZkVmNSN3l1ZTFQVlJt?=
 =?utf-8?B?MlV4QTVBczF4NTFqSmRFTUlBbmo0S1REWFhORGtsbzRjbHhlMHB0dmZvV0Zh?=
 =?utf-8?B?bXJwL0V2TUtVMnJnTVlVRHhYZjNxdTdSNzk2YVhiTzdBVWxGenY3UjNSVVU3?=
 =?utf-8?B?eDhQcUZjYXYveElRakVoaFNOTWMvdzU5NEtqdmQzYWp0aDdHN3B6Q3J5WnhJ?=
 =?utf-8?B?dGJka2JFTUlGWDlMWEYwbDVnbUZwM2RTV0FFa1NmNktsQXBDVjN5M2hVS3pk?=
 =?utf-8?B?ZWF1djZqdkkybm1hR25tMEtzRkJYNUIzNm93WG12b2lvcW9uMFpEcjFNSkcr?=
 =?utf-8?B?eWlhVXNPM1VYdGQ1Qmh4d2tTeDhJTVFpUDJXekcwbmFhVmxBTm1NRlZYbS9L?=
 =?utf-8?B?NkRYMHFvK0ZnTFMrMHU2V3RPVzB1TVFqdDMrdlR2VWRpY1VyTkFxVEowNTRG?=
 =?utf-8?B?ZmsyU1dkOXpwcnJpek5VZkx1Nm1KdVlXN1JpVE9ZemxKUVY5TkdrQ2o3VWdq?=
 =?utf-8?B?SENFN0lxejNTb3h4TnpJNkxDNjB1SUQxTkJHNjdNb2xKM1QrV2ZFSm43djdG?=
 =?utf-8?B?aU1BK0ZQSHV4b2VKbTdJYlZhRGh3ODBkZU1oZ1BCS1VMS2tqZGk5VWM5emh6?=
 =?utf-8?B?SWVZKys3NFAyV1Q1c0FFN1R2OUZQUWU1M082UjRUakp3RTJGeGNqY2ZGYlAr?=
 =?utf-8?B?enNUWGIwL0VCZk11dkdGOEszK3FSV244RFVOSFB6ZFIyQzNDNG4vWnVnZ0s1?=
 =?utf-8?B?Und2QXhRSWM2RzQwQzFHQ1FtWlNwQkNJZjQ2S0d5a25rd2R6RWJ5NEV1aldj?=
 =?utf-8?B?MExjUk1DUjVsZXY1L3RqZExoc3FBTGVvbk45OG5WZVF4WXNOMjVlQ092VjlL?=
 =?utf-8?B?bllzN1FGQ2hiellXK0JrMEFKVWl6ZXVKdmV4c2VZTDF3STBSUWdiNXcxRGJs?=
 =?utf-8?B?U3M1OFNzT0V2cVB2bFlkaHFtNE5KVE4wMmNXY1JSdW9RMVFKSmo0bmdCVitn?=
 =?utf-8?B?cWlIUGhHL2pXKzE0K2ZTcjJNc2hvWlJvcUtwOUJ0VnpvNDAxNkVtY1FabWpw?=
 =?utf-8?B?NmV0SElJMk1RaU01cWozbkZ6K1p1U3RwY2YrOUVTYWU5NHZDZ1Yxc200cW9l?=
 =?utf-8?B?VjZYS0U5R0lVOUl4akJuMTcxYzUxY1RPUzZmWERoRmNkeVlyNE5FUFBJMHdl?=
 =?utf-8?B?bXFlUW1LZWlXdk4xL3p1amptckpoY2dSSWpsRHF3V29vRDRaT3l3OE8xOGQr?=
 =?utf-8?B?YmxsZkdtay9HS0FUL1hRUUdNSjVZb01HTUNMaU04TzFWcXpma01LSnpTZm5M?=
 =?utf-8?B?TjN0WHBTMU43eStJeWt6Smk2SlZYZUFwVzBXNzYzWnRGcEdzVDQvV0dqaFpa?=
 =?utf-8?B?Zms0ak8zUmZZQ3lyZEpLK0daOW5uTUZTeTJKODNJYzFNS0VWUkptMFFpejQ0?=
 =?utf-8?B?MWQ4UHZyUG0vWCs1U09MRWhxSHpreUNGTm9lUkxVUm85VncrMkQ4b1FIbWtB?=
 =?utf-8?B?TW1nc3hYM3Y5MnY2QVRpVDVlOUhRa2UzaUYvN0RaWGp2RU9ubVFHMVp6VDVt?=
 =?utf-8?B?enhERjBwNTFoZ0VVSjdjaFgxTnd3b1FoVnhUSTNMdTdaUmNrUGtLY1ltTFlP?=
 =?utf-8?Q?zG+jeI6+RfN0kgQTjI5SQoRj2?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b9d9e40e-edb3-4386-be72-08db291666a1
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 07:40:39.1733
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k4r+LmxfDLmx6EXebK0ISAJtsnFd1G4PQId1w7MyEfed56Z5zZ8EQZbwOpkXwE1c
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8217
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/18/23 00:06, Tom Rix wrote:
> CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email.
> 
> 
> clang with W=1 reports
> drivers/fpga/xilinx-pr-decoupler.c:37:19: error: unused function 'xlnx_pr_decouple_read' [-Werror,-Wunused-function]
> static inline u32 xlnx_pr_decouple_read(const struct xlnx_pr_decoupler_data *d,
>                    ^
> This static function is not used, so remove it.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>   drivers/fpga/xilinx-pr-decoupler.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
> index 2d9c491f7be9..b6f18c07c752 100644
> --- a/drivers/fpga/xilinx-pr-decoupler.c
> +++ b/drivers/fpga/xilinx-pr-decoupler.c
> @@ -34,12 +34,6 @@ static inline void xlnx_pr_decoupler_write(struct xlnx_pr_decoupler_data *d,
>          writel(val, d->io_base + offset);
>   }
> 
> -static inline u32 xlnx_pr_decouple_read(const struct xlnx_pr_decoupler_data *d,
> -                                       u32 offset)
> -{
> -       return readl(d->io_base + offset);
> -}
> -
>   static int xlnx_pr_decoupler_enable_set(struct fpga_bridge *bridge, bool enable)
>   {
>          int err;
> --
> 2.27.0
> 

It should be fixed like this instead.

Thanks,
Michal

diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
index 2d9c491f7be9..58508f44cd49 100644
--- a/drivers/fpga/xilinx-pr-decoupler.c
+++ b/drivers/fpga/xilinx-pr-decoupler.c
@@ -69,7 +69,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge 
*bridge)
         if (err)
                 return err;

-       status = readl(priv->io_base);
+       status = xlnx_pr_decouple_read(priv);

         clk_disable(priv->clk);