From:   Jiri Olsa <olsajiri@gmail.com>
Date:   Mon, 20 Mar 2023 09:05:36 +0100
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Jiri Olsa <olsajiri@gmail.com>,
        Florent Revest <revest@chromium.org>,
        linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
        mhiramat@kernel.org, mark.rutland@arm.com, ast@kernel.org,
        daniel@iogearbox.net, kpsingh@kernel.org
Subject: Re: [PATCH 4/7] ftrace: Rename _ftrace_direct_multi APIs to
 _ftrace_direct APIs
Message-ID: <ZBgT0FINOmW7c4pK@krava>
References: <20230316173811.1223508-1-revest@chromium.org>
 <20230316173811.1223508-5-revest@chromium.org>
 <ZBcqWqWyq0uW/wj7@krava>
 <20230319135550.22aaa04b@rorschach.local.home>
 <ZBdTA0gKh2xAk5Ay@krava>
 <20230319204731.6691dedc@rorschach.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230319204731.6691dedc@rorschach.local.home>
Precedence: bulk

On Sun, Mar 19, 2023 at 08:47:31PM -0400, Steven Rostedt wrote:
> On Sun, 19 Mar 2023 19:22:59 +0100
> Jiri Olsa <olsajiri@gmail.com> wrote:
> 
> > > > >  config SAMPLE_FTRACE_DIRECT_MULTI    
> > > > 
> > > > nit, we could perhaps remove this config option as well
> > > > and use SAMPLE_FTRACE_DIRECT_MULTI  
> > > 
> > > Remove SAMPLE_FTRACE_DIRECT_MULTI for SAMPLE_FTRACE_DIRECT_MULTI?
> > >   
> > 
> > sorry typo, I meant SAMPLE_FTRACE_DIRECT
> 
> I believe this was discussed before, and I thought we decided to keep
> them separate. Or perhaps that was at least for testing?
> 
> Anyway, we could merge this in the future, but I don't think that's
> necessary now.

yes, I said it's nit earlier

jirka