Date:   Mon, 20 Mar 2023 10:48:22 +0200
From:   Ido Schimmel <idosch@nvidia.com>
To:     "Hans J. Schultz" <netdev@kapio-technology.com>
Cc:     davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vladimir Oltean <olteanv@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Hauke Mehrtens <hauke@hauke-m.de>,
        Woojung Huh <woojung.huh@microchip.com>,
        "maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER" 
        <UNGLinuxDriver@microchip.com>, Sean Wang <sean.wang@mediatek.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= <clement.leger@bootlin.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Ivan Vecera <ivecera@redhat.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Shuah Khan <shuah@kernel.org>,
        Christian Marangi <ansuelsmth@gmail.com>,
        open list <linux-kernel@vger.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        "open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER" 
        <linux-renesas-soc@vger.kernel.org>,
        "moderated list:ETHERNET BRIDGE" <bridge@lists.linux-foundation.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH v2 net-next 1/6] net: bridge: add dynamic flag to
 switchdev notifier
Message-ID: <ZBgd1mgO36umXqoj@shredder>
References: <20230318141010.513424-1-netdev@kapio-technology.com>
 <20230318141010.513424-2-netdev@kapio-technology.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230318141010.513424-2-netdev@kapio-technology.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VH/TMqqUmsRY4flg7LXktgRE+cOlUFhJ4nMwmDTTnLU8Uen6xXPICWgKv9w/?=
 =?us-ascii?Q?6Mogl6lBtD/xbCJ5KSytMtGznF0hboa3ECigxSveqgtV8wMbRVZjz91T/YD6?=
 =?us-ascii?Q?AxTUEjIUV74ycFxrxagduRjvDoVDee2DdWd4SoOjwdhlq0rFfbmUnlxbDZbu?=
 =?us-ascii?Q?wspEaNnUoxcc30ko33UJuPptZ+RbMTtl1q7ImlULxUiQlwI5tNJ5RwNuuObz?=
 =?us-ascii?Q?cQ+TCGPbr849A9Ge1qmf4GTDj0KuO7g0nfrrfE8Xyaz4jonPLkCcb6jZU8GZ?=
 =?us-ascii?Q?ECTS2dsjs4qGEDS7KgQAkF2PAOegDGLdyZlfHAb59BnP1RhnOtX6kAnGgpDH?=
 =?us-ascii?Q?BhP8DQkw4plu4NYvZczcGPBuoowBF/MbHZf0UysWQybO93CSijAi9ECLHDTQ?=
 =?us-ascii?Q?Jfu4M3Qmo+HXaQe2GJNQAZUGxxsvC4O61xNZVZU0qR+JhaL4m41WQFz4jaRK?=
 =?us-ascii?Q?7eYw9sBNjw4DDq6Z4Aq/NNX5DYXnrC7J8CbMBWNjjcLFePU0V5THsn+ZkZR6?=
 =?us-ascii?Q?sZd6dNlILQTPTk4OReieMZnDY6CAE/ZFKKw8+iMnu3QRfKsZRCTC8gLdfh3e?=
 =?us-ascii?Q?RM7gePMhlE2afwGMxfUhKblUqkXYWxLlTrm7/5GGK0WkOwg0g9eIUT2hE8u1?=
 =?us-ascii?Q?v2DAyqWrO8B3IveYjswS7jGQqm0dDOZ671Ndy56OE+e6KcQgWgaRLZTgF6sV?=
 =?us-ascii?Q?vDWEEWhKYTJI11F9dOa2EDFmrBAcSf9sTnk74CQWp4RpkeSuR7+v/pZFbKor?=
 =?us-ascii?Q?5ILqdt3UfR6z9gWijsmDPZj362/UjHmTuTNpMtPIIVWraVcnW+SKVL5G5fdL?=
 =?us-ascii?Q?Vw6osW0TOe5hORTwRFrDrMqNxpgcTzlNreN4EvEigSKM1XEq0YM/7F/Ie9CT?=
 =?us-ascii?Q?dPrflk/kZRQQ4L1pB+ZVmeQUG3qNxzXYN/TRNdOXYO1YWrpbTuHLzaPWT9bt?=
 =?us-ascii?Q?Q9T8uxI5acGaCoagz5f8CNfm5INbpOUUpqgGHJb1fWb1oLLI/w1gAVKWQN68?=
 =?us-ascii?Q?kNf/9xGRpJ0Sq0XvnltQHdplJBjd9JysLC8beXSfY0M9jF5PKMNqhc5B0oKR?=
 =?us-ascii?Q?mREgcpPcMu21oWCGJWERN4ciQ26Xw/OJ6kykD2mraDXTd4u+qGrx9Bs+lqWs?=
 =?us-ascii?Q?Y79w8bpwkLYvK0fih4aIkP8HJ6b5VvGTzv08W1JRTWDdGXcwnFqIW0j5wNeH?=
 =?us-ascii?Q?m0qoRM+eIDzLTqpuYYc6kplKzsed65prFbUXbA55vcWrReH6H0i6ZRd8TEfT?=
 =?us-ascii?Q?UnMPRIsReoY8SxnD6I9VeftDoEzyKWB/D/STLSDB4SztoFXSr55dc+DbSd6s?=
 =?us-ascii?Q?okepjCGhYiiXuVHtwa4I+E5s9tdIQy+zhcqs1jzAGCu0nS4dj78sWn0pujsz?=
 =?us-ascii?Q?C7wr6oPMHFBQWjlIiwVQ5KGy1STN+raZNCSiTobnrq73U9BDFez7Zz2tjIsg?=
 =?us-ascii?Q?jca2zgTVfBQONbhiRUSAvOM3h6bUet3Wy739VJWju+fwUFvk9SRla/vGBPj2?=
 =?us-ascii?Q?fbXMPINBTNGg/MuE7rBvSfPJaG0YAjab6euda3dClitE7liUyK6lNo/8y2fm?=
 =?us-ascii?Q?fjBI++MhibJ9VCng/sCxy1oQr7hDqummMYU+o+1T?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b4b25594-c0ec-4529-13d2-08db291fdfa1
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 08:48:27.7844
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Qv+pzWbpga5DJ+WUXH0yxIXw94RWNFfP2KkeqfQxUIBTi1advjawOKEQvx9bngo2P9sr4nBMqu23k7Bplp4I2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6350
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Mar 18, 2023 at 03:10:05PM +0100, Hans J. Schultz wrote:
> diff --git a/include/net/switchdev.h b/include/net/switchdev.h
> index ca0312b78294..aaf918d4ba67 100644
> --- a/include/net/switchdev.h
> +++ b/include/net/switchdev.h
> @@ -249,6 +249,7 @@ struct switchdev_notifier_fdb_info {
>  	u8 added_by_user:1,
>  	   is_local:1,
>  	   locked:1,
> +	   is_dyn:1,
>  	   offloaded:1;
>  };
>  
> diff --git a/net/bridge/br_switchdev.c b/net/bridge/br_switchdev.c
> index de18e9c1d7a7..9707d3fdb396 100644
> --- a/net/bridge/br_switchdev.c
> +++ b/net/bridge/br_switchdev.c
> @@ -134,6 +134,7 @@ static void br_switchdev_fdb_populate(struct net_bridge *br,
>  	item->added_by_user = test_bit(BR_FDB_ADDED_BY_USER, &fdb->flags);
>  	item->offloaded = test_bit(BR_FDB_OFFLOADED, &fdb->flags);
>  	item->is_local = test_bit(BR_FDB_LOCAL, &fdb->flags);
> +	item->is_dyn = !test_bit(BR_FDB_STATIC, &fdb->flags);

I was under the impression that the consensus was to rename this to
'is_static' so that it is consistent with other flags.

>  	item->locked = false;
>  	item->info.dev = (!p || item->is_local) ? br->dev : p->dev;
>  	item->info.ctx = ctx;
> -- 
> 2.34.1
>