From:   "Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>
To:     "Zhang, Qiang1" <qiang1.zhang@intel.com>,
        "paulmck@kernel.org" <paulmck@kernel.org>,
        "frederic@kernel.org" <frederic@kernel.org>,
        "joel@joelfernandes.org" <joel@joelfernandes.org>
CC:     "rcu@vger.kernel.org" <rcu@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] rcutorture: Convert schedule_timeout_uninterruptible()
 to mdelay() in rcu_torture_stall()
Thread-Topic: [PATCH v2] rcutorture: Convert
 schedule_timeout_uninterruptible() to mdelay() in rcu_torture_stall()
Thread-Index: AQHZWtsElwxz/KN2NEOd8ANQA4i0X68DUz9g
Date:   Mon, 20 Mar 2023 08:48:35 +0000
Message-ID: <IA1PR11MB6171C51E1DB7E1575D70878089809@IA1PR11MB6171.namprd11.prod.outlook.com>
References: <20230320032422.4010801-1-qiang1.zhang@intel.com>
In-Reply-To: <20230320032422.4010801-1-qiang1.zhang@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ilSsM7AN8Vf9kq/twpH7GCwFRJomxQlumznfNdOz3u4fxruqSnroNg5/OfNn?=
 =?us-ascii?Q?KsCdzhvd0bI5DsSjo8t8CNzMjHka5O8j4Vj0SzcttjchXldJBMWSuqqcGaZk?=
 =?us-ascii?Q?MUutmG6NjKoKl0Z0NjKBwJ2FlZ8Xr8aSFqUYtjWRMZM5RRsa27LJV6X3OKpS?=
 =?us-ascii?Q?IyAN9YHdP54sGQxfiCDBXLNlcFbCxzcKlhnTVOOx23JGfoja7dlRGaZUmUbX?=
 =?us-ascii?Q?5Fp9uGbY51WGFRvAK48QbfWl7+OWL3/TwQqIpC3kgfEFFdfuz35bbHLowsKA?=
 =?us-ascii?Q?lQ+6hqcEtmaWgWkF7iL0WBAP789ujVH6lo/fBTkG3GQCnOMO7GpFYkJDidSM?=
 =?us-ascii?Q?84yQk12qG02WE/NH3rTB9vHbD63cgOaFNxPS1swA9z5/sEEnJdzmamOnMg7K?=
 =?us-ascii?Q?hGNamvMO8lH/jsNH/nrDKCnhDYnp6NgPONh4YB/o1jxJjDQclNw49jwl7Bkk?=
 =?us-ascii?Q?846iHHrYZXzAzFw/Yc9xSQzvgC/dvGlQImo0gjSjos7J83ZJM7eOdf/ds1ml?=
 =?us-ascii?Q?O8N+PZcdgX+gHD3WN/01Qg2fQjZ/G9c1cf0o5aOu9BSZxBAP7tLLy0zcxCzd?=
 =?us-ascii?Q?58zVpo58DVctzNs4vtHWRFH3UPxv094gk5+nT6JJrLZSsRz2p8UX3ISAs/4j?=
 =?us-ascii?Q?FZX3leiBTvhED4cF9R+K6wcbvOh9CE1BE1w88WbuLtYHhUD4MDVlRlmubd4y?=
 =?us-ascii?Q?9nekRmqdLas9iWMlKeehJGYkWTCf/qrFNjEK3eWquBhGEornoCGAfIcnjIWb?=
 =?us-ascii?Q?ZZmx/u8ITHXhrKYk8cA8BSf0NY/GVcNlWwsQWIrTuL6qw3vKbn/dA+EUC987?=
 =?us-ascii?Q?2bhEIjK13IdJBuRrr/agcNX9YvNag5GZ50gbSBnF6bdxVUPkJ9tvZQB+e0Df?=
 =?us-ascii?Q?nRvWW+NOejMTprZbuWkTN74q2HjBAHA3EFsu0tBusjDYGniszikLH3dRA52z?=
 =?us-ascii?Q?vVUznyY0jfy2uRdkBnDWTSm3GcG+JWYpwzIkogcOWm4egHzB4/tAJQEHfoqL?=
 =?us-ascii?Q?G8bc0zGnkfAGSt/rsJ6sumgXCYshPOGl2vvz3ibhEBpnDVHF/dZIF0HZi/Bt?=
 =?us-ascii?Q?8vV1pZ0d1fchmqy/X7hcc3Yky5JumzH6lAIq2R1cEY3r6DDY9KLhhjia590l?=
 =?us-ascii?Q?vzAT1k2zluJsyo7mN5K+cMezhTBVRRqTeRhgLviFGNhlLGFLTnBWd2G7WXAr?=
 =?us-ascii?Q?1z3/Xj6RbF/nJXrQ1TmOAIDQVKiQVvK/rP8EobWp/EADWwe6ReHUkhFW82Gw?=
 =?us-ascii?Q?JV834sE1QDprWnpsaTh4kr0S/m3GGbHMBeS8AOjdCiw5UuOTNOQoyMOTCC8J?=
 =?us-ascii?Q?LRssuUYKPDCfIiDJOHxHnNs7/OsUYLv8qnz7iGJ2lpwxhYwck8V2BZFuNnAM?=
 =?us-ascii?Q?FSaYDBfUUH/49kDBKzP8WBMX5TREINKU29XvnVKqG7iOlZYZF4oEjCHzJTiB?=
 =?us-ascii?Q?4he6/gVDyC7EtV0V6gyiIE/gztKOKEGvh+fjm6Pppjr84doIyuQLzyoywqU9?=
 =?us-ascii?Q?pglga0IjDTlAwevAOsp+clkLTKkUwCmLUi/Up8q8rI6gf2KLyhfla2QbaboH?=
 =?us-ascii?Q?YAvHs+gnuzuAjq43nlT2WjUSrfAPk0BGM+i1YpX9?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6171.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 042dafab-373b-474e-5a60-08db291fe44b
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Mar 2023 08:48:35.3300
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hIUqB0DBF+2Att3u0DCei9dbgu66jwpjDGXcJKGgSZtr4y26RJnG0myOwqZgZb0mrrEPxg3mdbPd4mC17ve4Sw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6099
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Qiang,

> From: Zqiang <qiang1.zhang@intel.com>
> Sent: Monday, March 20, 2023 11:24 AM
> To: paulmck@kernel.org; frederic@kernel.org; joel@joelfernandes.org
> Cc: rcu@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH v2] rcutorture: Convert schedule_timeout_uninterruptible(=
)
> to mdelay() in rcu_torture_stall()
>=20
> For kernels built with enable PREEMPT_NONE and

s/enable/enabling/

> CONFIG_DEBUG_ATOMIC_SLEEP, running the RCU stall tests.

s/running/run

>=20
> runqemu kvm slirp nographic qemuparams=3D"-m 1024 -smp 4"
> bootparams=3D"nokaslr console=3DttyS0 rcutorture.stall_cpu=3D30
> rcutorture.stall_no_softlockup=3D1 rcutorture.stall_cpu_irqsoff=3D1
> rcutorture.stall_cpu_block=3D1" -d
>=20
> [   10.841071] rcu-torture: rcu_torture_stall begin CPU stall
> [   10.841073] rcu_torture_stall start on CPU 3.
> [   10.841077] BUG: scheduling while atomic: rcu_torture_sta/66/0x0000000
> ....
> [   10.841108] Call Trace:
> [   10.841110]  <TASK>
> [   10.841112]  dump_stack_lvl+0x64/0xb0
> [   10.841118]  dump_stack+0x10/0x20
> [   10.841121]  __schedule_bug+0x8b/0xb0
> [   10.841126]  __schedule+0x2172/0x2940
> [   10.841157]  schedule+0x9b/0x150
> [   10.841160]  schedule_timeout+0x2e8/0x4f0
> [   10.841192]  schedule_timeout_uninterruptible+0x47/0x50
> [   10.841195]  rcu_torture_stall+0x2e8/0x300
> [   10.841199]  kthread+0x175/0x1a0
> [   10.841206]  ret_from_fork+0x2c/0x50
>=20
> The above calltrace occurs in the local_irq_disable/enable() critical sec=
tion
> call schedule_timeout(), and invoke schedule_timeout() also implies a
> quiescent state, of course it also fails to trigger RCU stall, this commi=
t
> therefore use mdelay() instead of schedule_timeout() to trigger RCU stall=
.

Tweak the commit description above to fix some grammar errors:

    The above call trace occurred in the local_irq_disable/enable() critica=
l section
    when calling schedule_timeout() from rcu_torture_stall(). Invoking sche=
dule_timeout()=20
    also implies a quiescent state, of course, it also fails to trigger RCU=
 stall. This commit,=20
    therefore, uses mdelay() instead of schedule_timeout() to trigger the R=
CU stall.

> Suggested-by: Joel Fernandes <joel@joelfernandes.org>
> Signed-off-by: Zqiang <qiang1.zhang@intel.com>

I didn't reproduce the call trace after applying your patch.
So, with the above minor fixes, then

    Tested-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>

Thanks
-Qiuxu

> ---
>  kernel/rcu/rcutorture.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c index
> d06c2da04c34..a08a72bef5f1 100644
> --- a/kernel/rcu/rcutorture.c
> +++ b/kernel/rcu/rcutorture.c
> @@ -2472,7 +2472,7 @@ static int rcu_torture_stall(void *args)  #ifdef
> CONFIG_PREEMPTION
>  				preempt_schedule();
>  #else
> -				schedule_timeout_uninterruptible(HZ);
> +				mdelay(jiffies_to_msecs(HZ));
>  #endif
>  			} else if (stall_no_softlockup) {
>  				touch_softlockup_watchdog();
> --
> 2.25.1