Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27F1BC7618A for ; Mon, 20 Mar 2023 09:37:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230184AbjCTJhq (ORCPT ); Mon, 20 Mar 2023 05:37:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231388AbjCTJhF (ORCPT ); Mon, 20 Mar 2023 05:37:05 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EE391E9F3; Mon, 20 Mar 2023 02:36:58 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id EB726660304E; Mon, 20 Mar 2023 09:36:55 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1679305016; bh=Uo+9AluIFHmPV3bJSGzE3eP0NjmNNQjHzY/90Htnz0U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=mTXafobedk+s9r3j4lM/QrT5+exwAA+jAg5UooCsd1nu3MU3dRYE0pzqgfJDfarOi pRuDPUTnkT/bpQP9TWNrWKrrmzfgDbqaTofFggCsya6Cz0U6q2aP9HyWLelcSVvOX3 3TbKxlwgOYvHsD23rudl02BlL90W9Yc+i9+6kId61Zkdyf/nJ/b1lJKFc5Pfn+yN+P EsDCYFwcmVwYNb16VWQf37oOJBegUvkhNmLGHrnEXyVGcO1xDco1gBqnmsmcGsZs7e 7MnWBnvu/mEsyX2eTjjYZ4xdlERGxhqCU8WZOQj0pBq7Euz2dgiFcFGesYS++1jX0p QxC2TmuGh6bfA== Message-ID: Date: Mon, 20 Mar 2023 10:36:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v5,2/2] media: mediatek: vcodec: Force capture queue format to MM21 Content-Language: en-US To: Yunfei Dong , Chen-Yu Tsai , Nicolas Dufresne , Hans Verkuil , Benjamin Gaignard , =?UTF-8?Q?N=c3=adcolas_F_=2e_R_=2e_A_=2e_Prado?= Cc: Matthias Brugger , Hsin-Yi Wang , Fritz Koenig , Daniel Vetter , Steve Cho , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20230318035651.27454-1-yunfei.dong@mediatek.com> <20230318035651.27454-2-yunfei.dong@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20230318035651.27454-2-yunfei.dong@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 18/03/23 04:56, Yunfei Dong ha scritto: > While the decoder can produce frames in both MM21 and MT21C formats, only MM21 > is currently supported by userspace tools (like gstreamer and libyuv). In order > to ensure userspace keeps working after the SCP firmware is updated to support > both MM21 and MT21C formats, force the MM21 format for the capture queue. > > This is meant as a stopgap solution while dynamic format switching between > MM21 and MT21C isn't implemented in the driver. > > Fixes: 7501edef6b1f ("media: mediatek: vcodec: Different codec using different capture format") > Signed-off-by: Yunfei Dong > Reviewed-by: Nicolas F. R. A. Prado > Tested-by: Nicolas F. R. A. Prado Reviewed-by: AngeloGioacchino Del Regno