Message-ID: <3c9e2fd0-fec8-2aa7-0e68-601b13cc86dd@gmail.com>
Date:   Mon, 20 Mar 2023 12:14:54 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] staging: greybus: use inline function for macros
To:     Julia Lawall <julia.lawall@inria.fr>
Cc:     gregkh@linuxfoundation.org, outreachy@lists.linux.dev,
        johan@kernel.org, elder@kernel.org, linux-kernel@vger.kernel.org,
        linux-staging@lists.linux.dev
References: <20230319201324.253874-1-eng.mennamahmoud.mm@gmail.com>
 <alpine.DEB.2.22.394.2303192121170.2867@hadrien>
 <0f02a3ff-801b-1e1f-5c03-009a05708709@gmail.com>
 <alpine.DEB.2.22.394.2303192151330.2867@hadrien>
 <402ffcbe-bb29-7035-68f4-2741532a6d67@gmail.com>
 <alpine.DEB.2.22.394.2303192225590.2867@hadrien>
 <649afe06-e069-e046-21ec-0d86243a4bfa@gmail.com>
 <alpine.DEB.2.22.394.2303192303130.2867@hadrien>
 <8e9724a0-226d-eb81-69c3-d59889e37e1f@gmail.com>
 <alpine.DEB.2.22.394.2303200659280.2940@hadrien>
Content-Language: en-US
From:   Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
In-Reply-To: <alpine.DEB.2.22.394.2303200659280.2940@hadrien>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On ٢٠‏/٣‏/٢٠٢٣ ٠٨:٠٠, Julia Lawall wrote:
>>>> and version that I have submitted, should I do anything about it as you
>>>> said
>>>> it is wrong solution?
>>> My concern was the blank line after each of the structure definitions,
>>> which is not in Greg's tree, so he can't apply the patch.  Other than
>>> that, if the code compiles it is at least going in the right direction.
>>>
>>> Please fix the newlines issue, and then send the patch again.
>>>
>>> julia
>>
>> Okay I will fix it, but will send it as a new patch not v3, right?
> Why as a new patch?  The change is the same as in v2, and sending v3 makes
> it clear that v2 should be ignored.
>
> julia


Okay, thanks.

Menna