From:   Peng Fan <peng.fan@nxp.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        Xu Yang <xu.yang_2@nxp.com>
CC:     "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>, Jun Li <jun.li@nxp.com>
Subject: RE: [PATCH linux-next] dt-bindings: usb: snps,dwc3: correct i.MX8MQ
 support
Thread-Topic: [PATCH linux-next] dt-bindings: usb: snps,dwc3: correct i.MX8MQ
 support
Thread-Index: AQHZWs/6lJ7epjxGPkeRDAwzZgO0X68DPJiAgABD8SCAAAsMAIAAASdQ
Date:   Mon, 20 Mar 2023 11:44:25 +0000
Message-ID: <DU0PR04MB9417FBDEC58F46C069A359B888809@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20230320020714.955800-1-peng.fan@oss.nxp.com>
 <8efe78d3-ff50-1970-3a90-28bab4992bad@linaro.org>
 <DU0PR04MB9417D88E67200F4A74C5CF4888809@DU0PR04MB9417.eurprd04.prod.outlook.com>
 <355d5dde-cc86-018c-85d5-51cf59bdb36a@linaro.org>
In-Reply-To: <355d5dde-cc86-018c-85d5-51cf59bdb36a@linaro.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+5hbwALPO3mR+pu4JqFqQIRmixYXg+/9zHh8MB6jIZbUr6ytjHu0BLKBArty?=
 =?us-ascii?Q?0GIxVE/2eIxNcN9zN02oE2xn21dN/Td2dq/+xTxaMrzx6jIBit3b1no7Zzur?=
 =?us-ascii?Q?+GInI1vtSqAjIQ6Tg/G2EviTGpWp5HrsjiQ3cr8B0qR8d8attr+FAiZ91E86?=
 =?us-ascii?Q?7AG+SXEswGXv7HAprAzt0fxB902cZsb7d4KaxQeiYd7y936vKOaekrYxwRmi?=
 =?us-ascii?Q?n1k4MsW2vKrf0r+KMMpt2UjAPiPNfy/7lWtJ9kWSn3s0gXZOk8XdiYjuPvUn?=
 =?us-ascii?Q?L4hymzTBH7wFgSi9BgA0ap5EbqM0PVrE5Lr68TBm1YECG7/phwDTKb8H3OoN?=
 =?us-ascii?Q?pgGSWYMbEhuzJkGQ7nnr8BAOAvVyt25UF+9JabsGhUTm4/7hRSNQlTabqctx?=
 =?us-ascii?Q?L7NTFT4BGwlYRV1G+8i1SvccUfsn6V4gJHckuTDcfmRkdFPQZdog49pOrrnm?=
 =?us-ascii?Q?UxINbqVozNMxQIP1SqIUBayu3+Zk2J7lOtgubvBuebWX0akfgph7n1dBAD4X?=
 =?us-ascii?Q?QxYuV5CnbmQpQE0RIadD3al49RdgYIv2tjHGxtleNM88dwtl6mtKB+5UShyN?=
 =?us-ascii?Q?g0ko+rV8975nXyi9x6aQQMtbSz2k8W2ktsEGnT25eWnk3zyrVULP7/NYVJts?=
 =?us-ascii?Q?VadJr35ABdX+hLifPcQLhoPgLn19i3k1LDaPcFUplG4XrAkav1PXQ36c4iCZ?=
 =?us-ascii?Q?msKalBdid/kj6hFvtyD4WVpLyy1i+4JFYgQ9fTjhy8qro0fshJb+yxwSEJqw?=
 =?us-ascii?Q?qHR2GXOq3rpFu21rklq0P9IzYTDbnROYrgISqi8q3xJ/JyhOosH8rSL5c2dq?=
 =?us-ascii?Q?ov9ZaQNATGL89tgxVYEr/6/ArXMbrkiVyfKsQ+0lQZmUfrHNPAQqZic38xkF?=
 =?us-ascii?Q?9FGzSOVz0YmkydUc6KSOV0z7ZhoCzwjIZMztd6GE8KiGVDcWTZj81vyXKyXU?=
 =?us-ascii?Q?QqxqEPifqvgOoUjvlSvjTEVIRk0Q1fFCCS/1uIJGGWjP+XMZe6yXaJDwZG8Q?=
 =?us-ascii?Q?/SgnsEenqTuYX2yrUau6HvjCTBRkYhXI+Twvx71GoGF2IfreA0clAt9kiquB?=
 =?us-ascii?Q?Elnsi51XUFKsrI+RCKl8Omx9tu70wBK1SqE2X0YCqfmIH/OMRpjrIsykGVt3?=
 =?us-ascii?Q?SmmnnipyFWr1l47nFlpGawGkT7r/lCZO7TnppMjeQ3PMW5UJdF5lgxd2hIbM?=
 =?us-ascii?Q?ZJ0D3c+BsNfcPNaqlP4RhyGddXf63Ep844/AEU5pO2MVbZhZvGC1fyIstzRZ?=
 =?us-ascii?Q?x/G0d1sBezDEYwv7ULkwl18uFyWixdbs8+6M2zyk6adc7Sd8XNrfdjKxEVNV?=
 =?us-ascii?Q?m7rqELs0CfvTX9rSa5VQUKE6ZCLenFkQxRugLwhVg3ILHuMF0S2EsC7hjQAA?=
 =?us-ascii?Q?9zHwNp0ZVinfj2ZRkTmGujlHVYKaBkeotrgs/ClOM+oyY4hCM9z2EAb8nd9W?=
 =?us-ascii?Q?zQBQGY/QTqlrUJLNzMLllUHiD2B7WRB1E4ze4dnHhCMkxHNggEkj8ReLCtN5?=
 =?us-ascii?Q?C8CEE7CBAe2HNEqy4pcqwvgoLSAPzzCmihvkUx8GAsC8O2yr6Hse0tTshnk/?=
 =?us-ascii?Q?EKAxv3bdYlBGNiAtly4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bbf09f5e-70db-475a-5042-08db293874d7
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Mar 2023 11:44:25.8076
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0xcAvZ1tneA+MdxKbWljMQJSO8Cena1+PfMwQwnpOHc+qXb1tJwy6ZRJ3/WrJ9+gKoGxjukqhGlCkzS0L5IgIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7535
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: Re: [PATCH linux-next] dt-bindings: usb: snps,dwc3: correct
> i.MX8MQ support
>=20
> On 20/03/2023 12:02, Peng Fan wrote:
> >> Subject: Re: [PATCH linux-next] dt-bindings: usb: snps,dwc3: correct
> >> i.MX8MQ support
> >>
> >> On 20/03/2023 03:07, Peng Fan (OSS) wrote:
> >>> From: Peng Fan <peng.fan@nxp.com>
> >>>
> >>> The previous i.MX8MQ support breaks rockchip,dwc3 support, so use
> >>> select to restrict i.MX8MQ support and avoid break others.
> >>>
> >>> Fixes: 3754c41c7686 ("dt-bindings: usb: snps,dwc3: support i.MX8MQ")
> >>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> >>> ---
> >>>  .../devicetree/bindings/usb/snps,dwc3.yaml    | 21 ++++++++++++-----=
--
> >>>  1 file changed, 14 insertions(+), 7 deletions(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> >>> b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> >>> index 16c7d06c9172..6347a6769ee3 100644
> >>> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> >>> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> >>> @@ -28,15 +28,22 @@ allOf:
> >>>      else:
> >>>        $ref: usb-xhci.yaml#
> >>>
> >>> +select:
> >>> +  properties:
> >>> +    compatible:
> >>> +      contains:
> >>> +        enum:
> >>> +          - fsl,imx8mq-dwc3
> >>
> >> And what about all snps,dwc3 devices there (without specific compatibl=
e)?
> >> Previously they were selected and now they are not... so you just
> >> disabled schema for all of them.
> > [Peng Fan]
> >
> > I am not sure how to address:
> >
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flore
> > .kernel.org%2Fall%2FCAL_Jsq%2BnrqTX5ND3%3D%2BkFUmStx-
> %2Bb%3DqpE_WsL_Le
> > -YX8c285-
> 5A%40mail.gmail.com%2F&data=3D05%7C01%7Cpeng.fan%40nxp.com%7C1e
> >
> 67df79692243f058fa08db2937befd%7C686ea1d3bc2b4c6fa92cd99c5c30163
> 5%7C0%
> >
> 7C0%7C638149091586933618%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC
> 4wLjAwMDAiL
> >
> CJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&s
> data=3Dr1
> > fesB1c%2B3YxohCGM36xySFucVU25WVYIMlpgGkdoWk%3D&reserved=3D0
> >
> > Rob suggested use select, but I am not sure how to use it here. Use an
> > extra yaml file with select or else.
> >
> >>
> >>> +  required:
> >>> +    - compatible
> >>> +
> >>>  properties:
> >>>    compatible:
> >>> -    oneOf:
> >>> -      - items:
> >>> -          - const: fsl,imx8mq-dwc3
> >>
> >> I don't understand why you remove your compatible.
> > [Peng Fan]
> >
> > My last change drops 'contains' by mistake, and breaks
>=20
> This I understand.
>=20
> > rockchip,dwc3, so just bring back the original content
>=20
> This is not a reason to make your compatible undocumented. You basically
> revert your patch. It does not make any sense to me.
[Peng Fan]=20

ok, let me think more. Honestly not have good idea (:
If you have any guidance, that would be helpful.

Thanks,
Peng.

>=20
>=20
> Best regards,
> Krzysztof