To:     Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
Cc:     Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v3 0/3] blk-integrity: drop integrity_kobj from gendisk
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1v8ivtzrn.fsf@ca-mkp.ca.oracle.com>
References: <20230309-kobj_release-gendisk_integrity-v3-0-ceccb4493c46@weissschuh.net>
Date:   Mon, 20 Mar 2023 07:56:58 -0400
In-Reply-To: <20230309-kobj_release-gendisk_integrity-v3-0-ceccb4493c46@weissschuh.net>
        ("Thomas =?utf-8?Q?Wei=C3=9Fschuh=22's?= message of "Sat, 18 Mar 2023
 17:36:22 +0000")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+Gf2uPIrUZl18EYoSvpOSPgtj0uvL6wgrA0N6eHPvAzfVADaao0YiBEl9uKF?=
 =?us-ascii?Q?+e7WQqF0ssikhBilRHNJcBo5H5QhYPDpZztepngyKEOZ8l6iLLPikU0g3+Kw?=
 =?us-ascii?Q?zd8H4pnKX9Dd4zylUfkV2vFT5u/DO/fDu62yhmisLtOeydASJr/fDfcVMiJX?=
 =?us-ascii?Q?BfKtjlAvpajfY+PxzQnuv3IH/oQY2/92P2Vqngy2E/M3sdRdgs+8/WxRcnK2?=
 =?us-ascii?Q?sYPlo3hcABnPUuXiant26LZo7HBhFmaBJ8/kxbZ3zHJqvw8JzR6NoYSlKAmK?=
 =?us-ascii?Q?wUA8fYTM4InL47rqUgZ0tX/5ba296t7XkBvF8OSNeMK1MeylolJyVlvmVQU8?=
 =?us-ascii?Q?tjQUvmBp+dA2UepodESyPhmjXC4CXtfN5K2Zd2a4U6Ipt4YVrflZJGsKN6gH?=
 =?us-ascii?Q?9zVCS7idmyAUHtk85tChFawvZbKG/a/CMJV8lmT2zNT25nkHGP3Zr2dwwRu1?=
 =?us-ascii?Q?qdTreRJWe846myfaEpNxsJyqdvJA2I7suQg1D5tbT+YkkBZVQqkm7dq9kjtZ?=
 =?us-ascii?Q?rbCfEub9tXXO5A/oxrMKnKAMemNFr9VrfqHjPAFQEirSP584Hct6xGSODCeb?=
 =?us-ascii?Q?UL+bdZ6QbXR1mloITJz63MzianK+lAobXOB0wXTdbhQcOHmVRSh6G8P7mAO1?=
 =?us-ascii?Q?GYP2YMUmOibSAGWSLUOtjs8r2GCFMbLEFUe+bJ6Ggjhl8rWOXYClk2UHncDx?=
 =?us-ascii?Q?ths/8GQagKyl4h72zkAf+DfNGuJPccIoMNWFZZ1Xn/gqrhQPcUapgLsa/wNI?=
 =?us-ascii?Q?uCCxXIM8yEc5Je0gffNezsjuqtcUlN8b6FeXh6s15GGgf5eWyxYNJNL4RrFI?=
 =?us-ascii?Q?qVMSRctQAyt4J4UAThD/e6ji/zWFg1nniUQ+C03jpk2Zu5ag+bjNp1EN+JCY?=
 =?us-ascii?Q?c3JnDWyk7CnYvjCgl+Zb7qY7q7yXdwUq1I9RkU1XCh4Gh1NDCZwatjiz4Eqz?=
 =?us-ascii?Q?TJAu97+dEEF6oolni4OKWk4pgRJG3T76l7OGTQBQpKq01wHbldX55p0mVejH?=
 =?us-ascii?Q?wdVADFjncxbsOF8MAZLYJg+Qp4USLf2juZjs3jJANRN45goBqy3igwxcOWLL?=
 =?us-ascii?Q?PunIiWOJhKdw1HH/GvIzXyPCzehzRshoIby4Mq7e8YQxC1CIsnhuexYE8S6u?=
 =?us-ascii?Q?ZxuhucwCZ1M/i0cbI/JHUxZHLvir1aw8ETYoU+OrqdLw6oD955wFij90qtB9?=
 =?us-ascii?Q?JYJ3KZ3gBNC1fBH+BY8p93K9aVKk1wCIHgnLV00uRiMu4UevKZ4+BSmFlYBe?=
 =?us-ascii?Q?HtHfrXGEomlviJsA1+Y3IUQyiLiMLApvlJBv9Kqgy/VkvWW9N81xX7oh6K6t?=
 =?us-ascii?Q?DLPaE+3Wdq7JqPaxAe7ej7zTEhK9Q+i892ng+FK7Um7xvZNlkhahbDvBfyvf?=
 =?us-ascii?Q?2ge2nViJRO/4nkgwl0yKVwLwl6dRh6weS2Vk480UVp9s+m89Aq2oM6YraYwn?=
 =?us-ascii?Q?S/zLr0fk4qXrjcfQ/CSsCdmTb/XIVWGxvoV1rvgpkMMtJ4nXgqSkQZKdUzR0?=
 =?us-ascii?Q?X/twor2WR4cJ4Ff6ZSLcbEiM5bQaaSR9eBzw4x4Ci34WUoee2E61NsSQj6Gn?=
 =?us-ascii?Q?yO/dDhkqeLRxZo/SthJKGl2XTRFj6z5k2shYu4K+3MQLvjsDHSSIr3XU9b9W?=
 =?us-ascii?Q?GQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: sciFM95GRYoVBGlOV5KFccoJPu2NewhFgj7rddgvBJ3KkbHkkXkfzaRZxo19eCuujh3Ci2ZtCPoMPdF+ocp53qpwdusRxIJYaVWgLDy9jxfRYFaQ3ix5RJE8iowzUZ+fCawFgyV+PiEJXkFiXMQZCo6hbB3+N3zjNJmtntiSEMt/nrBKVwfvpsaLLzEyycInJcjLRbSiWfv7QvScvhmpo87LBwQ+LWgGz0p+mKd4NF3MvXYkJsM/0S4mJSa9yluOilw6762MNw5sV37fiQKmxBwW5ce2nZxt/YicbC+LM/ItBHxA+X/n7iIBo9bfniaoNXbgDzwEsLHbs77GortBYATb4OdXjbXnrN91NP+xvBe+MhSSZbskjzhULLKBbMlSSvI3NRdKdKaSEB6FN1HFNp6KPr4MajF3r/9riYjiIpp5iNHLWKQE2TuC/eEa0DArZ8UAHZZ5lOqYu4ap4+Vy8eKFtCil2hlzR+tdov9k8GLYV4WmuO+qIKQJfiK1F95EOpQPfL6HzQef6uAXHGEqcH1AL9xbtK3fH2lzYrxy67p2FEaqTOMsbjs/+QwnXiixVg72PlQZgQE/JxmysU6VzgYAFmWGU/IS9i7eJw0jIsO6+zgWBvppbQYD3I49ajKHGtU3M17W0edG9uVmeKCeV5+U1LOZ17Tnp3Pnar08t3p+/LOkOEy2nxgf7TUa+xvD709M8TroZb7Ylvx+UWCR6RJe/VXRCs630nGWkcJTQqSsxPlhNpVHgI3zLgmy3UtvnMS0Vn/bS5Y3WTo4qGN7hDNUnRChdrz4enerOggBqcFcl3+AzWRJuEl7EWngLRg1jr+OntMTKqeuY8GwVTCaS1piRINv2md8zPoC2uOYhu+4fRZGRBMx0PUA80Fk499IB63j9MNFPsis8KnM35bO3dUDlNM4pyywDFRYlaHCp5s=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48e2451c-1a36-4e29-4276-08db293a38b5
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 11:57:04.2610
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ll2rTmU1S62n+f2vsH9VcA6a1QG7hBG5ag1/Zzu1/BpXLtoEZF70ru23USfPKVFZbrYsc9gP3JRx064QEJuDJTHlc3k2NyeXddDrZdiNSWw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5313
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-20_08,2023-03-20_02,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 malwarescore=0
 phishscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002
 definitions=main-2303200102
X-Proofpoint-ORIG-GUID: 0d7R76NWwy9YZoSYO4w6L1OmJXigStiQ
X-Proofpoint-GUID: 0d7R76NWwy9YZoSYO4w6L1OmJXigStiQ
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Thomas,

> The embedded member integrity_kobj member of struct gendisk violates
> the assumption of the driver core that only one struct kobject should
> be embedded into another object and then manages its lifetime.
>
> As the integrity_kobj is only used to hold a few sysfs attributes it
> can be replaced by direct device_attributes and removed.

Looks good to me and passed a quick test on a couple of systems. Thanks
for cleaning this up!

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering