Date:   Mon, 20 Mar 2023 13:58:31 +0200
From:   Heikki Krogerus <heikki.krogerus@linux.intel.com>
To:     Tom Rix <trix@redhat.com>
Cc:     gregkh@linuxfoundation.org, nathan@kernel.org,
        ndesaulniers@google.com, sven@svenpeter.dev, agx@sigxcpu.org,
        Jonathan.Cameron@huawei.com, jun.nie@linaro.org,
        u.kleine-koenig@pengutronix.de, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] usb: typec: tipd: remove unused tps6598x_write16,32
 functions
Message-ID: <ZBhKZ3gVjLnblezP@kuha.fi.intel.com>
References: <20230319133732.1702841-1-trix@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230319133732.1702841-1-trix@redhat.com>
Precedence: bulk

On Sun, Mar 19, 2023 at 09:37:32AM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/usb/typec/tipd/core.c:180:19: error: unused function
>   'tps6598x_write16' [-Werror,-Wunused-function]
> static inline int tps6598x_write16(struct tps6598x *tps, u8 reg, u16 val)
>                   ^
> drivers/usb/typec/tipd/core.c:185:19: error: unused function
>   'tps6598x_write32' [-Werror,-Wunused-function]
> static inline int tps6598x_write32(struct tps6598x *tps, u8 reg, u32 val)
>                   ^
> These static functions are not used, so remove them.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/tipd/core.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> index 485b90c13078..af6ecb54b52c 100644
> --- a/drivers/usb/typec/tipd/core.c
> +++ b/drivers/usb/typec/tipd/core.c
> @@ -177,16 +177,6 @@ static inline int tps6598x_read64(struct tps6598x *tps, u8 reg, u64 *val)
>  	return tps6598x_block_read(tps, reg, val, sizeof(u64));
>  }
>  
> -static inline int tps6598x_write16(struct tps6598x *tps, u8 reg, u16 val)
> -{
> -	return tps6598x_block_write(tps, reg, &val, sizeof(u16));
> -}
> -
> -static inline int tps6598x_write32(struct tps6598x *tps, u8 reg, u32 val)
> -{
> -	return tps6598x_block_write(tps, reg, &val, sizeof(u32));
> -}
> -
>  static inline int tps6598x_write64(struct tps6598x *tps, u8 reg, u64 val)
>  {
>  	return tps6598x_block_write(tps, reg, &val, sizeof(u64));

thanks,

-- 
heikki