Date:   Mon, 20 Mar 2023 13:59:14 +0200
From:   Heikki Krogerus <heikki.krogerus@linux.intel.com>
To:     Tom Rix <trix@redhat.com>
Cc:     linux@roeck-us.net, gregkh@linuxfoundation.org,
        matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
        nathan@kernel.org, ndesaulniers@google.com,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, llvm@lists.linux.dev
Subject: Re: [PATCH] usb: typec: tcpci_mt6360: remove unused
 mt6360_tcpc_read16 function
Message-ID: <ZBhKkqqoSkmBueaO@kuha.fi.intel.com>
References: <20230319141053.1703937-1-trix@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230319141053.1703937-1-trix@redhat.com>
Precedence: bulk

On Sun, Mar 19, 2023 at 10:10:53AM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/usb/typec/tcpm/tcpci_mt6360.c:46:19: error: unused function
>   'mt6360_tcpc_read16' [-Werror,-Wunused-function]
> static inline int mt6360_tcpc_read16(struct regmap *regmap,
>                   ^
> This function is not used, so remove it.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/tcpm/tcpci_mt6360.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpci_mt6360.c b/drivers/usb/typec/tcpm/tcpci_mt6360.c
> index 1b7c31278ebb..6fa8fd5c8041 100644
> --- a/drivers/usb/typec/tcpm/tcpci_mt6360.c
> +++ b/drivers/usb/typec/tcpm/tcpci_mt6360.c
> @@ -43,12 +43,6 @@ struct mt6360_tcpc_info {
>  	int irq;
>  };
>  
> -static inline int mt6360_tcpc_read16(struct regmap *regmap,
> -				     unsigned int reg, u16 *val)
> -{
> -	return regmap_raw_read(regmap, reg, val, sizeof(u16));
> -}
> -
>  static inline int mt6360_tcpc_write16(struct regmap *regmap,
>  				      unsigned int reg, u16 val)
>  {
> -- 
> 2.27.0

-- 
heikki