From:   Khalil Blaiech <kblaiech@nvidia.com>
To:     "hdegoede@redhat.com" <hdegoede@redhat.com>,
        "markgross@kernel.org" <markgross@kernel.org>,
        Vadim Pasternak <vadimp@nvidia.com>
CC:     David Thompson <davthompson@nvidia.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1 1/1] platform/mellanox: add firmware reset support
Thread-Topic: [PATCH v1 1/1] platform/mellanox: add firmware reset support
Thread-Index: AQHZOxm4twa29w0p5U+wuxQvER00lq8D4dOg
Date:   Mon, 20 Mar 2023 13:02:44 +0000
Message-ID: <MN2PR12MB361617473A67AB50CFDAF29AAB809@MN2PR12MB3616.namprd12.prod.outlook.com>
References: <10da04fa43e8acce5d4ec173e225c28b9e979e4b.1675790783.git.kblaiech@nvidia.com>
In-Reply-To: <10da04fa43e8acce5d4ec173e225c28b9e979e4b.1675790783.git.kblaiech@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bPo+ncAerK7vjdka8O2mQ+d1UURcJrnnUgHVmRPIiHDybkaySk+Ww0Eu/BJH?=
 =?us-ascii?Q?XOwfYOgI/DoL3GYOxm/ZketWj+A52Wd9t0bvQ4KLqCah1IB/VkOwTWTot0fR?=
 =?us-ascii?Q?Kw0o7Q9O4HMjjkpV/yIkSwPHzuvbbfBEon5UO2FKNDF9TALXITcvuDq5vx1c?=
 =?us-ascii?Q?ZLX+dom2uRvaTYZNxGAFMPW7kLxI9yN0wxLj+Ae5Au9+5ulzDIJ3cEFdPpQm?=
 =?us-ascii?Q?7HNPCNNy5ziPYtO8rkMRokCk01IU1LSO7wYbxbWIe4jTbkAlUBBI4TP5UWT+?=
 =?us-ascii?Q?WCETJzwIMZYvvEb/z1+0NsvrOrQMkDDRIRN1RpgUkhWNrzczQxy2fljsYNLI?=
 =?us-ascii?Q?VrMQzinMzDwW/35SUymtJORq9rESDYGsgRWRDk33/3OIv4bUUHSDaIQq1DNr?=
 =?us-ascii?Q?HA/7afjMynd7p0DcI9UddX+WEjhYQEkUCZ1Ss252eX0N1aZUQOk1+3cxFJDK?=
 =?us-ascii?Q?5MvTcM9IPCR8wKebZjwx8Ws1DQ++W2vTPP3qIHrbaq/2m+HcrwdXkq+POBwb?=
 =?us-ascii?Q?CUOboczVK7D8i/8GAsZvt2+eoGeo5CXZYlsSzPXGLd031oHGLKocqZLhe9R+?=
 =?us-ascii?Q?3isXiyBN5YEycYTbxtYXoXfPs4rSpKG2jBJqQIdu2RxyJMLK5ms1lHsx6TGd?=
 =?us-ascii?Q?835WBHslFaXDk5uulNMcOl0QA2e4+i6xeg8exm+1aNOCeXe8LhSlxssYz/RN?=
 =?us-ascii?Q?G27ndow2sjREXlgvbjxWJXnIyNfB9bHqUHFrDtFVcRvW2DqaXor8m2VhuWvj?=
 =?us-ascii?Q?UMngc1GbQKzsF7vleYRn7rcn7bMa0FVE3DerySSX+hc7zoEmlmMVutT/lP2f?=
 =?us-ascii?Q?R6roZkxWi7heCuZ4SrRH3CemkLt9HmaSlOnwJAjRUkyRt7p3xKiKW8EQqEs3?=
 =?us-ascii?Q?hVPV7sOWYyKkm9HB8abiRpxcbZzmzeggIHRcllPFQls4ovTbITwruvaAfTzO?=
 =?us-ascii?Q?Lm1D+lVX2oZdInjOUnzRPViW07IMC7xwCIrShElKv0wF3xIU3W8sywva9MGe?=
 =?us-ascii?Q?pdFT5eDiUT0uEXJ93ziLDPDPU9UTKWUyIYaanauZm7fA7+Ofx3iRlB+Qn+em?=
 =?us-ascii?Q?Xdqi6yNVTtQX47BJFEeKRoTtILt9qQ+H1wTbJTGzhttSvTQ9ugqoEPjN/SZn?=
 =?us-ascii?Q?L5oIi3lS9O042nh8N4C/Mpe6S72T5TgF1HAFyPWSxumoX+7lnSPqeEhzLu0k?=
 =?us-ascii?Q?+jc/imzmGFo/b52qVkZKuKmUJUWckQ65pO5X4aHOsBI8z5fYqQLYj9uHkE9/?=
 =?us-ascii?Q?GiEnC8aQfYP62b3KvXUZyNzIq9dneVN3EZsf2KUUwvNRhioYhr4iSdJ3up/S?=
 =?us-ascii?Q?tV5NkL3YNn9HYbn1vHuXxzyWEjFhQjW9Zzq2TXlW0WnXAKOFLBBfrx+nnXqq?=
 =?us-ascii?Q?UfFkU8ieWlz7TQDOF6GnmQPAsuCmDLjgKeGSt6NvW/7TXYXdQ/Cu9LnT6EXK?=
 =?us-ascii?Q?dArbRq1hwf4mLHW27M1jQOWN5cdxV0qMSEV/T54V4oAUy5B5g/e5tOguChdK?=
 =?us-ascii?Q?JyiQMOrZJ6PXOpJ78Uy7/ZqywzEqnGGkdl1XF4TqV8nJnd62NOP1jbVJ9tm7?=
 =?us-ascii?Q?/ETBN68VNGe3JVAP6FiVNN38mrxegndaRr2+KN2M?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3616.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b11b748d-af3e-4da8-5b51-08db2943658e
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Mar 2023 13:02:44.6120
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xFOm/B+gSJbqUm29oxIjJZkUCepYBJxcpB+QSzZJdhsQU5mzooV2juVPrCYR5sfH8RYsTzxRjlPVSuliIsIzow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7930
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi-- Have you got a chance to look into this?

Thanks,
-Khalil

-----Original Message-----
From: Khalil Blaiech <kblaiech@nvidia.com>=20
Sent: Tuesday, February 7, 2023 7:14 PM
To: hdegoede@redhat.com; markgross@kernel.org; Vadim Pasternak <vadimp@nvid=
ia.com>
Cc: David Thompson <davthompson@nvidia.com>; Khalil Blaiech <kblaiech@nvidi=
a.com>; linux-kernel@vger.kernel.org
Subject: [PATCH v1 1/1] platform/mellanox: add firmware reset support

Add a new sysfs to initiate firmware reset in isolation mode.

Reviewed-by: David Thompson <davthompson@nvidia.com>
Signed-off-by: Khalil Blaiech <kblaiech@nvidia.com>
---
 drivers/platform/mellanox/mlxbf-bootctl.c | 19 +++++++++++++++++++  driver=
s/platform/mellanox/mlxbf-bootctl.h |  6 ++++++
 2 files changed, 25 insertions(+)

diff --git a/drivers/platform/mellanox/mlxbf-bootctl.c b/drivers/platform/m=
ellanox/mlxbf-bootctl.c
index 1c7a288b59a5..5e41c270195c 100644
--- a/drivers/platform/mellanox/mlxbf-bootctl.c
+++ b/drivers/platform/mellanox/mlxbf-bootctl.c
@@ -244,11 +244,29 @@ static ssize_t secure_boot_fuse_state_show(struct dev=
ice *dev,
 	return buf_len;
 }
=20
+static ssize_t fw_reset_store(struct device *dev,
+			      struct device_attribute *attr,
+			      const char *buf, size_t count) {
+	unsigned long key;
+	int err;
+
+	err =3D kstrtoul(buf, 16, &key);
+	if (err)
+		return err;
+
+	if (mlxbf_bootctl_smc(MLXBF_BOOTCTL_FW_RESET, key) < 0)
+		return -EINVAL;
+
+	return count;
+}
+
 static DEVICE_ATTR_RW(post_reset_wdog);  static DEVICE_ATTR_RW(reset_actio=
n);  static DEVICE_ATTR_RW(second_reset_action);
 static DEVICE_ATTR_RO(lifecycle_state);  static DEVICE_ATTR_RO(secure_boot=
_fuse_state);
+static DEVICE_ATTR_WO(fw_reset);
=20
 static struct attribute *mlxbf_bootctl_attrs[] =3D {
 	&dev_attr_post_reset_wdog.attr,
@@ -256,6 +274,7 @@ static struct attribute *mlxbf_bootctl_attrs[] =3D {
 	&dev_attr_second_reset_action.attr,
 	&dev_attr_lifecycle_state.attr,
 	&dev_attr_secure_boot_fuse_state.attr,
+	&dev_attr_fw_reset.attr,
 	NULL
 };
=20
diff --git a/drivers/platform/mellanox/mlxbf-bootctl.h b/drivers/platform/m=
ellanox/mlxbf-bootctl.h
index 148fdb43b435..b48243f60a59 100644
--- a/drivers/platform/mellanox/mlxbf-bootctl.h
+++ b/drivers/platform/mellanox/mlxbf-bootctl.h
@@ -75,6 +75,12 @@
=20
 #define MLXBF_BOOTCTL_GET_DIMM_INFO		0x82000008
=20
+/*
+ * Initiate Firmware Reset via TYU. This might be invoked during the=20
+reset
+ * flow in isolation mode.
+ */
+#define MLXBF_BOOTCTL_FW_RESET  0x8200000D
+
 /* SMC function IDs for SiP Service queries */
 #define MLXBF_BOOTCTL_SIP_SVC_CALL_COUNT	0x8200ff00
 #define MLXBF_BOOTCTL_SIP_SVC_UID		0x8200ff01
--
2.30.1