From:   Nick Alcock <nick.alcock@oracle.com>
To:     Lee Jones <lee@kernel.org>
Cc:     mcgrof@kernel.org, linux-modules@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
        Pavel Machek <pavel@ucw.cz>, linux-leds@vger.kernel.org
Subject: Re: [PATCH 10/27] leds: remove MODULE_LICENSE in non-modules
References: <20230224150811.80316-1-nick.alcock@oracle.com>
        <20230224150811.80316-11-nick.alcock@oracle.com>
        <20230303105341.GC2420672@google.com>
Emacs:  the answer to the world surplus of CPU cycles.
Date:   Mon, 20 Mar 2023 10:40:24 +0000
In-Reply-To: <20230303105341.GC2420672@google.com> (Lee Jones's message of
        "Fri, 3 Mar 2023 10:53:41 +0000")
Message-ID: <87zg87u2nb.fsf@esperi.org.uk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1.91 (gnu/linux)
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nBQXVXIpMHoJBBAisw8N6LFLmF4kTbX7aBzhiLbY6jCpbsg4WnfmHrDxU4hD?=
 =?us-ascii?Q?TUhh/12iapWehp+NVqet50gHnJwBVs1ZSfaA4CXQL9keawtjdr3fU48zUf3N?=
 =?us-ascii?Q?PTy7CTxI4zT8Fh3K5LkRTPyd4KXSrR3EzJxQ7LQ3taFlQnlu2KQKv1w93BrS?=
 =?us-ascii?Q?YfVGQ4FATERkxbGdVaQBFfCBzKDtEEu6TCTiOnd3BJRXPOsWW+DTGBJx7rXC?=
 =?us-ascii?Q?izjD1XQPMqPl5ciKMt8/O9rHh1MAb5aJ5dn5IVMol6EAQs3Ff/VW64aoAXe/?=
 =?us-ascii?Q?4JNxkEvcpmsgzmKxSaYGfGIFtU+Gg8moUJLydDQrQ0D6jE3d8cHI5plGNYIG?=
 =?us-ascii?Q?KucSKuYOgOCoIpMHUQcjBKgarEdDdrdQ1JuWjeRCnQ/up3MdU8FW61SrVPMY?=
 =?us-ascii?Q?eWb7X9kZMZ820dgELnVhzDtxJVITBe5u4KSef3VCfPGeQ6SUg9o5W+OmLGgf?=
 =?us-ascii?Q?1BBsyfmrOQVQrSntsvMD1pXeOuLZ9Mdr5u+yXYKvKPb468gUcVfkHpEEeP+r?=
 =?us-ascii?Q?mxQt7VvMB59miXwXfP94M99jgqYI2AbdGrMpidfQshlU+XgqpJfmURU2Gu1y?=
 =?us-ascii?Q?G1rXPA7UYn3KqENByzrwbEgFkrYFaIAPtFyoI1u6Em34yg6i6kDCm7BJzGMH?=
 =?us-ascii?Q?X8mu8ew99j+hccken+qKVFQr1O0yfDpXaRlRiEogBaIlDaj6zoKzWMgu5XvZ?=
 =?us-ascii?Q?AHsSRiMrwz8PGBzrA1A1KVm8OZRpjzQwr4OIi+BQu3iOXu/nbsj7Jsla6HQU?=
 =?us-ascii?Q?B81yCM3wUNi4yM3RJA+3MYEAEEmNaJSSdTH3EYGsl7mqLy45H5IAdNPNts2v?=
 =?us-ascii?Q?+bVnGrdOGp6pvOVx/ObZ94dljy5Vo6YEbqawlqpSxT3+Yh1Nk2wwZs6FFXiq?=
 =?us-ascii?Q?uj2lOr6gGSmk6xe2TNeZuW8htmMGUu7Y5gnJccAS3Kojm9V8rA05ANCZGVbu?=
 =?us-ascii?Q?LfM9tGHZl/A3YwTwp3dMNqUk0E7fmbJ06SsqZYjnqQCpSpaZO79BVbt5njTH?=
 =?us-ascii?Q?AXvGlytVbu0aeh2KbGyUvkxMcYh4NrVorAY2f+mgIslpe3feZVtXCA7/vFVj?=
 =?us-ascii?Q?xgNwWoEg/Oaxbj2i+OsRW8QxJ+LTVQ+MxuYdq7MQhY1et36RGAmCkioH4MXV?=
 =?us-ascii?Q?jUHB3Rxux0Lsw+z++ygllz/jMsvltXOW/FIUBFe15/zpLCnNBUbc0kV8jcyP?=
 =?us-ascii?Q?v7tM2s9u+/OwPtYlXk8PwPVNRsRfelDjZzsgBezH/lX0fqnqqMWLY2MIFZi0?=
 =?us-ascii?Q?o2z4Jt8/rvAbOu24PBlRMX5njs0HjykhUOaV1LTN3cjhBT7iOkQgFojYbYvs?=
 =?us-ascii?Q?RuGvqC0SEhsDswoB2ESeU3DDh1zNo8Rp+VFVOZwZlzTM4Z9sBJIaT+bhA2qJ?=
 =?us-ascii?Q?LuOMI/j4LT61jx4EDQXjbszOueAOePt7qNtwo9/zAq4CT+mSdirOHsvD0TqQ?=
 =?us-ascii?Q?A4xieLaSoyzQa5aA4J5lweXZo2pAATGsrJNUFr4y8UtzeolDRq6vdjr0BNQg?=
 =?us-ascii?Q?H6dzJQxgXEWwZ6Qwu88XfVh6KG61aluUGolLoJqxec0Dfeb8JRAjZgPHyaqu?=
 =?us-ascii?Q?HD3qz1A/tD8Lmt1mB2JHLBfo0b3TvKF4MAwwQTKCmQvNmkRCYbKkZ2un6Wtm?=
 =?us-ascii?Q?Og=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: dgcntK2A+ZXrU9dYuVIyNXi7Pl8pe1svxCqm1pmGyYA4xEd3jHVOlsr7+svdflXBXzQfptn0Ielp+DjCa/wseIIu9K1eA0mj2dzvSYUcTrIP6Tk9jUR08kuPzjCyPuneLwIdb2SCOtxnldTP4jcUxW65FEn3vctc6Fmb43xJSLnKt2Y4FNgQlt+xffq0A+24M9p/DNrZ7tKUm1x3RPD5eM1RyWcykQq+UpQlJZRhlrW0JmCw31S2OyemPo9bKz6ihx9N0APX49mXHit3QtW/LuDIADHLX2ueSvZiquVxPx9EWc/IgSbZKIiDE6PvHVTjioMxlBYfw9OOPC4lgheQDlYVHT0pKyq3gwo1SCEuKTHkR8CniPEbZjb5cQkCRLCH3wbhS0eBhWHlN/HXQlN6fHP2lxwZggFWrGjn1jSiEpKdiMBxzGIk5HhICZ+y8523cBrtdivRjAt+BBlBplgxbbeJjq+wZ+xBQazo4+xU/OzrCQ1z5BABm+688xTZwNKrLVJWsiv0nyOmXaM0nonxtXqThs1Nwt0x0Q0RMDSyY0abegka+NdCvzUmljiGkY5e9qxvU+q3/OyRZfW+3h3wkJqXhzsSpVftsI6PdONyN6reKkwZX8EPQ9+ydRO4qbaaIYKWtS1GPl6k1zWUxTGGBNWrWCv+FilCpoNn+0+hlfW7NVLzPIiOpXzxinVIJwfAyhM/dOfIqXAvnM6yhJGSzb/qcP4REIgFlkguY+Dx3PGMQaR+Skv2y8p8AqRMmP3b6H6LMVqj9dWIh+W+4xYrl+VHbnkI5fOAnO8zBQ/xXyeStjfX3CU2x4EUSJrF9ZZp9cYDNBOzvdOb9qUrp/ZQlQ==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 64026a83-02a4-44c2-07eb-08db292f83af
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 10:40:25.3795
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L5xpFUaJGOyJg6fN0LXnq1+OkTNrLMCd+PTRCYP+LqtfZWRtA07l1wfjsqjBbogES0eljItmt6UV5dtAkJrHRQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4816
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-20_06,2023-03-20_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 malwarescore=0
 phishscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002
 definitions=main-2303200090
X-Proofpoint-ORIG-GUID: txlXQfp3f1l_1TfsFEwfc6i1651D79xn
X-Proofpoint-GUID: txlXQfp3f1l_1TfsFEwfc6i1651D79xn
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3 Mar 2023, Lee Jones uttered the following:

> On Fri, 24 Feb 2023, Nick Alcock wrote:
>
>> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
>> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
>> are used to identify modules. As a consequence, uses of the macro
>> in non-modules will cause modprobe to misidentify their containing
>> object file as a module when it is not (false positives), and modprobe
>> might succeed rather than failing with a suitable error message.
>> 
>> So remove it in the files in this commit, none of which can be built as
>> modules.
>> 
>> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
>> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
>> Cc: Luis Chamberlain <mcgrof@kernel.org>
>> Cc: linux-modules@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org
>> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
>> Cc: Pavel Machek <pavel@ucw.cz>
>> Cc: Lee Jones <lee@kernel.org>
>> Cc: linux-leds@vger.kernel.org
>> ---
>>  drivers/leds/leds-asic3.c | 1 -
>>  1 file changed, 1 deletion(-)
>
> Mention the driver in the subject line please.

Sorry, the prefix-generation is all automated: we use whatever prefix is
most commonly used by all affected drivers in the subsystem and shared
by all of them. In this case, that was simply 'leds', apparently because
almost all things affecting this driver were treewide.

... which probably explains why the driver was removed in January and is
gone in -next, so I guess this one will go away shortly regardless.