Message-ID: <160812bc-20b7-84f4-62e5-5ef4bc624c68@samsung.com>
Date:   Mon, 20 Mar 2023 14:21:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
        Thunderbird/102.8.0
Subject: Re: [PATCH 1/1] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung
 PM173X
Content-Language: en-US
To:     Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>
CC:     Christoph Hellwig <hch@lst.de>,
        "# v4 . 16+" <stable@vger.kernel.org>,
        Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
        Sagi Grimberg <sagi@grimberg.me>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "javier.gonz@samsung.com" <javier.gonz@samsung.com>,
        "k.jensen@samsung.com" <k.jensen@samsung.com>,
        "jh.i.park@samsung.com" <jh.i.park@samsung.com>
From:   Pankaj Raghav <p.raghav@samsung.com>
In-Reply-To: <3B7AB643-C87C-4C19-A47A-C15565750243@oracle.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
CMS-TYPE: 201P
References: <20230315223436.2857712-1-saeed.mirzamohammadi@oracle.com>
        <20230316051508.GA8520@lst.de>
        <930CF361-37C2-4625-B5FA-245248544F92@oracle.com>
        <CGME20230317111849eucas1p115741dc29cc0a5c57914e60aa5216288@eucas1p1.samsung.com>
        <20230317111031.lygazqsaeekpdegd@blixen>
        <3B7AB643-C87C-4C19-A47A-C15565750243@oracle.com>
Precedence: bulk

On 2023-03-17 17:26, Saeed Mirzamohammadi wrote:
>> Hi Saeed,
>> On Thu, Mar 16, 2023 at 09:31:38PM +0000, Saeed Mirzamohammadi wrote:
>>> eui64 values are not unique. Here is an example:
>>> namespace1
>>> nguid   : 36554630529000710025384500000001
>>> eui64   : 002538191100104a
>>> namespace2
>>> nguid   : 36554630529000710025384500000002
>>> eui64   : 002538191100104a
>>> namespace3
>>> nguid   : 36554630529000710025384500000003
>>> eui64   : 002538191100104a
>>> namespace4
>>> nguid   : 36554630529000710025384500000004
>>> eui64   : 002538191100104a
>>>
>>> I haven’t yet contacted Samsung. Do you recommend any one to reach out to?
>>
>> I am able to reproduce this error with a PM173X.
>>
>> nvme id-ns:
>> root@missingno:~# nvme id-ns -n 1 /dev/nvme1 | grep eui64
>> eui64   : 00253891010005b3
>> root@missingno:~# nvme id-ns -n 2 /dev/nvme1 | grep eui64
>> eui64   : 00253891010005b3
>> root@missingno:~# nvme id-ns -n 3 /dev/nvme1 | grep eui64
>> eui64   : 00253891010005b3
>>
>> dmesg:
>> [174690.305507] nvme nvme1: identifiers changed for nsid 1
>> [174878.481002] nvme nvme1: rescanning namespaces.
>> [174878.535981] nvme nvme1: duplicate IDs in subsystem for nsid 2
>> [174878.599982] nvme nvme1: duplicate IDs in subsystem for nsid 2
>> [174883.673001] nvme nvme1: rescanning namespaces.
>> [174883.740045] nvme nvme1: duplicate IDs in subsystem for nsid 2
>> [174883.784025] nvme nvme1: duplicate IDs in subsystem for nsid 3
>> [174883.852034] nvme nvme1: duplicate IDs in subsystem for nsid 2
>> [174883.892040] nvme nvme1: duplicate IDs in subsystem for nsid 3
>>
>> I will report this to our firmware team. Meanwhile, Could you paste your
>> output id-ctrl output here? I am interested in the fw version you are using.
> 
> NVME Identify Controller:
> vid       : 0x144d
> ssvid     : 0x108e
> sn        : S64VNE0R602271
> mn        : SAMSUNG MZWLR3T8HBLS-00AU3
> fr        : MPK94R5Q

We have reported this error to our firmware team. I will keep you posted.

--
Pankaj