Date:   Mon, 20 Mar 2023 14:25:17 +0100
From:   Lorenzo Bianconi <lorenzo@kernel.org>
To:     Abdul Haleem <abdhalee@linux.vnet.ibm.com>
Cc:     linux-next <linux-next@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>,
        Brian King <brking@linux.vnet.ibm.com>,
        linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [next-20230317][PPC/MLX5][bisected 4d5ab0a] Boot WARNING: CPU: 0
 PID: 9 at net/core/dev.c:1928 call_netdevice_notifiers_info
Message-ID: <ZBheva8pJ3VJq/pO@lore-desk>
References: <7fe9d0b0-7d77-79cc-405d-3ca38b552782@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="VPexZZeqZEVbmK5a"
Content-Disposition: inline
In-Reply-To: <7fe9d0b0-7d77-79cc-405d-3ca38b552782@linux.vnet.ibm.com>
Precedence: bulk


--VPexZZeqZEVbmK5a
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> Greeting's
>=20
> Warning is seen while booting kernels from 6.3.0-rc3-next-20230317 on my
> powerpc Power 10 LPAR
>=20
> Boots fine without warnings when below patch is reverted
>=20
> commit 4d5ab0ad964df178beba031b89429a601893ff61
> Author: Lorenzo Bianconi <lorenzo@kernel.org>
> Date:   Thu Mar 9 13:25:31 2023 +0100
>=20
>     net/mlx5e: take into account device reconfiguration for xdp_features
> flag
>=20
>     Take into account LRO and GRO configuration setting device xdp_featur=
es
>     flag. Consider channel rq_wq_type enabling rx scatter-gatter support =
in
>     xdp_features flag and disable NETDEV_XDP_ACT_NDO_XMIT_SG since it is =
not
>     supported yet by the driver.
>     Moreover always enable NETDEV_XDP_ACT_NDO_XMIT as the ndo_xdp_xmit
>=20
> 4d5ab0ad got introduced in next-20230314
>=20
> @Lorenzo Could you please look into this

I would say this issue has been already fixed by Jakub here:

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/net/c=
ore/xdp.c?id=3D769639c1fe8a98129aa97c8ee981639db1e8955c

Regards,
Lorenzo

>=20
> Boot console logs
>=20
> sd 0:0:1:0: [sdb] Preferred minimum I/O size 32768 bytes
>  sdb: sdb1 sdb2 sdb3
> sd 0:0:1:0: [sdb] Attached SCSI disk
> mlx5_core 4001:01:00.0: enabling device (0000 -> 0002)
> mlx5_core 4001:01:00.0: firmware version: 14.32.1010
> ------------[ cut here ]------------
> RTNL: assertion failed at net/core/dev.c (1928)
> WARNING: CPU: 0 PID: 9 at net/core/dev.c:1928
> call_netdevice_notifiers_info+0xd8/0xe0
> Modules linked in: mlx5_core(+) sd_mod t10_pi crc64_rocksoft crc64 sg ibm=
vfc
> mlxfw scsi_transport_fc ibmveth ptp pps_core dm_multipath dm_mirror
> dm_region_hash dm_log dm_mod fuse
> CPU: 0 PID: 9 Comm: kworker/0:1 Not tainted 6.3.0-rc2-next-20230317-autot=
est
> #1
> Hardware name: IBM,9080-HEX POWER10 (raw) 0x800200 0xf000006
> of:IBM,FW1030.00 (NH1030_029) hv:phyp pSeries
> Workqueue: events work_for_cpu_fn
> NIP:  c000000000aca1f8 LR: c000000000aca1f4 CTR: 0000000000725d40
> REGS: c0000000038230a0 TRAP: 0700   Not tainted
> (6.3.0-rc2-next-20230317-autotest)
> MSR:  800000000282b033 <SF,VEC,VSX,EE,FP,ME,IR,DR,RI,LE>  CR: 48228824 XE=
R:
> 00000010
> CFAR: c000000000154c40 IRQMASK: 0
> GPR00: c000000000aca1f4 c000000003823340 c0000000011ccb00 000000000000002f
> GPR04: 00000000ffff7fff c000000003823110 c000000003823108 0000000000000027
> GPR08: c000000c7cc07e90 0000000000000001 0000000000000027 c0000000028f7c30
> GPR12: 0000000048228824 c000000002d10000 c000000000191b58 c0000000032f1000
> GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> GPR20: 0000000000000000 c0000000032f9200 fffffffffffff000 0000000000000000
> GPR24: c000000076c001a0 c00800000042c588 c000000008d06c00 c000000008d069a0
> GPR28: c000000076c301a0 c000000002d01780 0000000000000028 c0000000038233e8
> NIP [c000000000aca1f8] call_netdevice_notifiers_info+0xd8/0xe0
> LR [c000000000aca1f4] call_netdevice_notifiers_info+0xd4/0xe0
> Call Trace:
> [c000000003823340] [c000000000aca1f4]
> call_netdevice_notifiers_info+0xd4/0xe0 (unreliable)
> [c0000000038233c0] [c000000000aca23c] call_netdevice_notifiers+0x3c/0x70
> [c000000003823400] [c000000000b1f64c] xdp_set_features_flag+0x3c/0x50
> [c000000003823420] [c008000000c56db0] mlx5e_set_xdp_feature+0x48/0x90
> [mlx5_core]
> [c000000003823440] [c008000000c59414] mlx5e_probe+0x3cc/0x880 [mlx5_core]
> [c000000003823500] [c00000000088561c] auxiliary_bus_probe+0x6c/0xf0
> [c000000003823580] [c0000000008725e8] really_probe+0x108/0x530
> [c000000003823610] [c000000000872ac4] __driver_probe_device+0xb4/0x230
> [c000000003823690] [c000000000872c98] driver_probe_device+0x58/0x120
> [c0000000038236d0] [c000000000872e7c] __device_attach_driver+0x11c/0x1e0
> [c000000003823750] [c00000000086e994] bus_for_each_drv+0xb4/0x130
> [c0000000038237b0] [c0000000008723cc] __device_attach+0x15c/0x250
> [c000000003823850] [c0000000008704e8] bus_probe_device+0xf8/0x100
> [c0000000038238a0] [c00000000086c258] device_add+0x798/0x9e0
> [c000000003823960] [c0000000008857d8] __auxiliary_device_add+0x58/0xe0
> [c0000000038239d0] [c008000000c35350] add_adev+0xb8/0x180 [mlx5_core]
> [c000000003823a10] [c008000000c35614]
> mlx5_rescan_drivers_locked.part.11+0x1fc/0x260 [mlx5_core]
> [c000000003823ad0] [c008000000c35d88] mlx5_register_device+0xb0/0x100
> [mlx5_core]
> [c000000003823b10] [c008000000c02aa8] mlx5_init_one+0x340/0x680 [mlx5_cor=
e]
> [c000000003823ba0] [c008000000c03e10] probe_one+0x258/0x540 [mlx5_core]
> [c000000003823c30] [c00000000077c2bc] local_pci_probe+0x6c/0x110
> [c000000003823cb0] [c00000000017f9b8] work_for_cpu_fn+0x38/0x60
> [c000000003823ce0] [c0000000001853d4] process_one_work+0x284/0x550
> [c000000003823d80] [c0000000001858f0] worker_thread+0x250/0x5d0
> [c000000003823e00] [c000000000191c88] kthread+0x138/0x140
> [c000000003823e50] [c00000000000cf5c] ret_from_kernel_thread+0x5c/0x64
> --- interrupt: 0 at 0x0
> NIP:  0000000000000000 LR: 0000000000000000 CTR: 0000000000000000
> REGS: c000000003823e80 TRAP: 0000   Not tainted
> (6.3.0-rc2-next-20230317-autotest)
> MSR:  0000000000000000 <>  CR: 00000000  XER: 00000000
> CFAR: 0000000000000000 IRQMASK: 0
> GPR00: 0000000000000000 c000000003824000 0000000000000000 0000000000000000
> GPR04: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> GPR08: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> GPR12: 0000000000000000 0000000000000000 c000000000191b58 c0000000032f1000
> GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> GPR20: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> GPR24: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> GPR28: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> NIP [0000000000000000] 0x0
> LR [0000000000000000] 0x0
> --- interrupt: 0
> Code: 2f890000 409eff9c 39200001 3c82fff1 3c62fff1 3d42017d 38a00788
> 3884b3c8 3863b3d8 992a2141 4b68a969 60000000 <0fe00000> 60000000 3c4c0070
> 38422900
>=20
> --=20
> Regard's
>=20
> Abdul Haleem
> IBM Linux Technology Center

--VPexZZeqZEVbmK5a
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZBhevQAKCRA6cBh0uS2t
rHC1AP9464q9G7eiWdMYp9r0kTxoNmjn3XCE4+gZ0jAh1Dbx8QD/adB7MLFCBoEy
H7IeCfpCjz4ZShdGWlS9uCJXUnD+kAs=
=EuqL
-----END PGP SIGNATURE-----

--VPexZZeqZEVbmK5a--