Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FB9BC6FD1D for ; Mon, 20 Mar 2023 13:35:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230046AbjCTNfJ (ORCPT ); Mon, 20 Mar 2023 09:35:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230450AbjCTNel (ORCPT ); Mon, 20 Mar 2023 09:34:41 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CB934EFB; Mon, 20 Mar 2023 06:34:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E23FBB80E8A; Mon, 20 Mar 2023 13:34:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55D85C433EF; Mon, 20 Mar 2023 13:34:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679319277; bh=cMnOr3tLcRzgkmbSL/WMm9jqyT8XlfB68HNOw/D7CEs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LPbiKaokf9U+3YAZ/kZ+XllTOru/gZRM2xIJSrxQtc7VpLO2F21s+5v+cw0fnthhY t+bbf9nw0X4Rp4NWiLdyOEpkX/Th/TeAgS41XDzGlFcN3+M5UIf2ukZptJAkFaI2l5 C1K0ucKez2pI+3Ofo84hiDmAbbZ2xYSZDHAuIkGpEb+L4hqO89JmIzSNiuNBv7yTzl Ui+HZDf5W6EBiKiOIebpob7/l7aeZ6b3U64vUBmkNVl+lXe/Jla+RDMwg61TS5VDia mYNX7X/Ac0Eb72jh5ghYDYX69eG/+/TvwSvZm4wDc9RQaQAeFvDirbvw3ANolWNbCn hFCaGYrmRZS9g== Date: Mon, 20 Mar 2023 13:34:31 +0000 From: Lee Jones To: "Russell King (Oracle)" Cc: Vinod Koul , Colin Foster , linux-phy@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Florian Fainelli , Andrew Lunn , UNGLinuxDriver@microchip.com, Alexandre Belloni , Claudiu Manoil , Vladimir Oltean Subject: Re: [PATCH v2 net-next 1/9] phy: phy-ocelot-serdes: add ability to be used in a non-syscon configuration Message-ID: <20230320133431.GB2673958@google.com> References: <20230317185415.2000564-1-colin.foster@in-advantage.com> <20230317185415.2000564-2-colin.foster@in-advantage.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Mar 2023, Russell King (Oracle) wrote: > On Mon, Mar 20, 2023 at 02:19:44PM +0530, Vinod Koul wrote: > > On 17-03-23, 11:54, Colin Foster wrote: > > > The phy-ocelot-serdes module has exclusively been used in a syscon setup, > > > from an internal CPU. The addition of external control of ocelot switches > > > via an existing MFD implementation means that syscon is no longer the only > > > interface that phy-ocelot-serdes will see. > > > > > > In the MFD configuration, an IORESOURCE_REG resource will exist for the > > > device. Utilize this resource to be able to function in both syscon and > > > non-syscon configurations. > > > > Applied to phy/next, thanks > > Please read the netdev FAQ. Patches sent to netdev contain the tree that > the submitter wishes the patches to be applied to. > > As a result, I see davem has just picked up the *entire* series which > means that all patches are in net-next now. net-next is immutable. > > In any case, IMHO if this kind of fly-by cherry-picking from patch > series is intended, it should be mentioned during review to give a > chance for other maintainers to respond and give feedback. Not all > submitters will know how individual maintainers work. Not all > maintainers know how other maintainers work. Once again netdev seems to have applied patches from other subsystems without review/ack. What makes netdev different to any other kernel subsystem? What would happen if other random maintainers started applying netdev patches without appropriate review? I suspect someone would become understandably grumpy. -- Lee Jones [李琼斯]