Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0979EC7618D for ; Mon, 20 Mar 2023 13:35:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231281AbjCTNfl (ORCPT ); Mon, 20 Mar 2023 09:35:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231270AbjCTNfe (ORCPT ); Mon, 20 Mar 2023 09:35:34 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6098C167 for ; Mon, 20 Mar 2023 06:34:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679319286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UL6ZvX+vjCKaJ8maGzwsaH5uxn7gh6HZeTFGTMUfwTI=; b=Pzbl4aAG3TaolLhhc3l6QdSDcNsXkTiJjtSisTLSXTKheeiAb+a1kVJ6TsX+mq3bIoci7d fuLOHHgtakKjz00neQnDG0k+lEsVZ+vB6gMknf4Dlel+rWxcqYGk+CMkoLrCYNFvVcFTq5 onlKQdPXdNLpQ1h+dj2FvVEgLwnhW+8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-329-DWT6hxrlPmWwuLE8pVKsEQ-1; Mon, 20 Mar 2023 09:34:45 -0400 X-MC-Unique: DWT6hxrlPmWwuLE8pVKsEQ-1 Received: by mail-wm1-f71.google.com with SMTP id bg13-20020a05600c3c8d00b003ed40f09355so5535749wmb.5 for ; Mon, 20 Mar 2023 06:34:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679319284; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UL6ZvX+vjCKaJ8maGzwsaH5uxn7gh6HZeTFGTMUfwTI=; b=4em8n1ZghtOBFgWsftR8UQ9Ec+Gg+X+I5sDRy639rLxatrG1DiN44qNzJv38f6RzO7 kb3p2e+IDeU6vX731zvYxNn7ZHFundZPXPuQ5AjbuNQ4sxM4Bh2zjm8KXqNNXrVw1JgZ mmNtY9OzKxjUfAWR34SbNFp9RtagUxg6Rf6DgxkeioQbkzSpyGa0gdsbipq+GARCIutY zEsk+w77IYhEqsxB2G1kHvWUTkK7t8XwioKmJanO78RgVn5zrxEVcO2Uz7r9DR7VzR3K Vh4PNDpztS4kxBheMZAJRd353Z+ru3kRAa6Frk0tRmkVLCaB6kYDGhZBcv3qfBxhuMzd +hQA== X-Gm-Message-State: AO0yUKWz8Kl4208QXNYZWrkkYRpNvS8z7KZeaZCIN2Ej491suieIkd68 agxXFzBtJ7zfq1M0SSVNB/VRHd6O8MEhoKXErPBQ7tBvce4fZcCi1XEY9hIjIJRAGHgX3ynoPt/ Z1suFZDQhWwXoSs2zVW576Y9k+U9VCTUf X-Received: by 2002:adf:dec9:0:b0:2d4:e032:6322 with SMTP id i9-20020adfdec9000000b002d4e0326322mr5820652wrn.31.1679319284010; Mon, 20 Mar 2023 06:34:44 -0700 (PDT) X-Google-Smtp-Source: AK7set/Q81rpIrERD7ha3OcykcIz8yRM2cmG+OragzAJxFqbYZ6HxK/bVifpz+SZw9IO/LLzXVy7zQ== X-Received: by 2002:adf:dec9:0:b0:2d4:e032:6322 with SMTP id i9-20020adfdec9000000b002d4e0326322mr5820642wrn.31.1679319283724; Mon, 20 Mar 2023 06:34:43 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:4100:a064:1ded:25ec:cf2f? (p200300cbc7024100a0641ded25eccf2f.dip0.t-ipconnect.de. [2003:cb:c702:4100:a064:1ded:25ec:cf2f]) by smtp.gmail.com with ESMTPSA id b4-20020a056000054400b002d672637520sm3454972wrf.96.2023.03.20.06.34.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 06:34:42 -0700 (PDT) Message-ID: <70d9bf96-2623-d617-c03d-3c7f6c5cbf8b@redhat.com> Date: Mon, 20 Mar 2023 14:34:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] mm: mmap: remove newline at the end of the trace Content-Language: en-US To: Minwoo Im , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: Steven Rostedt , Masami Hiramatsu , "Matthew Wilcox (Oracle)" References: From: David Hildenbrand Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11.03.23 00:18, Minwoo Im wrote: > We already have newline in TP_printk so remove the redundant newline > character at the end of the mmap trace. > > <...>-345 [006] ..... 95.589290: exit_mmap: mt_mod ... > > <...>-345 [006] ..... 95.589413: vm_unmapped_area: addr=... > > <...>-345 [006] ..... 95.589571: vm_unmapped_area: addr=... > > <...>-345 [006] ..... 95.589606: vm_unmapped_area: addr=... > > to > > <...>-336 [006] ..... 44.762506: exit_mmap: mt_mod ... > <...>-336 [006] ..... 44.762654: vm_unmapped_area: addr=... > <...>-336 [006] ..... 44.762794: vm_unmapped_area: addr=... > <...>-336 [006] ..... 44.762835: vm_unmapped_area: addr=... > > Signed-off-by: Minwoo Im > --- > include/trace/events/mmap.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb