Date:   Mon, 20 Mar 2023 10:16:21 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Matthew Wilcox <willy@infradead.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, patches@lists.linux.dev,
        maple-tree@lists.infradead.org
Subject: Re: [PATCH 00/10] cleanup vma_merge() and improve mergeability tests
Message-ID: <20230320141621.fm3iwh7khjhji6zc@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Andrew Morton <akpm@linux-foundation.org>,
        Matthew Wilcox <willy@infradead.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, patches@lists.linux.dev,
        maple-tree@lists.infradead.org
References: <20230309111258.24079-1-vbabka@suse.cz>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230309111258.24079-1-vbabka@suse.cz>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zBhXLJfqAWizu+fbDkxpe9YJ8a/7g0ChnZmcJDIy4KGBIs+GN00Y89GD2yWV?=
 =?us-ascii?Q?ZHXQf7KK3HYVqYjpwU9zpeFr8Iesa4ldr6JumQovXNJrrUCjCeZhdaTkQ1sj?=
 =?us-ascii?Q?SMVrhjUQtGxFoLoWXf19Viv17lX1ls7FgnijJgZDhHLdZLkof3WIOmFhv2vL?=
 =?us-ascii?Q?A2blF+ofixuJZBwwl+j8QMbvdMQbiHREKxDVKuEvJCGWkUVUs0itVy5quBdJ?=
 =?us-ascii?Q?p18EcXGdpLAetXc9Fw0YRiKAczFG5ifTOJvGQsrL5x2rpUMVF78ExsyfOFyp?=
 =?us-ascii?Q?+eQt2sKuvPb6efGkgjbPiJZpPr8gMedxHKBKQ0sRlZhvRFy03FEcWs2Im0bF?=
 =?us-ascii?Q?Wpg4coWPqxWIpnIfFSW2XrciCWdXXAXes+iwmaUUXdVOFFwCPw9eGR17AwUu?=
 =?us-ascii?Q?8jou32ZVUqAYow4c0QLh8fQxtwTrbFL5D16dAOoYpRlJ2KFh45C0Ml5wxr/A?=
 =?us-ascii?Q?4lu2CGMqPhaMpuMw6H0k2rAf8sQAtLFNYBcDPGCSZObkZIsEINTlH7c46/zS?=
 =?us-ascii?Q?kmU10VduU7bc3rWeRjwwhI2XSlLLpqaSZt8jkvV+gLF9xUmfoXdgwZ7278fL?=
 =?us-ascii?Q?9igRl2N6g7Ew/etxs56YlmWILTbPSQmjPFY15r63YAFhoN/Fqr0+q+30zDYf?=
 =?us-ascii?Q?JYhTB/EpkWNvwS0QtaBtMMoSZL9KPaTGHOxGPKhkcw4qK1B4PG1KpDQD8tV5?=
 =?us-ascii?Q?c2+2F34oCezu0Qw9csoHnDBphNtQ9yoa8dlFfX3ehdvUDHd60QrJO2AOSDdJ?=
 =?us-ascii?Q?oIrBDXWh2bZw0hzl6Xk8LLmHp1Qe6P7LDmfjpfL+EIl3CvNxoA/jXzmELhZl?=
 =?us-ascii?Q?ZHUna/Gyn/EmiAEUKguCZ+nk2sfTLQYgEUpc4XqrofH7kKO216ibGokHwoGI?=
 =?us-ascii?Q?bkOHkNuP7q3AAltc4juZzyCU1EEBXzf/wuf1MyaRreKiQVKBf/rQqnU7avxL?=
 =?us-ascii?Q?dBuE3ytcVLb/qdlLzOMg7B4VvTwpMAWWLH2vMTkiaHU9GJ0K+HWDuVbQFI90?=
 =?us-ascii?Q?RsibSsKvc/yOwGDFJg3Vpa9T0dfib2Ua7OCodBAZukqEf/P8uF/yWx2wfOkN?=
 =?us-ascii?Q?BKlFqR8V8sLCBn5xDhe0/OiJVTLQPF9FZeC/j6RCVMX1PeJnpxtuVXsArPKq?=
 =?us-ascii?Q?YmQ+YRiB8fxRE/KvHKyWdQ7SvcBuboeAENhS3bCIs4zC3ht4iGK0W98HFqL6?=
 =?us-ascii?Q?eWun/RYh35YYF/UL7847KKjkWiDDxR7G7MCf38XgN5v2vDpUfYtcfyQphKVL?=
 =?us-ascii?Q?pCopYR/LEGuOFRsJx6vQPTCJVxW1bSmrpr8AKcQa020ahNghf44ZWO391S4m?=
 =?us-ascii?Q?tL/QaPQaUW2U5anaFkXSvXWmy96Ur5UeJy67KI18zUDeWtdUvrqZpYzkTe8j?=
 =?us-ascii?Q?Q3sxD0xV/sSEabixqIfpY9YHVhznKyGP6E0ZnWilohad2IKhVvYo6Dpqe71d?=
 =?us-ascii?Q?nN5KZjZ79boALB9L9pXSnJkMLGxbBOxLUlu+s+EgWB+s5e8sAZJqdJRsFsJ2?=
 =?us-ascii?Q?+N9aclOLxUhgooF8LiqKTYrZ4B3LjBZHDENOwJdKGDr2JXyX7sIaoDt8keY6?=
 =?us-ascii?Q?icGtm5S5X8VZLmc5t2e4zeaX9Ce9cFomEbAxVlO36PyOqISfz+5CZrVKpgmF?=
 =?us-ascii?Q?9w=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?u/UrxBWw/ilBfUxU79OG0VpWKVzSs6muUZhlPcp8OTXy2IPi8H40f9/ULxw9?=
 =?us-ascii?Q?pqcC2XUYg5d2yUEvIP7gHhGvi5R26JOV6PUa+4eHumbYLE2JhUNnBy1sewB2?=
 =?us-ascii?Q?m3Qoc36RtkHt0AolcIBYsETA+vlsW19y3KJhjcf7bDkKFaz8M/FTJpGFLu03?=
 =?us-ascii?Q?c95TV2+toV6V7e5p2gMCqlQTBOL+5jO+wCI/i5iOrI5L9Vd/X1R7vY0vj5If?=
 =?us-ascii?Q?2rGZMVfd3SYmGns1YhgGaWMCzTalGmx6HIFJSy54dkIdEqSCSJommZ/r3x83?=
 =?us-ascii?Q?xHodmDOdWNIvCz8fS6v4scvLxP2K75bItRWUACho6iL+I6tUv//D1XV0BUii?=
 =?us-ascii?Q?aqOXgNgjiSAE6WBasVA4H6HIlSyOGhw+8gIThJ9Ek5rKVLH+YvGK78ErcBTS?=
 =?us-ascii?Q?HSRJoE6kbfC9UZeBEzOgcB5/U2JOG+Mcd1LI2jRdkBWqBh9Ea/Q4iMZhNGp5?=
 =?us-ascii?Q?aObAIGgj1vQvXwY3gw+btiUy4tXyFWTBhQEvcuwemqz4W4PmPO38EsgBXsui?=
 =?us-ascii?Q?AAAU0UrFIfVbVrH8uCSnWxUmj/zXZJ4X3bRlJ8iig01gqiUChMVELNeEGFRy?=
 =?us-ascii?Q?iG+ESWR6s5VheJxihDRyZwmhvNkEbzXNR8YMG+7iHEWiq7iWhaNTQTifuZVS?=
 =?us-ascii?Q?aJIv3OjW3orADXBJe2QMYQekj0o+iOJB+KFfPTnp2Pa8FaQTUjv/EYWiaaeU?=
 =?us-ascii?Q?ZFM8YRsKIrfQUQG4zFFAJo+AS5cJeuS+VEiLYGuO8JuvY44PWH0OJZJa3Zqs?=
 =?us-ascii?Q?NbiQwiN0EUAIvOJgILxmgybo0GHbyY8PxXZi+MuUt4/0TN5v/t+JUh4j6g+n?=
 =?us-ascii?Q?vkxZF2F63W34IQclXQx3ofbFR/umIVLJbd9krUEyiDbpIlzevMcwMMo0vjZx?=
 =?us-ascii?Q?bxy8gnG/F5MMomUlFSyMYs91llLiqnAKVDg0LrcBD0wqJLjvEPVAyO+Sk8wP?=
 =?us-ascii?Q?1jZ2gKqsfsFprGhd5s/QNzuLN6vhfzpgOpQPYDhgkR/uzmFXwO4KKem2p4M3?=
 =?us-ascii?Q?ENMM?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 15a6d016-5cf1-4e5e-1c63-08db294daf82
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 14:16:23.8379
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wRKViCPw8cWvb/G661Pc4ow0atNNn8yI3tew6ECEE2Y+fJd9IIQu/vJmldO5nkxCYy5SJDqU1C1h5mXmdlfY4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4220
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-20_10,2023-03-20_02,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=2 spamscore=2 adultscore=0 malwarescore=0
 phishscore=0 bulkscore=0 mlxscore=2 mlxlogscore=161 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002
 definitions=main-2303200120
X-Proofpoint-GUID: 3t0khuHe1qjscPlWpU8wYwRHbshaFrI2
X-Proofpoint-ORIG-GUID: 3t0khuHe1qjscPlWpU8wYwRHbshaFrI2
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Sorry for the late review, I've been away.

For the whole series,
Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>

* Vlastimil Babka <vbabka@suse.cz> [230309 06:18]:
> Also available in git:
> https://git.kernel.org/vbabka/h/vma_merge_cleanup-v1r2
> 
> Changes since RFC:
> - rebased to 6.3-rc1, dropped first patch (urgent fix) that was merged there
> - reindent parameters of mergeability checks (suggested by willy on IRC)
> 
> My initial goal here was to try making the check for vm_ops->close in
> is_mergeable_vma() only be applied for vma's that would be truly removed
> as part of the merge (see Patch 9). This would then allow reverting the
> quick fix d014cd7c1c35 ("mm, mremap: fix mremap() expanding for vma's
> with vm_ops->close()"). This was successful enough to allow the revert
> (Patch 10). Checks using can_vma_merge_before() are still pessimistic
> about possible vma removal, and making them precise would probably
> complicate the vma_merge() code too much.
> 
> Liam's 6.3-rc1 simplification of vma_merge() and removal of
> __vma_adjust() was very much helpful in understanding the vma_merge()
> implementation and especially when vma removals can happen, which is now
> very obvious. While studing the code, I've found ways to make it
> hopefully even more easy to follow, so that's the patches 1-8. That made
> me also notice a bug that's now already fixed in 6.3-rc1.
> 
> Vlastimil Babka (10):
>   mm/mmap/vma_merge: use only primary pointers for preparing merge
>   mm/mmap/vma_merge: use the proper vma pointer in case 3
>   mm/mmap/vma_merge: use the proper vma pointers in cases 1 and 6
>   mm/mmap/vma_merge: use the proper vma pointer in case 4
>   mm/mmap/vma_merge: initialize mid and next in natural order
>   mm/mmap/vma_merge: set mid to NULL if not applicable
>   mm/mmap/vma_merge: rename adj_next to adj_start
>   mm/mmap/vma_merge: convert mergeability checks to return bool
>   mm/mmap: start distinguishing if vma can be removed in mergeability
>     test
>   mm/mremap: simplify vma expansion again
> 
>  mm/mmap.c   | 142 ++++++++++++++++++++++++++++------------------------
>  mm/mremap.c |  20 ++------
>  2 files changed, 80 insertions(+), 82 deletions(-)
> 
> -- 
> 2.39.2
>