Date:   Sun, 19 Mar 2023 17:18:53 -0400
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Mark Brown <broonie@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2 0/2] regmap-irq: Drop map from handle_mask_sync()
 parameters
Message-ID: <ZBd8PZa0kCcG4MQD@fedora>
References: <cover.1679259085.git.william.gray@linaro.org>
 <ZBhVOziLz6WL6vv7@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="yJ3RjQKbw+mthOrU"
Content-Disposition: inline
In-Reply-To: <ZBhVOziLz6WL6vv7@smile.fi.intel.com>
Precedence: bulk


--yJ3RjQKbw+mthOrU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 20, 2023 at 02:44:43PM +0200, Andy Shevchenko wrote:
> On Sun, Mar 19, 2023 at 05:02:00PM -0400, William Breathitt Gray wrote:
> > Changes in v2:
> >  - Pull out 104-dio-48e refactor to a precursor patch
> >=20
> > Remove the map parameter from the struct regmap_irq_chip callback
> > handle_mask_sync() because it can be passed via the irq_drv_data
> > parameter instead. The gpio-104-dio-48e driver is the only consumer of
> > this callback and is thus updated accordingly.
> >=20
> > A couple pending patchsets also utilize handle_mask_sync() [0][1], so
> > it'll be useful to merge the changes in this series first to avoid
> > subsequent noise adjusting the dependent drivers.
> >=20
> > [0] https://lore.kernel.org/r/cover.1677515341.git.william.gray@linaro.=
org/
> > [1] https://lore.kernel.org/r/cover.1678106722.git.william.gray@linaro.=
org/
>=20
> Good idea and intention, but something went wrong with bisectability as p=
ointed
> out by the build bot. As a last resort you would need to squash these two=
, but
> try first another possible patch series split.
>=20
> --=20
> With Best Regards,
> Andy Shevchenko

I should have build tested each commit when I rebased rather than just
the last. I'd rather avoid a squash so that these changes are distinct
for the sake of a clear git history on the regmap API change; I'll
submit a v3 soon with the minor changes needed.

William Breathitt Gray

--yJ3RjQKbw+mthOrU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZBd8PQAKCRC1SFbKvhIj
K7RQAQDfk4YWJnxcERWnwB2mljw7M5GixdW+XeoUvcJG1FFcvwEAkF1+dcfljnmv
gnkb42RMyBqecCEsyWOkr1gmf93vng4=
=NFFG
-----END PGP SIGNATURE-----

--yJ3RjQKbw+mthOrU--