Message-ID: <7b4f8261bd3cc76c123ee7fbd176ca6a82387dce.camel@debian.org>
Subject: Re: [PATCH net-next 0/3] Add SCM_PIDFD and SO_PEERPIDFD
From:   Luca Boccassi <bluca@debian.org>
To:     Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>,
        davem@davemloft.net
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Leon Romanovsky <leon@kernel.org>,
        David Ahern <dsahern@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Kees Cook <keescook@chromium.org>,
        Christian Brauner <brauner@kernel.org>, smcv@collabora.com
Date:   Mon, 20 Mar 2023 14:35:15 +0000
In-Reply-To: <20230316131526.283569-1-aleksandr.mikhalitsyn@canonical.com>
References: <20230316131526.283569-1-aleksandr.mikhalitsyn@canonical.com>
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="=-g+4MrqyDATbFKaUjggeo"
User-Agent: Evolution 3.38.3-1+plugin 
MIME-Version: 1.0
Precedence: bulk


--=-g+4MrqyDATbFKaUjggeo
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2023-03-16 at 14:15 +0100, Alexander Mikhalitsyn wrote:
> 1. Implement SCM_PIDFD, a new type of CMSG type analogical to SCM_CREDENT=
IALS,
> but it contains pidfd instead of plain pid, which allows programmers not
> to care about PID reuse problem.
>=20
> 2. Add SO_PEERPIDFD which allows to get pidfd of peer socket holder pidfd=
.
> This thing is direct analog of SO_PEERCRED which allows to get plain PID.
>=20
> 3. Add SCM_PIDFD / SO_PEERPIDFD kselftest
>=20
> Idea comes from UAPI kernel group:
> https://uapi-group.org/kernel-features/
>=20
> Big thanks to Christian Brauner and Lennart Poettering for productive
> discussions about this.
>=20
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: Leon Romanovsky <leon@kernel.org>
> Cc: David Ahern <dsahern@kernel.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Christian Brauner <brauner@kernel.org>
>=20
> Alexander Mikhalitsyn (3):
> =C2=A0=C2=A0scm: add SO_PASSPIDFD and SCM_PIDFD
> =C2=A0=C2=A0net: core: add getsockopt SO_PEERPIDFD
> =C2=A0=C2=A0selftests: net: add SCM_PIDFD / SO_PEERPIDFD test

I've implemented support for this in dbus-daemon:

https://gitlab.freedesktop.org/dbus/dbus/-/merge_requests/398

It's working very well. I am also working on the dbus-broker and polkit
side of things, will share the links here once they are in a reviewable
state. But the dbus-daemon implementation is enough to meaningfully
test this.

For the series:

Tested-by: Luca Boccassi <bluca@debian.org>

--=20
Kind regards,
Luca Boccassi

--=-g+4MrqyDATbFKaUjggeo
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEErCSqx93EIPGOymuRKGv37813JB4FAmQYbyMACgkQKGv37813
JB6t4Q/+LGVA6D+WY1fJtevPmTYQLD8EETU5dViUGoPPOwDMl2RbZAbvZV5syoh7
Qp27XNLX8m0kL4j7oUCZCEae1kydxmUg2IW+urUZBLKaYlf6lO8aiwdWMJzdwTLg
QnQnFd667ToGX57ZCMe00qWc/FeIqMXbhYdvpJARuPQPctD6+nQTCGcfstX0UV2V
e90FgATPEVIG/4jn2gpq7Pi7G/YzCCZenrfQokftx3j62XkA+vvW5KL85HfNUh7s
W/QztIr+RgYssEaO1jd3dKaWqcOPuQjRqIxL0aRpwGV83nQptL2wzkoXgH/lU905
WOjPF7CZPARnZi+sISOA+nRNI4I19X3LaibfIUUypvTEutx/ejH3vEBTgZKGTx1v
fcJOMZ9srZU5Ap+/tLgJnmQ/MsksxhY7ddlecXdg0gIp6Yhdavc0gflNycfknXj9
OanmPcKc05q93784bH2By4ZDaKmgUb0hoykKbq+4dYF24ap38yP2MXxnevevZzNK
SXlyXKu2qz6jRcleQSu/AaAMbyadaa6lt5antKKiMrmgB0LU3D25b0HfXkcNk9q1
vIsSqChvtqIRp3KAZXZdADVO0nDjZWqkfnrNo59sJ3TBl+BaIflR95gxpLu/c5A/
H6CmAE2WTYQdqzYUvbacyeLABURr/EhDzYIobGZqiKNOiovTPE0=
=Mns1
-----END PGP SIGNATURE-----

--=-g+4MrqyDATbFKaUjggeo--