Date:   Mon, 20 Mar 2023 15:48:41 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Grant Grundler <grundler@chromium.org>
Cc:     Oleksij Rempel <linux@rempel-privat.de>,
        Pavel Skripkin <paskripkin@gmail.com>,
        Lukas Wunner <lukas@wunner.de>,
        Eizan Miyamoto <eizan@chromium.org>,
        Jakub Kicinski <kuba@kernel.org>,
        netdev <netdev@vger.kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        LKML <linux-kernel@vger.kernel.org>,
        Anton Lundin <glance@acc.umu.se>
Subject: Re: [PATCHv5 net 1/2] net: asix: fix modprobe "sysfs: cannot create
 duplicate filename"
Message-ID: <ZBhySakjpQdq8Oro@corigine.com>
References: <20230317181321.3867173-1-grundler@chromium.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230317181321.3867173-1-grundler@chromium.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LQjdCQXm+zeuEeC6TtYkngAXfJk9I468OLv0bsXwfbP4L9CDqGX4kNhxHOGM?=
 =?us-ascii?Q?LvBC6MCxr0adgwDOaJOAwUZGwbXG/1l8HQi8vpfsJCy9drD+XVCCkx3C0IDF?=
 =?us-ascii?Q?7wqJhI/nrCewtnnDJ7qZ7FetPG9OIgRaKyNwvvutoo4ZBGLeFf2qAHd8kXi+?=
 =?us-ascii?Q?x8yAFrNvZe0avn3rP2fHICoartCN1fcFXJFvQWsNOjhrd//DpBEaQu62msuP?=
 =?us-ascii?Q?39D4g0gKh43OV2m3bxRinz0yZDgy66ip6Ca0wCiUs3V7E1gmruDiNZZU1Ftw?=
 =?us-ascii?Q?PsfO936XKtka4+rn8+A7cwBC2VWZayi9aaF1VLSOKXXSA8jj/KsKekAHeDEY?=
 =?us-ascii?Q?9pctTP0RvNUo3/8SYq6iHEo/YqAxIx1yV9D398uzLuGeCckRUlguCsVYs5bt?=
 =?us-ascii?Q?EWRl4C+WceeG5nb1+XEUaJt5kvvbddgljOadAosHI7/1dbfdNS4x6azgL/oM?=
 =?us-ascii?Q?WdfLjKMiKE1Mf1BR8ELrrLaTqEl9Czf2nNGoYwDdBzF8vzwyoS9qVvZBA2Ta?=
 =?us-ascii?Q?Ncf/iGzcZvqM/FQnav6MA4G3eal7lfxrBDZLM1F/tfnCwn1JOpTl41hK/PoD?=
 =?us-ascii?Q?gWN83hnNG2mx2DYW2mrZ+4X61amaJTuH76TbEuOQGfczcPUtncGTJPNVrrKX?=
 =?us-ascii?Q?MLrOdEzkzKWjfybTAey2BMRmuRVbtC/uDQF/WFRlQxMS+N9dG/tOk1o4CqZS?=
 =?us-ascii?Q?R9SgoFrM6tDi/QTCbxRvjfWFFCcev1zcOvdqM8j3QmXo59W1AhuGSwdinLha?=
 =?us-ascii?Q?KlrGCmmop9C5R9PArJ8IQmUY/LS/DkZWgELUMCTsEWPLZIoJddz5Ko4qD5bW?=
 =?us-ascii?Q?NVknMcCgNDUy8Fe1MdMH5VfEtM/MsDUjQR7beaFWcRdf7X6UeGsO7Gl8BnH9?=
 =?us-ascii?Q?MWLgaQLtjiXpFdMBx6eb28EvX6glSc1v7DnJt++a+V7K82gNH+03a6BrO3qq?=
 =?us-ascii?Q?VTR9WAFcpY2J+BO3MVwb4w7J8J1kZNQDxaL9Wccr1G2aTct3F9QBXnomKD/4?=
 =?us-ascii?Q?ehSmLjariu0nBMoFNdhAdP6AD0tdwqlpPWOSVGcg1zzbb3rmykiA9M7nu5u5?=
 =?us-ascii?Q?vBmMvQ+ToeZXgKlKwS69gL1irRUpR2z6eLD89mSzBOlpumyv5wkz2ULR31RM?=
 =?us-ascii?Q?H3STUPnhSPlfgtlzRm94+NIwwFcMY5+EcYLBer9lJsQt8iscSBOpZQMlD3Qh?=
 =?us-ascii?Q?yf+BNR3Regnc8bFpksHcuc3gXvyUAy2JMsdd0Zx7d4WMDFuIApYCzNdZAO9r?=
 =?us-ascii?Q?uaO8adSSeb7Co4IsPD2SIbkpvBHmJ8AYl9OsuZLFZqOVAzIfCmAYh1SsMq95?=
 =?us-ascii?Q?Vn/iFMRKYUjBU8l0EmnBkucp56BRruQIK1qxK9ZgfnyvAPrgFg8I0vERF8Iw?=
 =?us-ascii?Q?CYBsOHdQbZsvGsFD0RTRS1Q7HRPzqDQtbezHySJ+lqvimevAD57Jj8K7YAha?=
 =?us-ascii?Q?CSrIw/FGnGgRFoa+nXrl9/53mGDg5X6iyNu+O82zw9WAE0yJsg9QKVsh3uPR?=
 =?us-ascii?Q?xOO0dERG3Bsox2SjnT+sKri8tp8kw51yGcZ3vjj1BH3yAXvLazpX8y4VTtr4?=
 =?us-ascii?Q?GTysgW8n5uJgwpYJMElaoyLPiQK6wjPnwBGWuVR4D6Xiqr8JAfNDp5dYYChz?=
 =?us-ascii?Q?jwv5E/Ky5/Ovn10eVbzvZjv7j+jyBrVgd/qSBZF1wsepDBlVjwDhf3Dw/Wgy?=
 =?us-ascii?Q?uUgDOw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b440e6de-ce8a-4c15-6268-08db29523b11
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 14:48:56.1871
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0AVsiTyoNRyydNOpZvZ8vpsJweDd1ocra7FVl2eXpF1HqRhv/LyrSGxt5NUDjNPsKNIBY/vPaI/ZLoQ5LkK9MROBO+98BStjEAImjzcg4qQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR13MB3685
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 17, 2023 at 11:13:21AM -0700, Grant Grundler wrote:
> "modprobe asix ; rmmod asix ; modprobe asix" fails with:
>    sysfs: cannot create duplicate filename \
>    	'/devices/virtual/mdio_bus/usb-003:004'
> 
> Issue was originally reported by Anton Lundin on 2022-06-22 (link below).
> 
> Chrome OS team hit the same issue in Feb, 2023 when trying to find
> work arounds for other issues with AX88172 devices.
> 
> The use of devm_mdiobus_register() with usbnet devices results in the
> MDIO data being associated with the USB device. When the asix driver
> is unloaded, the USB device continues to exist and the corresponding
> "mdiobus_unregister()" is NOT called until the USB device is unplugged
> or unauthorized. So the next "modprobe asix" will fail because the MDIO
> phy sysfs attributes still exist.
> 
> The 'easy' (from a design PoV) fix is to use the non-devm variants of
> mdiobus_* functions and explicitly manage this use in the asix_bind
> and asix_unbind function calls. I've not explored trying to fix usbnet
> initialization so devm_* stuff will work.
> 
> Fixes: e532a096be0e5 ("net: usb: asix: ax88772: add phylib support")
> Reported-by: Anton Lundin <glance@acc.umu.se>
> Link: https://lore.kernel.org/netdev/20220623063649.GD23685@pengutronix.de/T/
> Tested-by: Eizan Miyamoto <eizan@chromium.org>
> Signed-off-by: Grant Grundler <grundler@chromium.org>

Reviewed-by: Simon Horman <simon.horman@corigine.com>