Date:   Mon, 20 Mar 2023 07:58:24 -0700
From:   "Darrick J. Wong" <djwong@kernel.org>
To:     Yangtao Li <frank.li@vivo.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>, linux-xfs@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2, RESEND 07/10] xfs: convert to kobject_del_and_put()
Message-ID: <20230320145824.GZ11376@frogsfrogsfrogs>
References: <20230319092641.41917-1-frank.li@vivo.com>
 <20230319092641.41917-7-frank.li@vivo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230319092641.41917-7-frank.li@vivo.com>
Precedence: bulk

On Sun, Mar 19, 2023 at 05:26:38PM +0800, Yangtao Li wrote:
> Use kobject_del_and_put() to simplify code.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>

Looks good to me,
Acked-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_sysfs.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/xfs/xfs_sysfs.h b/fs/xfs/xfs_sysfs.h
> index 148893ebfdef..e2ff063e2c29 100644
> --- a/fs/xfs/xfs_sysfs.h
> +++ b/fs/xfs/xfs_sysfs.h
> @@ -48,8 +48,7 @@ static inline void
>  xfs_sysfs_del(
>  	struct xfs_kobj	*kobj)
>  {
> -	kobject_del(&kobj->kobject);
> -	kobject_put(&kobj->kobject);
> +	kobject_del_and_put(&kobj->kobject);
>  	wait_for_completion(&kobj->complete);
>  }
>  
> -- 
> 2.35.1
>