Date:   Mon, 20 Mar 2023 11:53:36 -0400
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     linux-iio@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] counter: 104-quad-8: Utilize helper functions to
 handle PR, FLAG and PSC
Message-ID: <ZBiBgI5mVHAg/59Y@fedora>
References: <cover.1679149542.git.william.gray@linaro.org>
 <71496f9295e68388ce07f3051bf5882177be83c5.1679149543.git.william.gray@linaro.org>
 <ZBhRb+v/8+vSwjz6@smile.fi.intel.com>
 <ZBh8O5oOL0TB9wzT@fedora>
 <ZBh9cUwvV+hi5We8@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="fyOpXYjtQdJyq73T"
Content-Disposition: inline
In-Reply-To: <ZBh9cUwvV+hi5We8@smile.fi.intel.com>
Precedence: bulk


--fyOpXYjtQdJyq73T
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 20, 2023 at 05:36:17PM +0200, Andy Shevchenko wrote:
> On Mon, Mar 20, 2023 at 11:31:07AM -0400, William Breathitt Gray wrote:
> > On Mon, Mar 20, 2023 at 02:28:31PM +0200, Andy Shevchenko wrote:
> > > On Sat, Mar 18, 2023 at 10:59:51AM -0400, William Breathitt Gray wrot=
e:
> > > > The Preset Register (PR), Flag Register (FLAG), and Filter Clock
> > > > Prescaler (PSC) have common usage patterns. Wrap up such usage into
> > > > dedicated functions to improve code clarity.
>=20
> ...
>=20
> > > > +static void quad8_preset_register_set(struct quad8 *const priv, co=
nst size_t id,
> > > > +				      const unsigned long preset)
> > > > +{
> > > > +	struct channel_reg __iomem *const chan =3D priv->reg->channel + i=
d;
> > > > +	int i;
> > > > +
> > > > +	/* Reset Byte Pointer */
> > > > +	iowrite8(SELECT_RLD | RESET_BP, &chan->control);
> > > > +
> > > > +	/* Set Preset Register */
> > > > +	for (i =3D 0; i < 3; i++)
> > > > +		iowrite8(preset >> (8 * i), &chan->data);
> > > > +}
> > >=20
> > > May we add generic __iowrite8_copy() / __ioread8_copy() instead?
> > >=20
> > > It seems that even current __ioread32_copy() and __iowrite32_copy() h=
as to
> > > be amended to support IO.
>=20
> > Sure, I would use __iowrite8_copy() / __ioread8_copy() for these
> > situations if it were available.
>=20
> If needed, you may always introduce ones.
>=20
> > Is something equivalent available for the regmap API? I'm planning to
> > migrate this driver to the regmap API soon after this patch series is
> > merged, so the *_copy() calls would need to migrated as well.
>=20
> Yes. It's regmap bulk operations.
>=20
> --=20
> With Best Regards,
> Andy Shevchenko

After reading through the implementation for these functions I realized
they are actually doing something different than what's happening here.
The 104-QUAD-8 device exposes the 24-bit register by consecutive 8-bit
I/O operations on the same address; however, the iomap_copy and regmap
bulk functions operate on different addresses.

I'm not sure if there really is a way to make the 104-QUAD-8 operation
more generic for other drivers because it configures the current byte
pointer through a separate register from the data register (all of this
feel rather device specific), so I suspect keeping this function local
to 104-quad-8 is best for now.

William Breathitt Gray

--fyOpXYjtQdJyq73T
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZBiBgAAKCRC1SFbKvhIj
K0wDAP93HV0Gj4xeiDWBbHeWFLfyhiSf9flnQYpPqdmqPGdVbgEAwZeASq9k6oCj
N8Y4mIL7yRicTVlpTwZScTJC72bLnww=
=ZNfg
-----END PGP SIGNATURE-----

--fyOpXYjtQdJyq73T--