Date:   Mon, 20 Mar 2023 18:30:28 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn@kernel.org>,
        Magnus Karlsson <magnus.karlsson@intel.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH net-next 11/11] net: enetc: add TX support for
 zero-copy XDP sockets
Message-ID: <20230320163028.vyjaye7vode2euxc@skbuf>
References: <20230206100837.451300-1-vladimir.oltean@nxp.com>
 <20230206100837.451300-12-vladimir.oltean@nxp.com>
 <Y+PPzz4AHRxZgs9r@boxer>
 <20230208170815.nsq77mpkpf7aamhg@skbuf>
 <Y+PZQBWRqyNf9GlS@boxer>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y+PZQBWRqyNf9GlS@boxer>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?r5Dcx02gBifw0498wxFuGIue6aL9PnNUiAYdmJ+O8ZC/zRLXQZUvEilQxIXl?=
 =?us-ascii?Q?bRzYyr/trM0BF0fN2iOt/brtC6H2gP12kvus98YIVA0JncOoNGcg+LIHHVQ6?=
 =?us-ascii?Q?5QnH+3fFZCLDWxgwhTxwCZiGf+FJdGXeHIGT0Pf+oYmJLuaC1l8Iwu0T7TSK?=
 =?us-ascii?Q?92dmsa6F7LtQ+ZF6OT7lA6v3w5i8AFL1d9DTF2zUojupXSS36HV79skeIUTV?=
 =?us-ascii?Q?BWoHUWgvTsFXp+SA03X0eTjdbe2k9VPEVDrXFt0bSMTHbRLj3fGCU7dF0BMC?=
 =?us-ascii?Q?6gTAHbN09LGqep64e8obvqZvysu046uLKef7IKtU6asgCF1HE/aC8cYDGTHH?=
 =?us-ascii?Q?KMnt+J1rdY3P7B3Spbm12e8XS+DNGo6vcLV0JOYM7b/FrIMMbvxtm5xgby8/?=
 =?us-ascii?Q?NlWVTw0pw4d5E9rAyfYgUJmZs0Ee1VKICNYHVviAaXN0bwo/hqDxtGM0uK1I?=
 =?us-ascii?Q?1lWaGINuGSbV7SupAj8/NP6xu5FUaYTNxqQ+8ULCWZoa2HoXZUfgwNZQd0O9?=
 =?us-ascii?Q?DgiFsuApuyt4u0xBVHU17Mr/NSG96Gds4ybwT77rNQ9KQPrRNV0ez3utHQU7?=
 =?us-ascii?Q?J1kzQE96IryWKjmcsMLfBMCiLTY6aAgGeMmQNQLME9NHOcfqPZKIu4W8R454?=
 =?us-ascii?Q?HXTY7TmBV8tP13HKhCXO4iiVw1gxkyMeXqfM+1ej8faRZu9B5aq9kvD0+Hbr?=
 =?us-ascii?Q?c44QZsFdYXmtpQPXbyQxnNO696CFH1Ry3oA3Jzrszhan8uoWGidC4vH/nbby?=
 =?us-ascii?Q?+z9J8eMCkwJsXE7YxHXX/UeXSqq1xehmiQ6V49lLbigzxxm880r7hfE5j/lj?=
 =?us-ascii?Q?X6uLoYmJYYq0PrvKOx0ci3VVbDa98EIthKZmFiFq0fIdnGjnE6MNS1f6JMBx?=
 =?us-ascii?Q?9K6ihJgjsbvcACUD38cvy18mbBWzA/BpF0LfD0b9OvMyoDy03sQSHvnudLax?=
 =?us-ascii?Q?Bt0YR87o1iThUBMm8bSJRRL0blsYX8Iizf9xYL8jkYxeJcj2LknhLD0ci3Zh?=
 =?us-ascii?Q?lsz3gZydGzaly8bhsYJOY7F1JPhSGel6y9FXT79y4hUJxg2sgv3loiW5GLL8?=
 =?us-ascii?Q?LXpogO6+Xya2hbNXnARZvmqXFCijW5bWctmHNeTcgLCsDV5JiCnv8QwOxanW?=
 =?us-ascii?Q?u5JV5HI/eMrftDVqOO1SHcbLT8Z67od6Mkp2xszTvjRWi1nyynrJpPBn1EM7?=
 =?us-ascii?Q?H1FDA0ZVSxkBTILoQVx/BnD6d6Bi4UQYHk3VXpZLUIbSh4WGb63cOcP1eFER?=
 =?us-ascii?Q?KgpGv+U1VUDijvj+g4H8S5x3O7FVvREJOqMPE9ott11oSKCyDaUfjIootcNO?=
 =?us-ascii?Q?upQYVtKd5ljQnYQMINQG3L1LFFhay3XM8cDwDhfNhCCxOr9UoxYQ8D1D9xsO?=
 =?us-ascii?Q?l4HRyMxpATqBQzxmmE+E00j0P4t/LO88Cir2l4G4hQtziRZxXp/ljob8eYZ+?=
 =?us-ascii?Q?OC/wRCxIJx9ljjXhhoqoH/8gjSMkfQUiLslNNu//B7/TiGNe6aekSEGZRvP+?=
 =?us-ascii?Q?Ub1u/szVkzm9OoQhlFafju+QKA26XMl2WAji/UJ5AAM+sF7ClTOcmZVR5Sjn?=
 =?us-ascii?Q?i2KlwbWUZRiMOrH2vdkRnJRJqXpNc+vL9WxfJGDMxq0yJ9AQMIWwBvsoliAm?=
 =?us-ascii?Q?9Q=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c22f58ea-9d2f-49a9-614b-08db296072ad
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 16:30:42.2496
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bL7KgLlb/wgjRDcJ/WyXFEd+RSyUyb04+By7RCJd10FcFypNDctrvtuNCA+AE0p2M0pbvwQ3X/zE5Obvj5yEpQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8924
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Maciej,

On Wed, Feb 08, 2023 at 06:17:52PM +0100, Maciej Fijalkowski wrote:
> Ok i was referring to the thing that using cpu id on both sides would
> address concurrency. Regarding your need, what i did for ice was that i
> assign xdp_ring to the rx_ring and within ndo_xsk_wakeup() i pick the
> rx_ring based on queue_id that comes as an arg:
> 
> https://lore.kernel.org/bpf/20220822163257.2382487-3-anthony.l.nguyen@intel.com/

I looked at your response a few times in the past month, and I'm sorry
to say, but I don't have enough background in the ice driver to really
understand what you're saying and how that helps in the given situation.
If you could rephrase or explain some more, that would be great.