Date:   Mon, 20 Mar 2023 12:35:05 -0400
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Jonathan Cameron <jic23@kernel.org>
Cc:     Lars-Peter Clausen <lars@metafoo.de>, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: addac: stx104: Migrate to the regmap API
Message-ID: <ZBiLOWI+0JIWv6BC@fedora>
References: <20230319202256.352939-1-william.gray@linaro.org>
 <ZBiBBJOmjOAHGUn0@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Mo70mDQ9Y5gMfduf"
Content-Disposition: inline
In-Reply-To: <ZBiBBJOmjOAHGUn0@smile.fi.intel.com>
Precedence: bulk


--Mo70mDQ9Y5gMfduf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 20, 2023 at 05:51:32PM +0200, Andy Shevchenko wrote:
> On Sun, Mar 19, 2023 at 04:22:56PM -0400, William Breathitt Gray wrote:
> > The regmap API supports IO port accessors so we can take advantage of
> > regmap abstractions rather than handling access to the device registers
> > directly in the driver.
>=20
> ...
>=20
> > -/**
> > - * struct stx104_iio - IIO device private data structure
>=20
> I believe this...
>=20
> > - * @chan_out_states:	channels' output states
> > - * @reg:		I/O address offset for the device registers
> > - */
>=20
> > -struct stx104_iio {
>=20
> ...and this can be left here. With that the diff won't be too disrupted.

You're right Andy, I'll adjust this in v2 so the diff becomes clearer
(along with some bitfield API adjustments).

William Breathitt Gray

--Mo70mDQ9Y5gMfduf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZBiLOQAKCRC1SFbKvhIj
K4mhAP0X4e0URt1B/OmADC0I6wHTfGwBjKH5mtvHT1WW1wuHigEA61l1xgzekaCf
trv33LQPL/2RPR54pEiYhuTyf6u/+gw=
=KM3F
-----END PGP SIGNATURE-----

--Mo70mDQ9Y5gMfduf--