From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     Khadija Kamran <kamrankhadijadj@gmail.com>
Cc:     outreachy@lists.linux.dev,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8] staging: axis-fifo: initialize timeouts in init only
Date:   Mon, 20 Mar 2023 17:55:20 +0100
Message-ID: <3648719.TKLx3GfHUD@suse>
In-Reply-To: <ZBhvU/USP0es8e4P@khadija-virtual-machine>
References: <ZBN3XAsItCiTk7CV@khadija-virtual-machine> <3180435.l52yBJDM9G@suse>
 <ZBhvU/USP0es8e4P@khadija-virtual-machine>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

On luned=EC 20 marzo 2023 15:36:03 CET Khadija Kamran wrote:
> On Mon, Mar 20, 2023 at 02:38:24PM +0100, Fabio M. De Francesco wrote:
> > On luned=EC 20 marzo 2023 07:34:04 CET Khadija Kamran wrote:
> > > On Fri, Mar 17, 2023 at 11:29:25AM +0100, Fabio M. De Francesco wrote:
> > > > Khadija,
> > > >=20
> > > > Congratulations for having your first patch in Linux, via Greg's=20
staging
> > > > tree.
> > > >=20
> > > > It will take some time before it reaches mainline, although it is
> > > > already on its way to get upstream.
> > >=20
> > > [snip]
> > >
> > I'm confused by this statement. Can you please rephrase?
> >=20
> > > Am I getting it right?
> >=20
> > Not sure, it depends on what you meant with the previous phrase.
>=20
> As you said above that the commit message makes the reader miss the
> permission details, so should we write more about permissions in the
> description?

No. Greg took your patch as is.
No new versions for patches that Maintainers (i.e., Greg Kroah-Hartman for=
=20
drivers/staging and several other subsystems and drivers) already applied.

We've been discussing this topic after Greg had already taken your patch on=
ly=20
for the purpose to clarify to you why he suggested a better commit message.=
=20
However, he suggested that better message while stating that he prefers to=
=20
take your patch as is to give you time to work on something new.

I suppose that you received the two automated messages, the first which=20
communicates that your patch has been applied to his staging-test tree and =
the=20
second which says that it has moved forward to the next step, which is the=
=20
staging-next tree. I saw those messages in Cc because I put my "Reviewed-by=
"=20
tag to your patch, so I know you had them.

=46abio

P.S.: Today I sent you an off-list message. Please locate it and reply.

> > > Thank you!
> > >=20
> > > Regards,
> > > Khadija
> >=20
> > You're welcome!
> >=20
> > So, thanks for working on this patch as long as it takes to get it done.
> >=20
> > I think the lesson to be learned is that in our community there are=20
barriers
> > to the entry of substandard products and therefore people have to do th=
eir
> > best if they really want to see their work applied.
>=20
> Yes, you are right. Due to this reason, the whole process is making me
> learn a lot. I am really glad to be a part of it ^-^
>=20
> > These tasks are not for the "faints of heart" :-)
> >=20
> > Fabio
>=20
> Regards,
> Khadija :)