Message-ID: <042eaf9e-df89-63c6-e174-fed6f39e27b2@intel.com>
Date:   Mon, 20 Mar 2023 10:00:15 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.9.0
Subject: Re: [PATCH v3 5/7] x86/resctrl: Display the RMID and COSID for
 resctrl groups
Content-Language: en-US
To:     <babu.moger@amd.com>, <corbet@lwn.net>, <tglx@linutronix.de>,
        <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <167778850105.1053859.14596357862185564029.stgit@bmoger-ubuntu>
 <167778869402.1053859.6094569492538617564.stgit@bmoger-ubuntu>
 <f31e9db6-2ae7-83de-1b4b-4dd802a9da02@intel.com>
 <567d0e3d-4eab-5da3-7566-bcee5623c0e8@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <567d0e3d-4eab-5da3-7566-bcee5623c0e8@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUNrZjdSWFJNNnM1bDBaRVd5WW9aWXoyT3pGbHNFdjlJeDhzdjNXOHgweTA0?=
 =?utf-8?B?aDR6SE5xTXFSY3Q0ZGE0aHBpYUZkWld0K3JYVUI3OWJRTW1oTWFDRHhRQ0U5?=
 =?utf-8?B?dnNzdU1vN0VEOFlMOURIL1ArYzNPeUYrbXdham5kTE16azBXb3VtbVlsS0ZQ?=
 =?utf-8?B?NjNmTUtQR1FxVzg5Mm5VeUNXbTZJRlo3OHF4N3dVR240c2tXVVJjTTYxaitG?=
 =?utf-8?B?WFdDbnRYTVBIdFVuTXMwMkhsSGdWNnFkemp0NC90YllHbnhvQ2pobmJWaDdN?=
 =?utf-8?B?U0lPQU1pZXRWZXdPb1AvT0pzZ2FXYlBmYi9DcEx3ZUhCTi83S1ZZeURXZ2Fq?=
 =?utf-8?B?OFVaM2laRUt0MTBDNUpoVk1FZi9oUG1ZUUtTK0l6Z2p4MFd1Q0VXT1JkL2d5?=
 =?utf-8?B?UXkrNkI3Rkl3ZlYxOWdXdCtmaU1UUlQwbWRVNE1oZmdTMm5FRGorTGxSeXVj?=
 =?utf-8?B?TTJpbVB3ZTdBOEFybWpYMFlVV2VDMW9tZHlqRkR6R3lucVZlS3lvY0xFNWVV?=
 =?utf-8?B?WEpYakZsNktCT3MzQklMM3p1ZEw3QTFLQnN5dFBaSGtVMG0yMTd3L3U4NUV1?=
 =?utf-8?B?WXU3TzMyM1BRcmc5czN6NHkvZmYwRHkrRHNxUjhqWVlweHByQWhwZWxPSlk1?=
 =?utf-8?B?VnJkdC9zS0hLZEovSklqYm13cTFzWnYzVEFURFUzU3VxTktTL3ppWU9CQ2Uv?=
 =?utf-8?B?RnJacnF1VmZVcUZiRkpzR0ZQTzVMVFFpTDkwSjFaVUY4cnRDQ3JKdDIrKzdr?=
 =?utf-8?B?QWx2N1NRM28rNHlQQVBHUERwUkNTWXdoNlRzNkl1T2xyMlJPcVoxbTlubkU5?=
 =?utf-8?B?Q3pCZmd2Vlg5R0g3eHFyandGTHhrUjBFdjJMUWF6WTRMaGJxWW4rTEV2NEZC?=
 =?utf-8?B?QTI1Z2FsK0JwRXFaZmJ2bFdWNE1TSjFxRy8rSVdOQUJWSlVmRldDTGs2YjRC?=
 =?utf-8?B?RHNTRXUveHpwc1plRyt2Y0xvbGJLR2dFRTZiUWMrY0FBaVJhM0FYTzZtM1dh?=
 =?utf-8?B?U0lIc0gra2w4OTlHQkRTRzhlaVNrb1NqazBCQjMrL3dXVEZZR2YyZUh6eUox?=
 =?utf-8?B?bzg2YnNTanFPWWZIMzdvbG5QaGlrWHNHR25SWEx4NmNuWEZkaWdyRFVCWXpH?=
 =?utf-8?B?VUl1M21TTTdWYW1xT1hRUEtiTHJyV3BJU0RvSjc3YytUOVpvekJtZU9qUzkr?=
 =?utf-8?B?endrNVZMVkc1MGJOY2pyeVJYNlFoSDhwNWZ4eGpBSmxobzViRW1NYVZzRWE4?=
 =?utf-8?B?dlJlMzEzMmU1NmdYNHptYU9GTk5pclBtODFzcmZNZXRVdVJuRVo0T1ZqMUpx?=
 =?utf-8?B?aDVJRWhucjRPaHhLVWdTYmEwcVdqVDN0UjBkYk9ua2VqUGZUNmw0d3JhdWNL?=
 =?utf-8?B?SVRvc2wyN3EwN3NYUGFGZSt3TjB5VUJ5MGVBK2hvRVZGa2ZDbC95bGtPaWpI?=
 =?utf-8?B?bXlCcE03dlMybFowQUVHZ2t3MHBiTEh0dlhQSHRwTjhmZnM4dk8zYTZzcUt4?=
 =?utf-8?B?cTBlNVVSUE5WR0UrYTQ0MDdxMEQ1MXRhM0JpSkd0VDcrZ0NrUVNmS0hvb215?=
 =?utf-8?B?emxxc3RUb0VQZmhuaythQldTMFlkZ2sxMDJrUHJZRDhxU2lHN3NkNWEzaGU4?=
 =?utf-8?B?K0VLSkMyRDg3bFd5Wnd0aG1JTVEyc3NHd29aVkZZd3ZFdVJIcmhaUGpaT3lC?=
 =?utf-8?B?aDB4djlqMUxOdSthV2tFWGZudmF5RHJHYjJ1Wm1sYk5sOUhVR1BXOHZuanU5?=
 =?utf-8?B?b1RucnlMZm85WSs5U2IwRVk1MEhnSk1VNXU0QXEza2tySU14dUZjbitvOEJw?=
 =?utf-8?B?Q1NQY3p3SDZkc1FMZHlTZEFaOUtVQklGYnd0RG94bGFsLzZMTHJWcFFhZXdM?=
 =?utf-8?B?M1VkRnF4VXlIR2h3TllNY0dwRk9JWkcyUVZ3djh1ODNnMG50cEVDb3NyaU1F?=
 =?utf-8?B?ZXpsaUVRcEhWNnZhb3NwRWdWV0d0ZGZCYUY4T3FiNHhjeDVDMzJHUTZYN3o3?=
 =?utf-8?B?Q0hiRjVTY0MwRnF1NjYwdmpFMTQreEhqZGpQQ0VkNmo1bENWNWJVVmtHNkF0?=
 =?utf-8?B?L2dQSU5GK0FJM1V6VC8xMkhnM29pNE5xZCtocThObGZoaGYxR1ZlUmRSTGps?=
 =?utf-8?B?NnNZUEVRU2d1L0t3SDFwWlZLVzlZWFA3aW9vaG1hdWMxUWU5V3RYVG9WclpF?=
 =?utf-8?B?RWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 22a3c255-1bca-47f2-4999-08db296495e4
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 17:00:19.3791
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7vsO3sxbypwJP8CQjHvZZwzS+c54OfI66APL42sIAHuoeCaN2f/T545rVs7wvLSdLH9JVQJrPfYHxsK8jY94FuhWv3EmJlNPbUYNj/pLVwU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7749
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 3/20/2023 9:52 AM, Moger, Babu wrote:
> On 3/15/23 13:42, Reinette Chatre wrote:

...

>>
>>
>>>  When monitoring is enabled all MON groups will also contain:
>>>  
>>
>> Shouldn't the "rmid" (to be renamed) entry be in this section of the
>> documentation?
> 
> Not sure about this comment. Did you mean to move the rmid (to be renamed
> mon_hw_id) documentation here?


Yes. Note the header reads "When monitoring is enabled all MON groups
will also contain:". The new file is only relevant to monitoring groups, so
it seems appropriate that it falls under this section. 

Reinette